28261 2009-08-13 09:30:57 -0700 REGRESSION(r47175): error running run-webkit-tests 2009-08-13 11:35:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned ddkilzer simon.fraser oldest_to_newest 139871 0 eric 2009-08-13 09:30:57 -0700 Use of uninitialized value in concatenation (.) or string at WebKitTools/Scripts/run-webkit-tests line 191. I have a fix. 139872 1 34750 eric 2009-08-13 09:32:49 -0700 Created attachment 34750 Patch v1 139874 2 eric 2009-08-13 09:33:31 -0700 It was being used in the $usage string before being set. 139927 3 34750 eric 2009-08-13 10:59:33 -0700 Comment on attachment 34750 Patch v1 Rejecting patch 34750 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None 139930 4 ddkilzer 2009-08-13 11:00:22 -0700 (In reply to comment #0) > Use of uninitialized value in concatenation (.) or string at > WebKitTools/Scripts/run-webkit-tests line 191. *sigh* I should just stop working on tools. My record hasn't been very good recently. 139931 5 34750 eric 2009-08-13 11:01:55 -0700 Comment on attachment 34750 Patch v1 Sigh. a checkin happend right as bugzilla-tool was about to land this. adding it back to the queue. 139932 6 eric 2009-08-13 11:02:34 -0700 (In reply to comment #4) > (In reply to comment #0) > > Use of uninitialized value in concatenation (.) or string at > > WebKitTools/Scripts/run-webkit-tests line 191. > > *sigh* I should just stop working on tools. My record hasn't been very good > recently. I would be very sad were that to be the case! We just need to get you hackin on the python stuff which is actually unit-testable. :) 139940 7 34750 eric 2009-08-13 11:14:01 -0700 Comment on attachment 34750 Patch v1 Rejecting patch 34750 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None 139948 8 34750 eric 2009-08-13 11:35:03 -0700 Comment on attachment 34750 Patch v1 Clearing flags on attachment: 34750 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests Committed r47223 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests r47223 = f1aeff7782adc69b65427803575711023b57ada0 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47223 139949 9 eric 2009-08-13 11:35:07 -0700 All reviewed patches have been landed. Closing bug. 34750 2009-08-13 09:32:49 -0700 2009-08-13 11:35:03 -0700 Patch v1 bug-28261-20090813093248.patch text/plain 1397 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1Y2RjMGYzLi4xOTA0MjMxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDgt MTMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04ocjQ3MTc1KTogZXJyb3IgcnVu bmluZyBydW4td2Via2l0LXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yODI2MQorCisgICAgICAgIEZpeCAiVXNlIG9mIHVuaW5pdGlhbGl6ZWQg dmFsdWUgaW4gY29uY2F0ZW5hdGlvbiAoLikgb3Igc3RyaW5nIGF0CisgICAgICAgIFdlYktpdFRv b2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cyBsaW5lIDE5MS4iIGJ5IHNldHRpbmcKKyAgICAg ICAgJHRlc3RzUGVyRHVtcFRvb2wgdG8gMTAwMCBieSBkZWZhdWx0LgorCisgICAgICAgICogU2Ny aXB0cy9ydW4td2Via2l0LXRlc3RzOgorCiAyMDA5LTA3LTE3ICBFcmljIFNlaWRlbCAgPGVyaWNA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwppbmRleCA0OGFlM2VhLi5kZTBjNGE2IDEwMDc1NQot LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKKysrIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCkBAIC0xMjIsNyArMTIyLDcgQEAgbXkgJHJlcG9y dDEwU2xvd2VzdCA9IDA7CiBteSAkcmVzZXRSZXN1bHRzID0gMDsKIG15ICRzaG91bGRDaGVja0xl YWtzID0gMDsKIG15ICRzaG93SGVscCA9IDA7Ci1teSAkdGVzdHNQZXJEdW1wVG9vbDsKK215ICR0 ZXN0c1BlckR1bXBUb29sID0gMTAwMDsKIG15ICR0ZXN0SFRUUCA9IDE7CiBteSAkdGVzdE1lZGlh ID0gMTsKIG15ICR0ZXN0UmVzdWx0c0RpcmVjdG9yeSA9ICIvdG1wL2xheW91dC10ZXN0LXJlc3Vs dHMiOwpAQCAtMjc5LDggKzI3OSw2IEBAIG15ICRza2lwcGVkT25seSA9ICR0cmVhdFNraXBwZWQg ZXEgIm9ubHkiOwogCiBteSAkY29uZmlndXJhdGlvbiA9IGNvbmZpZ3VyYXRpb24oKTsKIAotJHRl c3RzUGVyRHVtcFRvb2wgPSAxMDAwIGlmICEkdGVzdHNQZXJEdW1wVG9vbDsKLQogJHZlcmJvc2Ug PSAxIGlmICR0ZXN0c1BlckR1bXBUb29sID09IDE7CiAKIGlmICgkc2hvdWxkQ2hlY2tMZWFrcyAm JiAkdGVzdHNQZXJEdW1wVG9vbCA+IDEwMDApIHs=