282593 2024-11-05 01:37:19 -0800 [Navigation] Navigation.navigate() should trigger the 'beforeunload' event synchronously 2024-12-19 10:54:03 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED BrowserCompat, InRadar, WPTImpact P2 Normal --- 284637 258384 1 rbuis cdumez achristensen beidson cdumez karlcow webkit-bug-importer oldest_to_newest 2072752 0 rbuis 2024-11-05 01:37:19 -0800 Support beforeunload on subframes. 2072756 1 rbuis 2024-11-05 01:42:38 -0800 This is blocking many navigation-api WPT tests, for example: navigation-api/navigate-event/navigate-navigation-back-cross-document.html navigation-api/navigation-methods/return-value/back-beforeunload.html navigation-api/navigation-methods/return-value/forward-beforeunload.html navigation-api/navigation-methods/return-value/navigate-beforeunload.html navigation-api/navigation-methods/return-value/navigate-rejection-order-beforeunload-unserializablestate.html navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-beforeunload.html navigation-api/navigation-methods/return-value/reload-beforeunload.html navigation-api/navigation-methods/return-value/reload-rejection-order-beforeunload-unserializablestate.html navigation-api/navigation-methods/return-value/traverseTo-beforeunload.html 2072934 2 rbuis 2024-11-05 13:19:05 -0800 Note that this is not just for the benefit of navigation api though, it should allow interoperability with Chrome and gecko too. 2074205 3 webkit-bug-importer 2024-11-10 22:06:02 -0800 <rdar://problem/139628818> 2075985 4 cdumez 2024-11-18 16:03:38 -0800 We do dispatch beforeunload in subframes. The issue is that the tests seem to expect the beforeunload event to get fired *synchronously* when calling `navigate()`. In WebKit, it gets called asynchronously since there is a navigation policy decision that happens before we navigate and this policy decision is normally async. 2076109 5 rbuis 2024-11-19 05:56:31 -0800 (In reply to Chris Dumez from comment #4) > We do dispatch beforeunload in subframes. The issue is that the tests seem > to expect the beforeunload event to get fired *synchronously* when calling > `navigate()`. In WebKit, it gets called asynchronously since there is a > navigation policy decision that happens before we navigate and this policy > decision is normally async. Thanks Chris, I renamed the bug so it reflects it is a problem with Navigation API + beforeunload on subframes, not beforeunload on subframes by itself. 2076133 6 cdumez 2024-11-19 07:47:41 -0800 BTW, I tried making the policy decision synchronous but it caused other issues. If the navigation happens synchronously, then it ends up canceling the *current* navigation (triggered by Navigation API) and we fire the navigateerror event. This doesn't happen when the navigation happens asynchronously. 2076508 7 cdumez 2024-11-20 14:00:32 -0800 Pull request: https://github.com/WebKit/WebKit/pull/36915 2076766 8 ews-feeder 2024-11-21 11:48:22 -0800 Committed 286919@main (4c2147c4b2aa): <https://commits.webkit.org/286919@main> Reviewed commits have been landed. Closing PR #36915 and removing active labels. 2081582 9 cdumez 2024-12-13 12:01:55 -0800 Re-opening since the patch got reverted because of a Speedometer regression. 2082071 10 cdumez 2024-12-16 10:07:03 -0800 Pull request: https://github.com/WebKit/WebKit/pull/38019 2083059 11 ews-feeder 2024-12-19 10:54:01 -0800 Committed 288106@main (9fb3593f38c1): <https://commits.webkit.org/288106@main> Reviewed commits have been landed. Closing PR #38019 and removing active labels.