28256 2009-08-13 05:37:29 -0700 [Haiku] Remove the "m_point" code from ContextMenuHaiku.cpp 2009-08-13 10:08:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 0 simon.maxime webkit-unassigned eric leavengood oldest_to_newest 139813 0 simon.maxime 2009-08-13 05:37:29 -0700 Since we avoid m_point from ContextMenu.h (which in fact was unused), we must remove the code in ContextMenuHaiku.cpp. Regards, Maxime 139814 1 34736 simon.maxime 2009-08-13 05:40:40 -0700 Created attachment 34736 Patch v1 139890 2 34736 eric 2009-08-13 09:55:11 -0700 Comment on attachment 34736 Patch v1 LGTM. 139902 3 34736 eric 2009-08-13 10:08:25 -0700 Comment on attachment 34736 Patch v1 Clearing flags on attachment: 34736 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/haiku/ContextMenuHaiku.cpp Committed r47206 M WebCore/ChangeLog M WebCore/platform/haiku/ContextMenuHaiku.cpp r47206 = a7c4a7d27fb5318345ea1916397eb2cf5016e482 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47206 139903 4 eric 2009-08-13 10:08:29 -0700 All reviewed patches have been landed. Closing bug. 34736 2009-08-13 05:40:40 -0700 2009-08-13 10:08:25 -0700 Patch v1 bug-28256-20090813144037.patch text/plain 3400 simon.maxime ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGUzYzdjOC4uZmI4MmM0NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOC0xMyAgTWF4aW1lIFNpbW9u ICA8c2ltb24ubWF4aW1lQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbSGFpa3VdIFJlbW92ZSB0aGUgIm1fcG9pbnQiIGNvZGUgZnJv bSBDb250ZXh0TWVudUhhaWt1LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjgyNTYKKworICAgICAgICAqIHBsYXRmb3JtL2hhaWt1L0NvbnRleHRN ZW51SGFpa3UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGV4dE1lbnVSZWNlaXZlcjo6Q29u dGV4dE1lbnVSZWNlaXZlcik6CisgICAgICAgIChXZWJDb3JlOjpDb250ZXh0TWVudTo6Q29udGV4 dE1lbnUpOgorICAgICAgICAoV2ViQ29yZTo6Q29udGV4dE1lbnU6OmFwcGVuZEl0ZW0pOgorICAg ICAgICAoV2ViQ29yZTo6Q29udGV4dE1lbnU6Omluc2VydEl0ZW0pOgorCiAyMDA5LTA4LTEzICBE YXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1 aWxkIGZpeCBmb3IgQ2hyb21pdW0gTGludXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L2hhaWt1L0NvbnRleHRNZW51SGFpa3UuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9oYWlrdS9Db250 ZXh0TWVudUhhaWt1LmNwcAppbmRleCAwM2I4OTc4Li5iOTc4NDMzIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2hhaWt1L0NvbnRleHRNZW51SGFpa3UuY3BwCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vaGFpa3UvQ29udGV4dE1lbnVIYWlrdS5jcHAKQEAgLTI3LDMwICsyNywyNyBAQAogI2lu Y2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkNvbnRleHRNZW51LmgiCiAKLSNpbmNsdWRlICJD b250ZXh0TWVudUl0ZW0uaCIKICNpbmNsdWRlICJDb250ZXh0TWVudUNvbnRyb2xsZXIuaCIKKyNp bmNsdWRlICJDb250ZXh0TWVudUl0ZW0uaCIKKyNpbmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1 ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiRnJhbWVWaWV3LmgiCi0jaW5jbHVkZSAiRG9jdW1lbnQu aCIKLQotI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+Ci0KICNpbmNsdWRlIDxMb29wZXIuaD4K ICNpbmNsdWRlIDxNZW51Lmg+CiAjaW5jbHVkZSA8TWVzc2FnZS5oPgorI2luY2x1ZGUgPHd0Zi9B c3NlcnRpb25zLmg+CiAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiAvLyBGSVhNRTogVGhpcyBj bGFzcyBpc24ndCB1c2VkIHlldAotY2xhc3MgQ29udGV4dE1lbnVSZWNlaXZlciA6IHB1YmxpYyBC TG9vcGVyCi17CitjbGFzcyBDb250ZXh0TWVudVJlY2VpdmVyIDogcHVibGljIEJMb29wZXIgewog cHVibGljOgogICAgIENvbnRleHRNZW51UmVjZWl2ZXIoQ29udGV4dE1lbnUqIG1lbnUpCiAgICAg ICAgIDogQkxvb3BlcigiY29udGV4dF9tZW51X3JlY2VpdmVyIikKICAgICAgICAgLCBtX21lbnUo bWVudSkKKyAgICAgICAgLCBtX3Jlc3VsdCgtMSkKICAgICB7Ci0gICAgICAgIG1fcmVzdWx0ID0g LTE7CiAgICAgfQogCiAgICAgdm9pZCBIYW5kbGVNZXNzYWdlKEJNZXNzYWdlKiBtc2cpCkBAIC04 MCwyMSArNzcsOCBAQCBwcml2YXRlOgogCiBDb250ZXh0TWVudTo6Q29udGV4dE1lbnUoY29uc3Qg SGl0VGVzdFJlc3VsdCYgcmVzdWx0KQogICAgIDogbV9oaXRUZXN0UmVzdWx0KHJlc3VsdCkKLSAg ICAsIG1fcGxhdGZvcm1EZXNjcmlwdGlvbihOVUxMKQorICAgICwgbV9wbGF0Zm9ybURlc2NyaXB0 aW9uKG5ldyBCTWVudSgiY29udGV4dF9tZW51IikpCiB7Ci0gICAgLyogR2V0IHBvc2l0aW9uICov Ci0gICAgaWYgKHJlc3VsdC5pbm5lck5vZGUoKSAmJiByZXN1bHQuaW5uZXJOb2RlKCktPmRvY3Vt ZW50KCkpIHsKLSAgICAgICAgQlZpZXcqIHZpZXcgPSByZXN1bHQuaW5uZXJOb2RlKCktPmRvY3Vt ZW50KCktPmZyYW1lKCktPnZpZXcoKS0+cGxhdGZvcm1XaWRnZXQoKTsKLSAgICAgICAgaW50IGNo aWxkID0gMDsKLSAgICAgICAgd2hpbGUgKHZpZXctPkNoaWxkQXQoY2hpbGQpKSB7Ci0gICAgICAg ICAgICBpZiAodmlldy0+Q2hpbGRBdChjaGlsZCktPk5hbWUoKSA9PSAic2Nyb2xsX3ZpZXdfY2Fu dmFzIikgewotICAgICAgICAgICAgICAgIG1fcG9pbnQgPSB2aWV3LT5DaGlsZEF0KGNoaWxkKS0+ Q29udmVydFRvU2NyZWVuKEJQb2ludChyZXN1bHQucG9pbnQoKS54KCksIHJlc3VsdC5wb2ludCgp LnkoKSkpOwotICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgfQotICAgICAgICAg ICAgY2hpbGQrKzsKLSAgICAgICAgfQotICAgIH0KLSAgICBtX3BsYXRmb3JtRGVzY3JpcHRpb24g PSBuZXcgQk1lbnUoImNvbnRleHRfbWVudSIpOwogfQogCiBDb250ZXh0TWVudTo6fkNvbnRleHRN ZW51KCkKQEAgLTEwNiw5ICs5MCw5IEBAIHZvaWQgQ29udGV4dE1lbnU6OmFwcGVuZEl0ZW0oQ29u dGV4dE1lbnVJdGVtJiBpdGVtKQogewogICAgIGNoZWNrT3JFbmFibGVJZk5lZWRlZChpdGVtKTsK IAotICAgIEJNZW51SXRlbSogYkl0ZW0gPSBpdGVtLnJlbGVhc2VQbGF0Zm9ybURlc2NyaXB0aW9u KCk7Ci0gICAgaWYgKGJJdGVtKQotICAgICAgICBtX3BsYXRmb3JtRGVzY3JpcHRpb24tPkFkZEl0 ZW0oYkl0ZW0pOworICAgIEJNZW51SXRlbSogbWVudUl0ZW0gPSBpdGVtLnJlbGVhc2VQbGF0Zm9y bURlc2NyaXB0aW9uKCk7CisgICAgaWYgKG1lbnVJdGVtKQorICAgICAgICBtX3BsYXRmb3JtRGVz Y3JpcHRpb24tPkFkZEl0ZW0obWVudUl0ZW0pOwogfQogCiB1bnNpZ25lZCBDb250ZXh0TWVudTo6 aXRlbUNvdW50KCkgY29uc3QKQEAgLTEyMCw5ICsxMDQsOSBAQCB2b2lkIENvbnRleHRNZW51Ojpp bnNlcnRJdGVtKHVuc2lnbmVkIHBvc2l0aW9uLCBDb250ZXh0TWVudUl0ZW0mIGl0ZW0pCiB7CiAg ICAgY2hlY2tPckVuYWJsZUlmTmVlZGVkKGl0ZW0pOwogCi0gICAgQk1lbnVJdGVtKiBiSXRlbSA9 IGl0ZW0ucmVsZWFzZVBsYXRmb3JtRGVzY3JpcHRpb24oKTsKLSAgICBpZiAoYkl0ZW0pCi0gICAg ICAgIG1fcGxhdGZvcm1EZXNjcmlwdGlvbi0+QWRkSXRlbShiSXRlbSwgcG9zaXRpb24pOworICAg IEJNZW51SXRlbSogbWVudUl0ZW0gPSBpdGVtLnJlbGVhc2VQbGF0Zm9ybURlc2NyaXB0aW9uKCk7 CisgICAgaWYgKG1lbnVJdGVtKQorICAgICAgICBtX3BsYXRmb3JtRGVzY3JpcHRpb24tPkFkZEl0 ZW0obWVudUl0ZW0sIHBvc2l0aW9uKTsKIH0KIAogUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29u dGV4dE1lbnU6OnBsYXRmb3JtRGVzY3JpcHRpb24oKSBjb25zdA==