282406 2024-10-31 13:24:19 -0700 Enable -Wunsafe-buffer-usage in WebCore 2024-11-02 14:23:59 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 282497 1 ggaren ggaren rniwa webkit-bug-importer oldest_to_newest 2071953 0 ggaren 2024-10-31 13:24:19 -0700 ... 2071954 1 ggaren 2024-10-31 13:24:21 -0700 <rdar://problem/137810622> 2071955 2 ggaren 2024-10-31 13:25:21 -0700 Pull request: https://github.com/WebKit/WebKit/pull/36014 2072240 3 ews-feeder 2024-11-01 16:18:16 -0700 Committed 286031@main (67602317a964): <https://commits.webkit.org/286031@main> Reviewed commits have been landed. Closing PR #36014 and removing active labels. 2072278 4 rniwa 2024-11-01 19:12:48 -0700 Looks like this broke builds on safer C++ bots? Source/WebCore/crypto/cocoa/CryptoAlgorithmEd25519Cocoa.cpp:54:28: error: the two-parameter std::span construction is unsafe as it can introduce mismatch between buffer size and the bound information [-Werror,-Wunsafe-buffer-usage-in-container] 54 | return Vector<uint8_t>(std::span { newSignature, ed25519SignatureSize }); | ^ error: unsafe pointer operation [-Werror,-Wunsafe-buffer-usage] note: pass -fsafe-buffer-usage-suggestions to receive code hardening suggestions 2 errors generated. 2072279 5 ggaren 2024-11-01 19:21:30 -0700 Oh, that must be the #if !HAVE(SWIFT_CPP_INTEROP) config. Fixing.... 2072285 6 ggaren 2024-11-01 20:07:42 -0700 Trying out a fix in https://github.com/WebKit/WebKit/pull/36082 2072343 7 jbedard 2024-11-02 14:23:58 -0700 Reopened Bugzilla. REGRESSION(286031@main): Broke Internal iOS and visionOS Debug builds, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=282497.