28239 2009-08-12 16:49:57 -0700 bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode 2010-01-19 16:42:23 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth oldest_to_newest 139653 0 eric 2009-08-12 16:49:57 -0700 bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode It should not cq- minus patches when not in commit-queue mode. 139711 1 abarth 2009-08-12 20:04:11 -0700 Sorry. I should caught that when reviewing the earlier change. 157369 2 eric 2009-10-23 16:37:22 -0700 I'm not sure which circumstances produce this bug, making it difficult to fix. Should patches not be cq-'d when a build fails and you're not in commit mode? If not, we just need to conditionalize: except ScriptError, e: # Mark the patch as commit-queue- and comment in the bug. tool.bugs.reject_patch_from_commit_queue(patch['id'], e.message_with_output()) error(e) in LandPatchesFromBugs.land_patches 182511 3 eric 2010-01-19 16:42:23 -0800 I've not seen this in a long time.