28232 2009-08-12 14:33:18 -0700 "Null after navigation" in major-objects.html is unclear 2009-08-12 22:01:06 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 0 joenotcharles webkit-unassigned abarth oldest_to_newest 139552 0 joenotcharles 2009-08-12 14:33:18 -0700 Adam Barth explains the "null after navigation" comment in major-objects.html like this: > > "NULL after navigation" could be clearer - it suggests that DOMWindow and > > everything below it only exists if you type the URL, but not if a page is > > loaded by clicking a link, which can't be true. > > Oh, I meant navigate to cover both typing in the location bar and > clicking a link. Is there a better word to use for that? > > > Does it mean that it's NULL > > immediately after navigation, while waiting for the load, and is replaced by > > a valid pointer after loading? > > I wasn't sure the best way to represent this in the diagram. > Typically, the edge becomes null in the "up" direction and replaced > with a new object in the "down" direction. If you can think of a nice > way to explain this on the page, please file a bug, CC me, and upload > a patch. I think the best way to represent this is with a footnoted explanation. (Patch forthcoming) 139556 1 34693 joenotcharles 2009-08-12 14:38:49 -0700 Created attachment 34693 patch to html file 139710 2 34693 abarth 2009-08-12 20:01:24 -0700 Comment on attachment 34693 patch to html file Excellent! 139722 3 34693 abarth 2009-08-12 22:00:54 -0700 Comment on attachment 34693 patch to html file Clearing flags on attachment: 34693 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitSite/ChangeLog M WebKitSite/coding/major-objects.html Committed r47182 M WebKitSite/ChangeLog M WebKitSite/coding/major-objects.html r47182 = 9f401117450f829c83ec4f0940e4918f455e7d31 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47182 139723 4 abarth 2009-08-12 22:01:06 -0700 All reviewed patches have been landed. Closing bug. 34693 2009-08-12 14:38:49 -0700 2009-08-12 22:00:54 -0700 patch to html file bug28232.patch text/plain 2001 joenotcharles ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggMGU2ZjM2Ny4uZTQ1ZWIyMSAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0wOC0xMiAg Sm9lIE1hc29uICA8am9lLm1hc29uQHRvcmNobW9iaWxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCZXR0ZXIgZXhwbGFuYXRpb24gb2YgIk51 bGwgYWZ0ZXIgbmF2aWdhdGlvbiIgaW4gb2JqZWN0IGRpYWdyYW0KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4MjMyCisKKyAgICAgICAgKiBjb2Rpbmcv bWFqb3Itb2JqZWN0cy5odG1sOgorCiAyMDA5LTA4LTExICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUv Y29kaW5nL21ham9yLW9iamVjdHMuaHRtbCBiL1dlYktpdFNpdGUvY29kaW5nL21ham9yLW9iamVj dHMuaHRtbAppbmRleCBhNGVmZDU0Li44MTUwMjRjIDEwMDY0NAotLS0gYS9XZWJLaXRTaXRlL2Nv ZGluZy9tYWpvci1vYmplY3RzLmh0bWwKKysrIGIvV2ViS2l0U2l0ZS9jb2RpbmcvbWFqb3Itb2Jq ZWN0cy5odG1sCkBAIC0xNSw3ICsxNSw3IEBACiAKIDxoMT5NYWpvciBPYmplY3RzIGluIFdlYkNv cmU8L2gxPgogPGRpdj5BZGFtIEJhcnRoPC9kaXY+Ci08ZGl2PmZpcnN0IGRyYWZ0LCAyMDA5LTA4 LTExPC9kaXY+Cis8ZGl2PmZpcnN0IGRyYWZ0LCAyMDA5LTA4LTEyPC9kaXY+CiAKIDxwPldlYkNv cmUgdXNlcyBhIG51bWJlciBvZiBvYmplY3RzIHRvIHJlcHJlc2VudCBhIHdlYiBwYWdlIGluIG1l bW9yeS4gIFRoaXMKIGRvY3VtZW50IGRlc2NyaWJlcyB0aGUgbWFqb3Igb2JqZWN0cyBhbmQgdGhl IHJlbGF0aW9uIGJldHdlZW4gdGhlbS4gIEluIHNvbWUKQEAgLTQyLDcgKzQyLDcgQEAgdGhlICJk ZXRhY2hlZCIgY2FzZSBhbmQgZ3JhY2VmdWxseSBoYW5kbGUgbnVsbCBwb2ludGVycy48L3A+CiAu Li4uLi58Li4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLnwu Li4uLi4uLi4uCiAgICAgICB8ICAgICAgICBcLyAgUmVwbGFjZWQgYWZ0ZXIgbmF2aWdhdGlvbiAg XC8gICAgICAgIHwKICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfAotICAgICAgfCA8LS0gTnVsbCBhZnRlciBuYXZpZ2F0aW9uICAgICAgICAg ICAgICAgICAgICAgICB8CisgICAgICB8IDwtLSBQdHIgdG8gRnJhbWUgaXMgbnVsbCBhZnRlciBu YXZpZ2F0aW9uWzFdICAgIHwKICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfAogKy0tLS0tKy0tLS0tKyAgICAgICAgICstLS0tLS0tLS0tLS0t KyAgICAgICAgICAgICAgICAgICB8CiB8IERPTVdpbmRvdyB8PC0taW1wbC0tKyBKU0RPTVdpbmRv dyB8PC0tLS0tLXdpbmRvdy0tLS0tLSsKQEAgLTYxLDYgKzYxLDggQEAgdGhlICJkZXRhY2hlZCIg Y2FzZSBhbmQgZ3JhY2VmdWxseSBoYW5kbGUgbnVsbCBwb2ludGVycy48L3A+CiAgICstLS0tLS0t KyAgICAgICAgICAgKy0tLS0tLS0tKwogPC9wcmU+CiAKKzxwPlsxXSBBZnRlciBuYXZpZ2F0aW5n IHRvIGEgbmV3IHBhZ2UsIHRoZSBvbGQgRE9NV2luZG93IHBvaW50cyB0byBhIG51bGwgRnJhbWUs IGFuZCB0aGUgRnJhbWUgcG9pbnRzIHRvIGEgbmV3IERPTVdpbmRvdy4KKwogPHA+SWYgeW91IGhh dmUgYW55IGNvbW1lbnRzIG9uIHRoZSBhYm92ZSBvciBvdGhlciBpZGVhcyBhYm91dCBpbXByb3Zp bmcgdGhlIGNsYXJpdHksCiBzY29wZSwgb3IgcHJlc2VudGF0aW9uLCBwbGVhc2Ugc2VuZCBtYWls IHRvIHRoZSA8YSBocmVmPSIvY29udGFjdC5odG1sIj5XZWJLaXQgbWFpbGluZyBsaXN0PC9hPi48 L3A+CiAK