28228 2009-08-12 14:12:29 -0700 Add WebkitDOMObject header files 2014-01-31 19:02:27 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID P2 Normal --- 27428 16401 0 gour webkit-unassigned andersca sascha.dewald xan.lopez oldest_to_newest 139536 0 gour 2009-08-12 14:12:29 -0700 Adds header files for WebkitDOMObject.cpp https://bugs.webkit.org/show_bug.cgi?id=27428 Is part of gobject. 139539 1 34688 gour 2009-08-12 14:14:28 -0700 Created attachment 34688 uploadded 139541 2 34688 gour 2009-08-12 14:17:05 -0700 Comment on attachment 34688 uploadded I am cancelling the review because it has the same problem as #27428. 139601 3 mrowe 2009-08-12 15:30:23 -0700 Gour, rather than continuing along with the same problematic approach that Luke took can you please do as requested and discuss a more productive approach with the maintainers of the GTK port. 139767 4 gour 2009-08-13 03:12:11 -0700 (In reply to comment #3) > Gour, rather than continuing along with the same problematic approach that Luke > took can you please do as requested and discuss a more productive approach with > the maintainers of the GTK port. OK. I'm just trying to take over from where Luke was blocked to contribute... 139769 5 gour 2009-08-13 03:18:15 -0700 (In reply to comment #4) > (In reply to comment #3) > > Gour, rather than continuing along with the same problematic approach that Luke > > took can you please do as requested and discuss a more productive approach with > > the maintainers of the GTK port. OK. What should i do? I am not as experienced as lkcl but i am willing to learn, please do advise me what I should do, and where should i contact the gtk developers? 139783 6 xan.lopez 2009-08-13 03:52:26 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Gour, rather than continuing along with the same problematic approach that Luke > > > took can you please do as requested and discuss a more productive approach with > > > the maintainers of the GTK port. > > OK. What should i do? > > I am not as experienced as lkcl but i am willing to learn, please do advise me > what I should do, and where should i contact the gtk developers? First read https://bugs.webkit.org/show_bug.cgi?id=16401. Yes, it's long, but hopefully when you are done you'll see how important is to avoid to keep falling into this abyss over and over again. After that, I (and I think I talk for all GTK maintainers here) still think that the way to go was already stated clearly in comment #194 (https://bugs.webkit.org/show_bug.cgi?id=16401#c194) in that bug: "I concur with Mark's review, this is not ready to be landed. I have gone through the CodeGenerator and picked out a bunch of issues that really stick out, but in general, I can't really review this as is. I believe the best way forward is for you to pick one file (say Node.idl) and get code generation working for it or a subset of it. The stripped down version of the code generator that can generate this one file will be a great jumping off point. I know this seems like a step backwards, but the current state of the patch is really not reviewable as is due to a lack of clarity in the code." So if you want to get into this, I suggest you try to start doing something like that, and see where we get from there. 171100 7 sascha.dewald 2009-12-12 08:00:28 -0800 hello, my english is not the best... so i didn't know whats wrong with this patch? how can i help, to bring bug #16401 forward? greetings 974556 8 andersca 2014-01-31 19:02:27 -0800 This doesn't need to be open. 34688 2009-08-12 14:14:28 -0700 2010-06-10 19:49:08 -0700 uploadded patch.28228.txt text/plain 4581 gour SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiA0Njg5MCkKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDAgKzEsMTAgQEAKKzIwMDktMDgtMTIgIEx1a2UgS2VubmV0aCBDYXNzb24g TGVpZ2h0b24gIDxsa2NsQGxrY2wubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yODIyOAorCisgICAgICAgICogd2Via2l0L1dlYmtpdERPTU9iamVjdC5oOiBBZGRlZC4KKyAg ICAgICAgKiB3ZWJraXQvV2Via2l0RE9NT2JqZWN0UHJpdmF0ZS5oOiBBZGRlZC4KKworCkluZGV4 OiBXZWJLaXQvZ3RrL3dlYmtpdC9XZWJraXRET01PYmplY3QuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvZ3RrL3dlYmtpdC9XZWJraXRET01PYmplY3QuaAkocmV2aXNpb24gMCkKKysrIFdlYktpdC9n dGsvd2Via2l0L1dlYmtpdERPTU9iamVjdC5oCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDYwIEBA CisvKgorICogQ29weXJpZ2h0IChDKSAyMDA4LCAyMDA5IEx1a2UgS2VubmV0aCBDYXNzb24gTGVp Z2h0b24gPGxrY2xAbGtjbC5uZXQ+CisgKiBDb3B5cmlnaHQgKEMpIDIwMDggTWFydGluIFNvdG8g PHNvdG9AZnJlZWRlc2t0b3Aub3JnPgorICogQ29weXJpZ2h0IChDKSAyMDA4IEFscCBUb2tlciA8 YWxwQGF0b2tlci5jb20+CisgKiBDb3B5cmlnaHQgKEMpIDIwMDggQXBwbGUgSW5jLgorICoKKyAq IFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBh bmQvb3IKKyAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdl bmVyYWwgUHVibGljCisgKiBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2Fy ZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0 IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMg ZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAqIGJ1dCBX SVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9m CisgKiBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0Uu ICBTZWUgdGhlIEdOVQorICogTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3Jl IGRldGFpbHMuCisgKgorICogWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUg R05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorICogYWxvbmcgd2l0aCB0aGlzIGxp YnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwgd3JpdGUgdG8KKyAqIHRo ZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlm dGggRmxvb3IsCisgKiBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KKyAqLworCisKKyNpZm5k ZWYgV2Via2l0RE9NT2JqZWN0X2gKKyNkZWZpbmUgV2Via2l0RE9NT2JqZWN0X2gKKworI2luY2x1 ZGUgPGdsaWItb2JqZWN0Lmg+CisjaW5jbHVkZSA8d2Via2l0L3dlYmtpdGRlZmluZXMuaD4KKwor R19CRUdJTl9ERUNMUworCit0eXBlZGVmIHN0cnVjdCBfV2Via2l0RE9NT2JqZWN0IFdlYmtpdERP TU9iamVjdDsKK3R5cGVkZWYgc3RydWN0IF9XZWJraXRET01PYmplY3RDbGFzcyBXZWJraXRET01P YmplY3RDbGFzczsKKworI2RlZmluZSBXRUJLSVRfVFlQRV9ET01fT0JKRUNUICAgICAgICAgICAg KHdlYmtpdF9kb21fb2JqZWN0X2dldF90eXBlKCkpCisjZGVmaW5lIFdFQktJVF9ET01fT0JKRUNU KG9iaikgICAgICAgICAgICAoR19UWVBFX0NIRUNLX0lOU1RBTkNFX0NBU1QoKG9iaiksIFdFQktJ VF9UWVBFX0RPTV9PQkpFQ1QsIFdlYmtpdERPTU9iamVjdCkpCisjZGVmaW5lIFdFQktJVF9ET01f T0JKRUNUX0NMQVNTKGtsYXNzKSAgICAoR19UWVBFX0NIRUNLX0NMQVNTX0NBU1QoKGtsYXNzKSwg IFdFQktJVF9UWVBFX0RPTV9PQkpFQ1QsIFdlYmtpdERPTU9iamVjdENsYXNzKSkKKyNkZWZpbmUg V0VCS0lUX0lTX0RPTV9PQkpFQ1Qob2JqKSAgICAgICAgIChHX1RZUEVfQ0hFQ0tfSU5TVEFOQ0Vf VFlQRSgob2JqKSwgV0VCS0lUX1RZUEVfRE9NX09CSkVDVCkpCisjZGVmaW5lIFdFQktJVF9JU19E T01fT0JKRUNUX0NMQVNTKGtsYXNzKSAoR19UWVBFX0NIRUNLX0NMQVNTX1RZUEUoKGtsYXNzKSwg IFdFQktJVF9UWVBFX0RPTV9PQkpFQ1QpKQorI2RlZmluZSBXRUJLSVRfRE9NX09CSkVDVF9HRVRf Q0xBU1Mob2JqKSAgKEdfVFlQRV9JTlNUQU5DRV9HRVRfQ0xBU1MoKG9iaiksICBXRUJLSVRfVFlQ RV9ET01fT0JKRUNULCBXZWJraXRET01PYmplY3RDbGFzcykpCisKK3R5cGVkZWYgc3RydWN0IF9X ZWJraXRET01PYmplY3RQcml2YXRlIFdlYmtpdERPTU9iamVjdFByaXZhdGU7CisKK3N0cnVjdCBf V2Via2l0RE9NT2JqZWN0IHsKKyAgICBHT2JqZWN0IHBhcmVudF9pbnN0YW5jZTsKKworICAgIFdl YmtpdERPTU9iamVjdFByaXZhdGUgKnByaXY7Cit9OworCitzdHJ1Y3QgX1dlYmtpdERPTU9iamVj dENsYXNzIHsKKyAgICBHT2JqZWN0Q2xhc3MgcGFyZW50X2NsYXNzOworfTsKKworV0VCS0lUX0FQ SSBHVHlwZQord2Via2l0X2RvbV9vYmplY3RfZ2V0X3R5cGUgKHZvaWQpOworCitHX0VORF9ERUNM UworCisjZW5kaWYgLyogV2Via2l0RE9NT2JqZWN0X2ggKi8KKwpJbmRleDogV2ViS2l0L2d0ay93 ZWJraXQvV2Via2l0RE9NT2JqZWN0UHJpdmF0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsv d2Via2l0L1dlYmtpdERPTU9iamVjdFByaXZhdGUuaAkocmV2aXNpb24gMCkKKysrIFdlYktpdC9n dGsvd2Via2l0L1dlYmtpdERPTU9iamVjdFByaXZhdGUuaAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwzNiBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAwOCwgMjAwOSBMdWtlIEtlbm5ldGggQ2Fz c29uIExlaWdodG9uIDxsa2NsQGxrY2wubmV0PgorICogQ29weXJpZ2h0IChDKSAyMDA4IE1hcnRp biBTb3RvIDxzb3RvQGZyZWVkZXNrdG9wLm9yZz4KKyAqIENvcHlyaWdodCAoQykgMjAwOCBBbHAg VG9rZXIgPGFscEBhdG9rZXIuY29tPgorICogQ29weXJpZ2h0IChDKSAyMDA4IEFwcGxlIEluYy4g IEFsbCBSaWdodHMgUmVzZXJ2ZWQuCisgKgorICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdh cmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgorICogbW9kaWZ5IGl0IHVuZGVyIHRo ZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKKyAqIExpY2Vuc2UgYXMg cHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgorICogdmVy c2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJz aW9uLgorICoKKyAqIFRoaXMgbGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0 IGl0IHdpbGwgYmUgdXNlZnVsLAorICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0 IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRO RVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisgKiBMaWJyYXJ5IEdl bmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKyAqCisgKiBZb3Ugc2hvdWxk IGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBM aWNlbnNlCisgKiBhbG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgc2VlIHRoZSBmaWxlIENPUFlJTkcu TElCLiAgSWYgbm90LCB3cml0ZSB0bworICogdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwg SW5jLiwgNTEgRnJhbmtsaW4gU3RyZWV0LCBGaWZ0aCBGbG9vciwKKyAqIEJvc3RvbiwgTUEgMDIx MTAtMTMwMSwgVVNBLgorICovCisKKyNpZm5kZWYgV2Via2l0RE9NT2JqZWN0UHJpdmF0ZV9oCisj ZGVmaW5lIFdlYmtpdERPTU9iamVjdFByaXZhdGVfaAorCisjaW5jbHVkZSAid2Via2l0L1dlYmtp dERPTU9iamVjdC5oIgorI2luY2x1ZGUgImdsaWItb2JqZWN0LmgiCisKK3N0cnVjdCBfV2Via2l0 RE9NT2JqZWN0UHJpdmF0ZSB7CisgICAgZ3BvaW50ZXIgY29yZU9iamVjdDsKK307CisKKyNkZWZp bmUgV0VCS0lUX0RPTV9PQkpFQ1RfR0VUX1BSSVZBVEUob2JqKSAoR19UWVBFX0lOU1RBTkNFX0dF VF9QUklWQVRFKChvYmopLCBXRUJLSVRfVFlQRV9ET01fT0JKRUNULCBXZWJraXRET01PYmplY3RQ cml2YXRlKSkKKworI2VuZGlmCisK