28225 2009-08-12 13:07:38 -0700 check-webkit-style uses python from /usr/bin instead of the PATH 2009-09-02 01:01:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 carol webkit-unassigned ddkilzer eric laszlo.gombos oldest_to_newest 139490 0 carol 2009-08-12 13:07:38 -0700 check-webkit-style starts with '#!/usr/bin/python'. This prevents usage of the script on computers where /usr/bin/python is absent or is too old even if an appropriate python version exists in the PATH. 139501 1 34686 carol 2009-08-12 13:34:50 -0700 Created attachment 34686 Patch: uses python from $PATH This solution was suggested by kollivier on the #webkit IRC channel. It worked for me and it may be useful to others. 139524 2 mrowe 2009-08-12 13:58:21 -0700 None of our existing scripts in WebKitTools/Scripts use this approach. If this is a problem I don't see why we would only fix a single script. 139525 3 34686 mrowe 2009-08-12 13:58:52 -0700 Comment on attachment 34686 Patch: uses python from $PATH Clearing review flag for reason mentioned. 139538 4 carol 2009-08-12 14:13:48 -0700 (In reply to comment #2) > None of our existing scripts in WebKitTools/Scripts use this approach. If this > is a problem I don't see why we would only fix a single script. Mark, You are right that this would fix only one script and if otherwise the fix is acceptable I am willing to change all scripts in the directory to use the same approach. On the other hand, there is one other script (roll-over-ChangeLogs) which uses the same approach, so it can be argued that since it is ok for that script it should be ok for this script too. I believe that the /usr/bin/env approach does not make sense for standard shells (such as /usr/bin/sh), but may be useful for perl, python and ruby scripts where many incompatible versions may exist in the system. 142410 5 laszlo.gombos 2009-08-24 14:10:46 -0700 (In reply to comment #4) > (In reply to comment #2) > > None of our existing scripts in WebKitTools/Scripts use this approach. If this > > is a problem I don't see why we would only fix a single script. > > Mark, > You are right that this would fix only one script and if otherwise the fix is > acceptable I am willing to change all scripts in the directory to use the same > approach. > > On the other hand, there is one other script (roll-over-ChangeLogs) which uses > the same approach, so it can be argued that since it is ok for that script it > should be ok for this script too. > > I believe that the /usr/bin/env approach does not make sense for standard > shells (such as /usr/bin/sh), but may be useful for perl, python and ruby > scripts where many incompatible versions may exist in the system. Perhaps -for now - we should just do this for "top level" python scripts. I did a quick search and I only found 3 scripts: check-webkit-style, bugzilla-tool, run-webkit-unittests 142627 6 34686 eric 2009-08-25 10:35:25 -0700 Comment on attachment 34686 Patch: uses python from $PATH Marking r- per the discussion above. Either we should do this for all scripts or none. 143709 7 38831 carol 2009-08-31 13:28:23 -0700 Created attachment 38831 This is the second patch attempt for this problem I have applied the fix to all python scripts per lgombos's comments. I was reluctant to fix all scripts in the directory as I am not familiar with many of them and I think that it is preferable that (as the case of style errors in C/C++ code) they are fixed as they cause problems. I am not quite an "if its not broken don't fix it" kind of guy, but I am reluctant to take poorly understood (at least by me) risks when the benefit is small. 143948 8 38831 eric 2009-09-01 11:09:39 -0700 Comment on attachment 38831 This is the second patch attempt for this problem Rejecting patch 38831 from commit-queue. This patch will require manual commit. Failed to run "/Users/eseidel/Projects/WebKitSVN/WebKitTools/Scripts/update-webkit" exit_code: 1 cwd: None 144043 9 38831 eric 2009-09-01 16:38:14 -0700 Comment on attachment 38831 This is the second patch attempt for this problem svn: Failed to add file 'WebCore/bindings/v8/custom/V8WebSocketCustom.cpp': object of the same name already exists This was a victim of bug 28603. :( 144073 10 38831 eric 2009-09-01 17:42:02 -0700 Comment on attachment 38831 This is the second patch attempt for this problem Rejecting patch 38831 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 144134 11 38831 eric 2009-09-02 00:45:03 -0700 Comment on attachment 38831 This is the second patch attempt for this problem Flakey test. :( compositing/color-matching/image-color-matching.html -> crashed 144136 12 eric 2009-09-02 00:49:10 -0700 I believe that's just another instance of bug 28845 biting us. :( 144140 13 38831 eric 2009-09-02 01:01:30 -0700 Comment on attachment 38831 This is the second patch attempt for this problem Clearing flags on attachment: 38831 Committed r47955: <http://trac.webkit.org/changeset/47955> 144141 14 eric 2009-09-02 01:01:34 -0700 All reviewed patches have been landed. Closing bug. 34686 2009-08-12 13:34:50 -0700 2009-08-31 13:28:23 -0700 Patch: uses python from $PATH patchFor28225 text/plain 999 carol SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ3MTQyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDgtMTIgIFN6YWJvIENhcm9sICA8Y2Fy b2wuc3phYm9Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSB1c2VzIHB5dGhvbiBmcm9tIC91c3IvYmlu IGluc3RlYWQgb2YgdGhlIFBBVEgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI4MjI1CisKKyAgICAgICAgKiBTY3JpcHRzL2NoZWNrLXdlYmtpdC1zdHls ZToKKworICAgICAgICAgQ2hhbmdlZCB0byB1c2UgcHl0aG9uIGZyb20gdGhlIHBhdGggaW5zdGVh ZCBvZiAvdXNyL2Jpbi4KKwogMjAwOS0wOC0xMiAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhl b2xsaXZpZXJzLmNvbT4KIAogICAgICAgICB3eCB3YWYgYnVpbGQgZml4LCBhZGQgbmV3IGRpcmVj dG9yaWVzIHRvIHRoZSBidWlsZC4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvY2hlY2std2Vi a2l0LXN0eWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvY2hlY2std2Via2l0 LXN0eWxlCShyZXZpc2lvbiA0NzEzMSkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvY2hlY2std2Vi a2l0LXN0eWxlCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotIyEvdXNyL2Jpbi9weXRo b24KKyMhL3Vzci9iaW4vZW52IHB5dGhvbgogIwogIyBDb3B5cmlnaHQgKEMpIDIwMDkgR29vZ2xl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMK 38831 2009-08-31 13:28:23 -0700 2009-09-02 01:01:30 -0700 This is the second patch attempt for this problem patchFor28225.txt text/plain 2572 carol SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ3OTAxKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDktMDgtMzEgIFN6YWJvIENhcm9sICA8Y2Fy b2wuc3phYm9Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSB1c2VzIHB5dGhvbiBmcm9tIC91c3IvYmlu IGluc3RlYWQgb2YgdGhlIFBBVEgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI4MjI1CisKKyAgICAgICAgKiBTY3JpcHRzL2J1Z3ppbGxhLXRvb2w6Cisg ICAgICAgICogU2NyaXB0cy9jaGVjay13ZWJraXQtc3R5bGU6CisgICAgICAgICogU2NyaXB0cy9y dW4td2Via2l0LXVuaXR0ZXN0czoKKyAgICAgICAgKiBTY3JpcHRzL3VwZGF0ZS1zb3VyY2VzLWxp c3QucHk6CisgICAgICAgICAgQ2hhbmdlZCB0aGUgZmlyc3QgbGluZSBmcm9tCisgICAgICAgICAg IyEvdXNyL2Jpbi9weXRob24KKyAgICAgICAgICB0bworICAgICAgICAgICMhL3Vzci9iaW4vZW52 IHB5dGhvbgorICAgICAgICAgIHdoaWNoIGNhdXNlcyBweXRob24gdG8gYmUgaW52b2tlZCBmcm9t IHRoZSBwYXRoIGxvY2F0aW9uIHJldHVybmVkCisgICAgICAgICAgYnkgIndoaWNoIHB5dGhvbiIg d2hlbiBhbnkgb2YgdGhlc2Ugc2NyaXB0cyBhcmUgbGF1bmNoZWQuCisgICAgICAgICAgdGhlc2Ug YXJlIGN1cnJlbnRseSBhbGwgdGhlIHB5dGhvbiBzY3JpcHRzIGluIFdlYktpdFRvb2xzL1Njcmlw dHMuCisKIDIwMDktMDgtMzEgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAg ICAgIEZhbGwgYmFjayB0byBhIFJlbGVhc2UgdmVyc2lvbiBvZiBTYWZhcmkgaWYgYSBEZWJ1ZyBv bmUgZG9lc24ndCBleGlzdApJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAkocmV2aXNp b24gNDc4OTYpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wJKHdvcmtpbmcg Y29weSkKQEAgLTEsNCArMSw0IEBACi0jIS91c3IvYmluL3B5dGhvbgorIyEvdXNyL2Jpbi9lbnYg cHl0aG9uCiAjIENvcHlyaWdodCAoYykgMjAwOSwgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KICMgQ29weXJpZ2h0IChjKSAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KICMKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvY2hlY2std2Via2l0LXN0eWxlCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvY2hlY2std2Via2l0LXN0eWxlCShyZXZpc2lv biA0Nzg5NikKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvY2hlY2std2Via2l0LXN0eWxlCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotIyEvdXNyL2Jpbi9weXRob24KKyMhL3Vzci9iaW4v ZW52IHB5dGhvbgogIwogIyBDb3B5cmlnaHQgKEMpIDIwMDkgR29vZ2xlIEluYy4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KICMKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC11bml0 dGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXVuaXR0 ZXN0cwkocmV2aXNpb24gNDc4OTYpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQt dW5pdHRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotIyEvdXNyL2Jpbi9weXRo b24KKyMhL3Vzci9iaW4vZW52IHB5dGhvbgogIyBDb3B5cmlnaHQgKGMpIDIwMDkgR29vZ2xlIElu Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CkluZGV4OiBXZWJLaXRUb29s cy9TY3JpcHRzL3VwZGF0ZS1zb3VyY2VzLWxpc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9v bHMvU2NyaXB0cy91cGRhdGUtc291cmNlcy1saXN0LnB5CShyZXZpc2lvbiA0Nzg5NikKKysrIFdl YktpdFRvb2xzL1NjcmlwdHMvdXBkYXRlLXNvdXJjZXMtbGlzdC5weQkod29ya2luZyBjb3B5KQpA QCAtMSw0ICsxLDQgQEAKLSMhL3Vzci9iaW4vcHl0aG9uCisjIS91c3IvYmluL2VudiBweXRob24K IAogIyBDb3B5cmlnaHQgKEMpIDIwMDcgS2V2aW4gT2xsaXZpZXIgIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCiAjCg==