28216 2009-08-12 03:27:06 -0700 [CAIRO] getImageData fails on a given rect bigger than the image rect 2009-08-13 10:52:37 -0700 1 1 1 Unclassified WebKit WebKitGTK 525.x (Safari 3.1) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 krit webkit-unassigned eric oldest_to_newest 139288 0 34650 krit 2009-08-12 03:27:06 -0700 Created attachment 34650 Cairo fix of getImageData [CAIRO] getImageData fails on a given rect bigger than the image rect. I found this bug during my work on SVG feGaussianBlur. Currently only canvas could test it, but we don't allow the it there to make a bigger rect then the image rect. The problem is, that the destination image and source image were mixed up on creating the imageData. This patch just follows to the behavior of the other ports. 139381 1 34650 eric 2009-08-12 10:18:19 -0700 Comment on attachment 34650 Cairo fix of getImageData Test case? Or at least an explanation of why one is impossible. 139431 2 34677 krit 2009-08-12 11:08:01 -0700 Created attachment 34677 Cairo fix of getImageData a better Changelog... 139886 3 34677 eric 2009-08-13 09:53:06 -0700 Comment on attachment 34677 Cairo fix of getImageData LGTM. Not marking cq+ since you're a committer. You can mark it yourself if you'd like the queue to land this for you. 139910 4 eric 2009-08-13 10:17:27 -0700 Exception: Unknown committer: krit@webkit.org Are you not a committer? Or do we just not have you in: WebKitTools/Scripts/modules/committers.py yet? If not, feel free to add yourself to the committer list. No review needed. 139919 5 krit 2009-08-13 10:39:49 -0700 (In reply to comment #4) > Exception: Unknown committer: krit@webkit.org > > Are you not a committer? Or do we just not have you in: > WebKitTools/Scripts/modules/committers.py yet? > > If not, feel free to add yourself to the committer list. No review needed. Added myself to the list. 139923 6 34677 eric 2009-08-13 10:52:33 -0700 Comment on attachment 34677 Cairo fix of getImageData Clearing flags on attachment: 34677 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/cairo/ImageBufferCairo.cpp Committed r47211 M WebCore/ChangeLog M WebCore/platform/graphics/cairo/ImageBufferCairo.cpp r47211 = 43323f18d890228b2275a1ae4d4f9d211d2c001d (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47211 139925 7 eric 2009-08-13 10:52:37 -0700 All reviewed patches have been landed. Closing bug. 34650 2009-08-12 03:27:06 -0700 2009-08-12 11:08:01 -0700 Cairo fix of getImageData cairo-getimagedata-fix.patch text/plain 1317 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzEwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDgtMTIgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ0FJ Uk9dIGdldEltYWdlRGF0YSBmYWlscyBvbiBhIGdpdmVuIHJlY3QgYmlnZ2VyIHRoYW4gdGhlIGlt YWdlIHJlY3QKKworICAgICAgICBUaGUgZGVzdGluYXRpb24gaW1hZ2UgYW5kIHRoZSBzb3VyY2Ug aW1hZ2Ugd2FzIG1peGVkIHVwIG9uIGNyZWF0aW5nIHRoZQorICAgICAgICBpbWFnZURhdGEuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmdldEltYWdlRGF0YSk6CisKIDIwMDktMDgtMTIgIFhhbiBMb3Bl eiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEphbiBBbG9uem8u CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VC dWZmZXJDYWlyby5jcHAJKHJldmlzaW9uIDQ3MDk5KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ4LDcg KzE0OCw3IEBAIFBhc3NSZWZQdHI8SW1hZ2VEYXRhPiBnZXRJbWFnZURhdGEoY29uc3QKICAgICB1 bnNpZ25lZCBjaGFyKiBkYXRhRHN0ID0gcmVzdWx0LT5kYXRhKCktPmRhdGEoKS0+ZGF0YSgpOwog CiAgICAgaWYgKHJlY3QueCgpIDwgMCB8fCByZWN0LnkoKSA8IDAgfHwgKHJlY3QueCgpICsgcmVj dC53aWR0aCgpKSA+IHNpemUud2lkdGgoKSB8fCAocmVjdC55KCkgKyByZWN0LmhlaWdodCgpKSA+ IHNpemUuaGVpZ2h0KCkpCi0gICAgICAgIG1lbXNldChkYXRhU3JjLCAwLCByZXN1bHQtPmRhdGEo KS0+bGVuZ3RoKCkpOworICAgICAgICBtZW1zZXQoZGF0YURzdCwgMCwgcmVzdWx0LT5kYXRhKCkt Pmxlbmd0aCgpKTsKIAogICAgIGludCBvcmlnaW54ID0gcmVjdC54KCk7CiAgICAgaW50IGRlc3R4 ID0gMDsK 34677 2009-08-12 11:08:01 -0700 2009-08-13 10:52:32 -0700 Cairo fix of getImageData cairo-getimagedata-fix.patch text/plain 1620 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzEyMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMTIgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ0FJ Uk9dIGdldEltYWdlRGF0YSBmYWlscyBvbiBhIGdpdmVuIHJlY3QgYmlnZ2VyIHRoYW4gdGhlIGlt YWdlIHJlY3QKKworICAgICAgICBUaGUgZGVzdGluYXRpb24gaW1hZ2UgYW5kIHRoZSBzb3VyY2Ug aW1hZ2Ugd2FzIG1peGVkIHVwIG9uIGNyZWF0aW5nIHRoZQorICAgICAgICBpbWFnZURhdGEuCisK KyAgICAgICAgVGhpcyBpcyBqdXN0IGEgY2xlYW4gdXAgYW5kIGRvZXNuJ3QgYWZmZWN0IHRoZSBj dXJyZW50IGJlaGF2aW9yLiBJdCdzIG5vdAorICAgICAgICBwb3NzaWJsZSB0byB0ZXN0IHRoaXMg ZmFpbHVyZSBpbiBhIExheW91dFRlc3QuIE9ubHkgY2FudmFzIHVzZXMgZ2V0SW1hZ2VEYXRhCisg ICAgICAgIGF0IHRoZSBtb21lbnQgYW5kIHJldHVybnMgYmVmb3JlIGNhbGxpbmcgZ2V0SW1hZ2VE YXRhLCBpZiB0aGUgaW1hZ2UgcmVjdCBkb2VzCisgICAgICAgIG5vdCBjb250YWluIHRoZSByZXF1 ZXN0ZWQgcmVjdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVm ZmVyQ2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0SW1hZ2VEYXRhKToKKwogMjAwOS0w OC0wOCAgWW9uZyBMaSAgPHlvbmcubGlAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFkYW0gVHJlYXQuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJv L0ltYWdlQnVmZmVyQ2Fpcm8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHAJKHJldmlzaW9uIDQ3MTIyKQorKysgV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTQ4LDcgKzE0OCw3IEBAIFBhc3NSZWZQdHI8SW1hZ2VEYXRhPiBnZXRJbWFn ZURhdGEoY29uc3QKICAgICB1bnNpZ25lZCBjaGFyKiBkYXRhRHN0ID0gcmVzdWx0LT5kYXRhKCkt PmRhdGEoKS0+ZGF0YSgpOwogCiAgICAgaWYgKHJlY3QueCgpIDwgMCB8fCByZWN0LnkoKSA8IDAg fHwgKHJlY3QueCgpICsgcmVjdC53aWR0aCgpKSA+IHNpemUud2lkdGgoKSB8fCAocmVjdC55KCkg KyByZWN0LmhlaWdodCgpKSA+IHNpemUuaGVpZ2h0KCkpCi0gICAgICAgIG1lbXNldChkYXRhU3Jj LCAwLCByZXN1bHQtPmRhdGEoKS0+bGVuZ3RoKCkpOworICAgICAgICBtZW1zZXQoZGF0YURzdCwg MCwgcmVzdWx0LT5kYXRhKCktPmxlbmd0aCgpKTsKIAogICAgIGludCBvcmlnaW54ID0gcmVjdC54 KCk7CiAgICAgaW50IGRlc3R4ID0gMDsK