28215 2009-08-12 02:38:10 -0700 [v8] Fix atomic string externalization crash 2009-08-13 13:18:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 christian.plesner.hansen christian.plesner.hansen dglazkov eric levin oldest_to_newest 139286 0 christian.plesner.hansen 2009-08-12 02:38:10 -0700 Atomic string externalization assumes that all non-empty strings can be externalized which is untrue on 64-bit. This change fixed that. 139287 1 34649 christian.plesner.hansen 2009-08-12 02:39:55 -0700 Created attachment 34649 "Initial" 139293 2 34652 christian.plesner.hansen 2009-08-12 04:15:00 -0700 Created attachment 34652 Tabs-fix 139334 3 34652 dglazkov 2009-08-12 08:48:13 -0700 Comment on attachment 34652 Tabs-fix r=me 139337 4 dglazkov 2009-08-12 08:54:08 -0700 Landed as http://trac.webkit.org/changeset/47106. 139582 5 levin 2009-08-12 15:11:42 -0700 Had to roll this out http://trac.webkit.org/changeset/47153 due to v8 being rolled back upstream. 139583 6 34652 levin 2009-08-12 15:12:47 -0700 Comment on attachment 34652 Tabs-fix This commit needs to wait for an appropriate version of v8 to be available downstream. 139945 7 34652 levin 2009-08-13 11:26:56 -0700 Comment on attachment 34652 Tabs-fix The v8 build with the api has landed upstream so this can be committed now. 139956 8 34652 eric 2009-08-13 11:52:19 -0700 Comment on attachment 34652 Tabs-fix Rejecting patch 34652 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None 139958 9 eric 2009-08-13 11:55:04 -0700 The following files contain tab characters: trunk/WebCore/ChangeLog Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. Will need to be fixed manually. We need to make svn-create-patch warn about this type of error to catch these things earlier. 139964 10 christian.plesner.hansen 2009-08-13 12:18:50 -0700 > The following files contain tab characters: > > trunk/WebCore/ChangeLog I don't see any tabs in the updated patch. 139991 11 eric 2009-08-13 13:15:35 -0700 vim shows a ^I char here: + [v8] Fix atomic string externalization crash.^I$ 139992 12 eric 2009-08-13 13:16:25 -0700 I'll land this manually. 139995 13 34652 eric 2009-08-13 13:17:10 -0700 Comment on attachment 34652 Tabs-fix Rejecting patch 34652 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None 139996 14 eric 2009-08-13 13:18:10 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/V8Binding.cpp Committed r47227 M WebCore/ChangeLog M WebCore/bindings/v8/V8Binding.cpp r47227 = a210e42b217c8c1eff26cbd44431379c0e2fde0b (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47227 34649 2009-08-12 02:39:55 -0700 2009-08-12 04:14:53 -0700 "Initial" bug-28215-20090812113953.patch text/plain 1974 christian.plesner.hansen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzA5NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMTIgIENocmlzdGlhbiBQbGVzbmVyIEhhbnNlbiAgPGNo cmlzdGlhbi5wbGVzbmVyLmhhbnNlbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW3Y4XSBGaXggYXRvbWljIHN0cmluZyBleHRlcm5h bGl6YXRpb24gY3Jhc2guCQorCUF0b21pYyBzdHJpbmcgZXh0ZXJuYWxpemF0aW9uIGFzc3VtZXMg dGhhdCBhbGwgbm9uLWVtcHR5IHN0cmluZ3MKKwljYW4gYmUgZXh0ZXJuYWxpemVkIHdoaWNoIGlz IHVudHJ1ZSBvbiA2NC1iaXQuICBUaGlzIGNoYW5nZSBmaXhlZAorCXRoYXQuCisKKwlodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgyMTUKKworCVRoaXMgYnVnIGNhdXNl cyBsb2FkcyBvZiB0ZXN0IGNyYXNoZXMsIG5vIG5lZWQgdG8gYWRkIG5ldyB0ZXN0cworCXNwZWNp ZmljYWxseSBmb3IgdGhpcy4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjp2OFN0cmluZ1RvQXRvbWljV2ViQ29yZVN0cmluZyk6CisKIDIw MDktMDgtMTIgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4QmluZGluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJp bmRpbmcuY3BwCShyZXZpc2lvbiA0NzA5MykKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5k aW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU0LDE0ICsxNTQsMTIgQEAgQXRvbWljU3RyaW5n IHY4U3RyaW5nVG9BdG9taWNXZWJDb3JlU3RyaQogewogICAgIFdlYkNvcmVTdHJpbmdSZXNvdXJj ZSogc3RyaW5nUmVzb3VyY2UgPSBXZWJDb3JlU3RyaW5nUmVzb3VyY2U6OnRvU3RyaW5nUmVzb3Vy Y2UodjhTdHJpbmcpOwogICAgIGlmICghc3RyaW5nUmVzb3VyY2UpIHsKKyAgICAgICAgaWYgKCF2 OFN0cmluZy0+Q2FuTWFrZUV4dGVybmFsKCkpCisgICAgICAgICAgICByZXR1cm4gdjhTdHJpbmdU b1dlYkNvcmVTdHJpbmcodjhTdHJpbmcsIERvTm90RXh0ZXJuYWxpemUsIEF0b21pY1N0cmluZ1R5 cGUpOwogICAgICAgICAvLyBJZiB0aGlzIHN0cmluZyBoYXNuJ3QgYmVlbiBleHRlcm5hbGl6ZWQs IHdlIGZvcmNlIGl0IG5vdy4KLSAgICAgICAgU3RyaW5nIHBsYWluID0gdjhTdHJpbmdUb1dlYkNv cmVTdHJpbmcodjhTdHJpbmcsIEV4dGVybmFsaXplLCBBdG9taWNTdHJpbmdUeXBlKTsKLSAgICAg ICAgLy8gSWYgdGhlIHN0cmluZyBpcyBlbXB0eSB0aGVyZSdzIG5vIHJvb20gdG8gY2FjaGUgYW4g YXRvbWljCi0gICAgICAgIC8vIHN0cmluZyBzbyB3ZSBiYWlsIG91dC4KLSAgICAgICAgaWYgKHBs YWluLmlzRW1wdHkoKSkKLSAgICAgICAgICAgIHJldHVybiBwbGFpbjsKKyAgICAgICAgdjhTdHJp bmdUb1dlYkNvcmVTdHJpbmcodjhTdHJpbmcsIEV4dGVybmFsaXplLCBBdG9taWNTdHJpbmdUeXBl KTsKICAgICAgICAgc3RyaW5nUmVzb3VyY2UgPSBXZWJDb3JlU3RyaW5nUmVzb3VyY2U6OnRvU3Ry aW5nUmVzb3VyY2UodjhTdHJpbmcpOwotICAgICAgICBBU1NFUlQoc3RyaW5nUmVzb3VyY2UgIT0g TlVMTCk7CisgICAgICAgIEFTU0VSVChzdHJpbmdSZXNvdXJjZSk7CiAgICAgfQogICAgIHJldHVy biBzdHJpbmdSZXNvdXJjZS0+YXRvbWljU3RyaW5nKCk7CiB9 34652 2009-08-12 04:15:00 -0700 2009-08-13 13:17:10 -0700 Tabs-fix bug-28215-20090812131458.patch text/plain 2001 christian.plesner.hansen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzEwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMTIgIENocmlzdGlhbiBQbGVzbmVyIEhhbnNlbiAgPGNo cmlzdGlhbi5wbGVzbmVyLmhhbnNlbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW3Y4XSBGaXggYXRvbWljIHN0cmluZyBleHRlcm5h bGl6YXRpb24gY3Jhc2guCQorICAgICAgICBBdG9taWMgc3RyaW5nIGV4dGVybmFsaXphdGlvbiBh c3N1bWVzIHRoYXQgYWxsIG5vbi1lbXB0eSBzdHJpbmdzCisgICAgICAgIGNhbiBiZSBleHRlcm5h bGl6ZWQgd2hpY2ggaXMgdW50cnVlIG9uIDY0LWJpdC4gIFRoaXMgY2hhbmdlIGZpeGVkCisgICAg ICAgIHRoYXQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTI4MjE1CisKKyAgICAgICAgVGhpcyBidWcgY2F1c2VzIGxvYWRzIG9mIHRlc3QgY3Jhc2hl cywgbm8gbmVlZCB0byBhZGQgbmV3IHRlc3RzCisgICAgICAgIHNwZWNpZmljYWxseSBmb3IgdGhp cy4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJD b3JlOjp2OFN0cmluZ1RvQXRvbWljV2ViQ29yZVN0cmluZyk6CisKIDIwMDktMDgtMTIgIFhhbiBM b3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEphbiBBbG9u em8uCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCShyZXZpc2lvbiA0NzEwMCkKKysr IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU0 LDE0ICsxNTQsMTIgQEAgQXRvbWljU3RyaW5nIHY4U3RyaW5nVG9BdG9taWNXZWJDb3JlU3RyaQog ewogICAgIFdlYkNvcmVTdHJpbmdSZXNvdXJjZSogc3RyaW5nUmVzb3VyY2UgPSBXZWJDb3JlU3Ry aW5nUmVzb3VyY2U6OnRvU3RyaW5nUmVzb3VyY2UodjhTdHJpbmcpOwogICAgIGlmICghc3RyaW5n UmVzb3VyY2UpIHsKKyAgICAgICAgaWYgKCF2OFN0cmluZy0+Q2FuTWFrZUV4dGVybmFsKCkpCisg ICAgICAgICAgICByZXR1cm4gdjhTdHJpbmdUb1dlYkNvcmVTdHJpbmcodjhTdHJpbmcsIERvTm90 RXh0ZXJuYWxpemUsIEF0b21pY1N0cmluZ1R5cGUpOwogICAgICAgICAvLyBJZiB0aGlzIHN0cmlu ZyBoYXNuJ3QgYmVlbiBleHRlcm5hbGl6ZWQsIHdlIGZvcmNlIGl0IG5vdy4KLSAgICAgICAgU3Ry aW5nIHBsYWluID0gdjhTdHJpbmdUb1dlYkNvcmVTdHJpbmcodjhTdHJpbmcsIEV4dGVybmFsaXpl LCBBdG9taWNTdHJpbmdUeXBlKTsKLSAgICAgICAgLy8gSWYgdGhlIHN0cmluZyBpcyBlbXB0eSB0 aGVyZSdzIG5vIHJvb20gdG8gY2FjaGUgYW4gYXRvbWljCi0gICAgICAgIC8vIHN0cmluZyBzbyB3 ZSBiYWlsIG91dC4KLSAgICAgICAgaWYgKHBsYWluLmlzRW1wdHkoKSkKLSAgICAgICAgICAgIHJl dHVybiBwbGFpbjsKKyAgICAgICAgdjhTdHJpbmdUb1dlYkNvcmVTdHJpbmcodjhTdHJpbmcsIEV4 dGVybmFsaXplLCBBdG9taWNTdHJpbmdUeXBlKTsKICAgICAgICAgc3RyaW5nUmVzb3VyY2UgPSBX ZWJDb3JlU3RyaW5nUmVzb3VyY2U6OnRvU3RyaW5nUmVzb3VyY2UodjhTdHJpbmcpOwotICAgICAg ICBBU1NFUlQoc3RyaW5nUmVzb3VyY2UgIT0gTlVMTCk7CisgICAgICAgIEFTU0VSVChzdHJpbmdS ZXNvdXJjZSk7CiAgICAgfQogICAgIHJldHVybiBzdHJpbmdSZXNvdXJjZS0+YXRvbWljU3RyaW5n KCk7CiB9