282137 2024-10-26 10:10:26 -0700 [Navigation] NavigationResult.finished resolves earlier than expected 2024-11-01 16:35:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=282475 InRadar P2 Normal --- 258384 1 pgriffis rbuis rbuis webkit-bug-importer oldest_to_newest 2070738 0 pgriffis 2024-10-26 10:10:26 -0700 An example of this is in the navigation-api/focus-reset/ tests, such as basic.html. It includes the JS file navigation-api/focus-reset/resources/helpers.mjs which has code like: const { committed, finished } = navigation.navigate("#foo"); await committed; assert_equals(document.activeElement, button, "Focus stays on the button during the transition"); await finished.catch(() => {}); assert_equals(document.activeElement, button, "Focus stays on the button after the transition"); The issue is that the navigation blocks all the way until the point where `finished` is fulfilled. The `committed` promise is resolved at the correct time, however the JS after it is not able to execute until after the navigation is complete (by which point `finished` has been resolved also). 2070886 1 rbuis 2024-10-28 05:12:08 -0700 I looked a bit into this, I think this is the same problem shown by some ordering-and-transition tests, in some cases the waitForAll algorithm returns too quickly. Basically the waitForAll functionality should act like a Promise, which is currently not the case. 2071624 2 rbuis 2024-10-30 09:55:56 -0700 Pull request: https://github.com/WebKit/WebKit/pull/35946 2071857 3 ews-feeder 2024-10-31 06:35:22 -0700 Committed 285951@main (144f09fb32d5): <https://commits.webkit.org/285951@main> Reviewed commits have been landed. Closing PR #35946 and removing active labels. 2071858 4 webkit-bug-importer 2024-10-31 06:36:14 -0700 <rdar://problem/138996263>