28211 2009-08-11 21:32:38 -0700 Can't click and drag the media controller thumb 2009-08-12 18:49:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser webkit-unassigned dimich eric.carlson eric hclam simon.fraser oldest_to_newest 139222 0 simon.fraser 2009-08-11 21:32:38 -0700 With TOT, the media slider doesn't move with the cursor when I mouse down and drag it over the controller. The media slider only updates it's position after I mouse up after I drag it. This is a regression on TOT since this doesn't happen on stock SL 10A342. This regression was caused by http://trac.webkit.org/changeset/46915 since it doesn't happen with previous checkin 46914. * STEPS TO REPRODUCE 1. Launch a nightly webkit build and go to http://www.mirageband.tv/Night%20and%20Day.mp3 2. Wait for entire file to load then pause it 3. Mouse down directly on the slider and drag the mouse to another section on the controller. Notice the slider doesn't move until you mouse up. 139223 1 simon.fraser 2009-08-11 21:33:14 -0700 <rdar://problem/7135838> 139282 2 34647 hclam 2009-08-12 02:29:08 -0700 Created attachment 34647 patch 139283 3 hclam 2009-08-12 02:33:15 -0700 The cause of the regression is that r46915 rejects non mouse actions and mouse actions not from left button. This logic caused trouble because it discards a lot of mouse move events during drag. 139325 4 34647 simon.fraser 2009-08-12 08:37:37 -0700 Comment on attachment 34647 patch Patch looks reasonable but you can make a testcase; in DumpRenderTree, there is an eventSender API that you can use to synthesize mouse events. I think it's important to add a testcase so that this doesn't regress again. 139397 5 hclam 2009-08-12 10:29:19 -0700 OK, I'll provide a test case with fix shortly. 139643 6 34703 hclam 2009-08-12 16:40:04 -0700 Created attachment 34703 patch + test 139666 7 simon.fraser 2009-08-12 17:06:41 -0700 Note that layout tests that use eventSender make assumptions about locations of buttons on the media controller that may not hold across platorms. 139667 8 eric.carlson 2009-08-12 17:09:33 -0700 https://bugs.webkit.org/show_bug.cgi?id=28220 will fix the problem Simon mentioned, but for now you may need to land platform specific test results. 139688 9 34703 eric 2009-08-12 18:00:48 -0700 Comment on attachment 34703 patch + test Clearing flags on attachment: 34703 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/media/controls-drag-timebar-expected.txt A LayoutTests/media/controls-drag-timebar.html M WebCore/ChangeLog M WebCore/rendering/MediaControlElements.cpp Committed r47171 M WebCore/ChangeLog M WebCore/rendering/MediaControlElements.cpp A LayoutTests/media/controls-drag-timebar-expected.txt A LayoutTests/media/controls-drag-timebar.html M LayoutTests/ChangeLog r47171 = 5d54d4d1aa0dd34b843952ff291dcdbf59c39a24 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47171 139689 10 eric 2009-08-12 18:00:52 -0700 All reviewed patches have been landed. Closing bug. 139703 11 dimich 2009-08-12 18:49:04 -0700 It turned out that expected.txt is different for windows so landed http://trac.webkit.org/changeset/47174 to split the results. 34647 2009-08-12 02:29:08 -0700 2009-08-12 16:40:04 -0700 patch fix-drag text/plain 1560 hclam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzA5NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDgtMTIgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXgg cmVncmVzc2lvbiBmb3IgZHJhZ2dpbmcgdGhlIG1lZGlhIGNvbnRyb2xsZXIgdGh1bWIuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODIxMQorCisgICAg ICAgIE1vZGlmaWVkIHRoZSBjb25kaXRpb25zIGZvciByZWplY3RpbmcgZXZlbnRzIG9uIHRoZSBt ZWRpYSBjb250cm9sbGVyCisgICAgICAgIHRvIG9ubHkgcmVqZWN0aW5nIG1vdXNlIGV2ZW50cyBu b3QgZnJvbSB0aGUgbGVmdCBidXR0b24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHVz ZXIgYWN0aW9uIGlzIHJlcXVpcmVkLgorCisgICAgICAgICogcmVuZGVyaW5nL01lZGlhQ29udHJv bEVsZW1lbnRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbFRpbWVsaW5lRWxl bWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6CisKIDIwMDktMDgtMTIgIE1pa2hhaWwgTmFnYW5v diAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMu Y3BwCShyZXZpc2lvbiA0NzA5NSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJvbEVs ZW1lbnRzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDgyLDggKzQ4Miw4IEBAIE1lZGlhQ29udHJv bFRpbWVsaW5lRWxlbWVudDo6TWVkaWFDb250cm8KIAogdm9pZCBNZWRpYUNvbnRyb2xUaW1lbGlu ZUVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2ZW50KQogewotICAgIC8vIExl ZnQgYnV0dG9uIGlzIDAuIEFjY2VwdHMgb25seSBpZiBtb3VzZSBldmVudCBpcyBmcm9tIGxlZnQg YnV0dG9uLgotICAgIGlmICghZXZlbnQtPmlzTW91c2VFdmVudCgpIHx8IHN0YXRpY19jYXN0PE1v dXNlRXZlbnQqPihldmVudCktPmJ1dHRvbigpKQorICAgIC8vIExlZnQgYnV0dG9uIGlzIDAuIFJl amVjdHMgbW91c2UgZXZlbnRzIG5vdCBmcm9tIGxlZnQgYnV0dG9uLgorICAgIGlmIChldmVudC0+ aXNNb3VzZUV2ZW50KCkgJiYgc3RhdGljX2Nhc3Q8TW91c2VFdmVudCo+KGV2ZW50KS0+YnV0dG9u KCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFt ZXMoKS5tb3VzZWRvd25FdmVudCkK 34703 2009-08-12 16:40:04 -0700 2009-08-12 18:00:48 -0700 patch + test fix-drag text/plain 5017 hclam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzE2MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDgtMTIgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXgg cmVncmVzc2lvbiBmb3IgZHJhZ2dpbmcgdGhlIG1lZGlhIGNvbnRyb2xsZXIgdGh1bWIuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODIxMQorCisgICAg ICAgIE1vZGlmaWVkIHRoZSBjb25kaXRpb25zIGZvciByZWplY3RpbmcgZXZlbnRzIG9uIHRoZSBt ZWRpYSBjb250cm9sbGVyCisgICAgICAgIHRvIG9ubHkgcmVqZWN0aW5nIG1vdXNlIGV2ZW50cyBu b3QgZnJvbSB0aGUgbGVmdCBidXR0b24uCisKKyAgICAgICAgVGVzdDogbWVkaWEvY29udHJvbHMt ZHJhZy10aW1lYmFyLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVt ZW50cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xUaW1lbGluZUVsZW1lbnQ6 OmRlZmF1bHRFdmVudEhhbmRsZXIpOgorCiAyMDA5LTA4LTEyICBCcmlhbiBXZWluc3RlaW4gIDxi d2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4K SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAJKHJldmlz aW9uIDQ3MDk1KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00ODIsOCArNDgyLDggQEAgTWVkaWFDb250cm9sVGltZWxpbmVF bGVtZW50OjpNZWRpYUNvbnRybwogCiB2b2lkIE1lZGlhQ29udHJvbFRpbWVsaW5lRWxlbWVudDo6 ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCogZXZlbnQpCiB7Ci0gICAgLy8gTGVmdCBidXR0b24g aXMgMC4gQWNjZXB0cyBvbmx5IGlmIG1vdXNlIGV2ZW50IGlzIGZyb20gbGVmdCBidXR0b24uCi0g ICAgaWYgKCFldmVudC0+aXNNb3VzZUV2ZW50KCkgfHwgc3RhdGljX2Nhc3Q8TW91c2VFdmVudCo+ KGV2ZW50KS0+YnV0dG9uKCkpCisgICAgLy8gTGVmdCBidXR0b24gaXMgMC4gUmVqZWN0cyBtb3Vz ZSBldmVudHMgbm90IGZyb20gbGVmdCBidXR0b24uCisgICAgaWYgKGV2ZW50LT5pc01vdXNlRXZl bnQoKSAmJiBzdGF0aWNfY2FzdDxNb3VzZUV2ZW50Kj4oZXZlbnQpLT5idXR0b24oKSkKICAgICAg ICAgcmV0dXJuOwogCiAgICAgaWYgKGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLm1vdXNl ZG93bkV2ZW50KQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDcxNjEpCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOC0xMiAgQWxwaGEg TGFtICA8aGNsYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCByZWdyZXNzaW9uIGZvciBkcmFnZ2luZyB0aGUgbWVkaWEg Y29udHJvbGxlciB0aHVtYi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI4MjExCisKKyAgICAgICAgQWRkIGEgbGF5b3V0IHRlc3QgdG8gbWFrZSBzdXJl IGRyYWdnaW5nIHRoZSB0aW1lYmFyIHRodW1iIG9mIG1lZGlhCisgICAgICAgIGNvbnRyb2xzIGNh dXNlcyBzZWVrcy4KKworICAgICAgICAqIG1lZGlhL2NvbnRyb2xzLWRyYWctdGltZWJhci1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL2NvbnRyb2xzLWRyYWctdGltZWJhci5o dG1sOiBBZGRlZC4KKwogMjAwOS0wOC0xMiAgTWljaGVsYW5nZWxvIERlIFNpbW9uZSAgPG1pY2Rl c2ltQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6 IExheW91dFRlc3RzL21lZGlhL2NvbnRyb2xzLWRyYWctdGltZWJhci1leHBlY3RlZC50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtZHJhZy10aW1lYmFyLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL21lZGlhL2NvbnRyb2xzLWRyYWct dGltZWJhci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKK1Rlc3Qg dGhhdCBkcmFnIHRoZSB0aW1lYmFyIHRodW1iIGNhdXNlcyBzZWVrcy4KKworUlVOKHZpZGVvLmF1 dG9wbGF5ID0gdHJ1ZSkKK1JVTih2aWRlby5zcmMgPSAnY29udGVudC90ZXN0Lm1wNCcpCitFVkVO VChwbGF5aW5nKQorRVZFTlQoc2Vla2VkKQorVGltZTogMS43CitFVkVOVChzZWVrZWQpCitUaW1l OiAyLjIKK0VWRU5UKHNlZWtlZCkKK1RpbWU6IDIuNworRU5EIE9GIFRFU1QKKwpJbmRleDogTGF5 b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtZHJhZy10aW1lYmFyLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtZHJhZy10aW1lYmFyLmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9tZWRpYS9jb250cm9scy1kcmFnLXRpbWViYXIuaHRtbAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSw2NiBAQAorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDx0aXRs ZT5kcmFnIHRpbWViYXIgdGVzdDwvdGl0bGU+CisgICAgICAgIDxzY3JpcHQgc3JjPXZpZGVvLXRl c3QuanM+PC9zY3JpcHQ+CisgICAgICAgIDxzY3JpcHQ+CisgICAgICAgICAgICB2YXIgeCwgeSwg dGltZSwgY291bnQ7CisgICAgICAgICAgICB2YXIgc2VlayA9IDA7CisKKyAgICAgICAgICAgIGlm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgICAgICBmdW5jdGlvbiB0ZXN0KCkK KyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7 CisgICAgICAgICAgICAgICAgICAgIHggPSB2aWRlby5vZmZzZXRMZWZ0ICsgKHZpZGVvLm9mZnNl dFdpZHRoIC8gMyk7CisgICAgICAgICAgICAgICAgICAgIHkgPSB2aWRlby5vZmZzZXRUb3AgKyB2 aWRlby5vZmZzZXRIZWlnaHQgLSAxMDsKKyAgICAgICAgICAgICAgICAgICAgdGltZSA9IHZpZGVv LmN1cnJlbnRUaW1lLnRvRml4ZWQoMSk7CisgICAgICAgICAgICAgICAgICAgIGNvdW50ID0gMDsK KworICAgICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5kcmFnTW9kZSA9IGZhbHNlOworICAg ICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyh4LCB5KTsKKyAgICAgICAg ICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgICAgICAgICAgICAgfQor ICAgICAgICAgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KCJtb3ZlKCkiLCAxMDApOworICAgICAg ICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBtb3ZlKCkKKyAgICAgICAgICAgIHsKKyAg ICAgICAgICAgICAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7CisgICAgICAgICAgICAgICAg ICAgIHggKz0gMjA7CisgICAgICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRv KHgsIHkpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICBpZiAoKytjb3VudCA+ PSAzKQorICAgICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAgICAg ICAgICAgICAgd2luZG93LnNldFRpbWVvdXQoIm1vdmUoKSIsIDEwMCk7CisgICAgICAgICAgICB9 CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIHBsYXlpbmcoKQorICAgICAgICAgICAgeworICAgICAg ICAgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KCJ0ZXN0KCkiLCAxMDApOworICAgICAgICAgICAg fQorCisgICAgICAgICAgICBmdW5jdGlvbiBzZWVrZWQoKQorICAgICAgICAgICAgeworICAgICAg ICAgICAgICAgIGNvbnNvbGVXcml0ZSgiVGltZTogIiArIHZpZGVvLmN1cnJlbnRUaW1lLnRvRml4 ZWQoMSkpOworICAgICAgICAgICAgICAgIGlmICgrK3NlZWsgPT0gMykKKyAgICAgICAgICAgICAg ICAgICAgZW5kVGVzdCgpOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBz dGFydCgpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgZmluZE1lZGlhRWxlbWVudCgp OworICAgICAgICAgICAgICAgIHdhaXRGb3JFdmVudCgncGxheWluZycsIHBsYXlpbmcpOworICAg ICAgICAgICAgICAgIHdhaXRGb3JFdmVudCgnc2Vla2VkJywgc2Vla2VkKTsKKyAgICAgICAgICAg ICAgICBydW4oInZpZGVvLmF1dG9wbGF5ID0gdHJ1ZSIpOworICAgICAgICAgICAgICAgIHJ1bigi dmlkZW8uc3JjID0gJ2NvbnRlbnQvdGVzdC5tcDQnIik7CisgICAgICAgICAgICB9ICAgIAorICAg ICAgICA8L3NjcmlwdD4KKyAgICA8L2hlYWQ+CisKKyAgICA8Ym9keSBvbmxvYWQ9InN0YXJ0KCki PgorICAgIDxwPlRlc3QgdGhhdCBkcmFnIHRoZSB0aW1lYmFyIHRodW1iIGNhdXNlcyBzZWVrcy48 L3A+CisgICAgPHZpZGVvIGNvbnRyb2xzPjwvdmlkZW8+CisgICAgPC9ib2R5PgorPC9odG1sPgor Cg==