28210 2009-08-11 21:30:22 -0700 Document relation between major objects in WebCore 2009-08-12 07:14:10 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned darin oldest_to_newest 139221 0 abarth 2009-08-11 21:30:22 -0700 We should create a page on the web site that explains the relation between the major objects in webcore, especially when those relations can be null. 139226 1 34635 abarth 2009-08-11 21:39:43 -0700 Created attachment 34635 Patch v1 139227 2 34636 abarth 2009-08-11 21:40:36 -0700 Created attachment 34636 Patch v1 139229 3 abarth 2009-08-11 21:55:37 -0700 Sending WebKitSite/ChangeLog Adding WebKitSite/coding/major-objects.html Transmitting file data .. Committed revision 47085. http://trac.webkit.org/changeset/47085 139256 4 darin 2009-08-11 22:52:59 -0700 This diagram shows DOMWindow between Frame and Document. But it's not really like that. 139317 5 abarth 2009-08-12 07:14:10 -0700 (In reply to comment #4) > This diagram shows DOMWindow between Frame and Document. But it's not really > like that. Ok. I'll see what I can do to fix that. 34635 2009-08-11 21:39:43 -0700 2009-08-11 21:40:26 -0700 Patch v1 bug-28210-20090811213941.patch text/plain 3229 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggYTkwNmRmMC4uZDM3NmExNiAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wOC0xMSAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERvY3VtZW50IHJlbGF0aW9uIGJldHdlZW4gbWFqb3Ig b2JqZWN0cyBpbiBXZWJDb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yODIxMAorCisgICAgICAgIEFkZGVkIGEgZGlhZ3JhbSBzaG93aW5nIHRoZSBy ZWxhdGlvbiBiZXR3ZWVuIG1ham9yIG9iamVjdHMuCisKKyAgICAgICAgKiBjb2RpbmcvbWFqb3It b2JqZWN0cy5odG1sOiBBZGRlZC4KKwogMjAwOS0wOC0wNyAgSm9zZXBoIFBlY29yYXJvICA8am9l cGVjazAyQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KZGlm ZiAtLWdpdCBhL1dlYktpdFNpdGUvY29kaW5nL21ham9yLW9iamVjdHMuaHRtbCBiL1dlYktpdFNp dGUvY29kaW5nL21ham9yLW9iamVjdHMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi45ZGM1ZTE0Ci0tLSAvZGV2L251bGwKKysrIGIvV2ViS2l0U2l0ZS9jb2RpbmcvbWFq b3Itb2JqZWN0cy5odG1sCkBAIC0wLDAgKzEsNjkgQEAKKzw/cGhwIAorICAgICR0aXRsZT0iTWFq b3IgT2JqZWN0IGluIFdlYkNvcmUiOworICAgIGluY2x1ZGUoIi4uL2hlYWRlci5pbmMiKTsgCis/ PgorCis8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgorICAgIC5hc2NpaWFydCB7CisgICAgICAgIGJh Y2tncm91bmQtY29sb3I6ICNlZWU7CisgICAgICAgIHBhZGRpbmc6IDFlbTsKKyAgICAgICAgbWFy Z2luLWxlZnQ6IDJlbTsKKyAgICAgICAgbWFyZ2luLXJpZ2h0OiAyZW07CisgICAgICAgIG92ZXJm bG93LXg6IGF1dG87CisgICAgfQorPC9zdHlsZT4KKworPGgxPk1ham9yIE9iamVjdCBpbiBXZWJD b3JlPC9oMT4KKzxkaXY+QWRhbSBCYXJ0aDwvZGl2PgorPGRpdj5maXJzdCBkcmFmdCwgMjAwOS0w OC0xMTwvZGl2PgorCis8cD5XZWJDb3JlIHVzZXMgYSBudW1iZXIgb2Ygb2JqZWN0cyB0byByZXBy ZXNlbnQgYSB3ZWIgcGFnZSBpbiBtZW1vcnkuICBUaGlzCitkb2N1bWVudCBkZXNjcmliZXMgdGhl IG1ham9yIG9iamVjdHMgYW5kIHRoZSByZWxhdGlvbiBiZXR3ZWVuIHRoZW0uICBJbiBzb21lCitj YXNlcywgdGhlIGNvbm5lY3Rpb24gYmV0d2VlbiB0aGVzZSBvYmplY3RzIGNhbiBiZSBicm9rZW4s IHJlc3VsdGluZyBpbiBudWxsCitwb2ludGVycy4gIFdoZW4gdHJhdmVyc2luZyB0aGVzZSBwb2lu dGVycywgY29kZSBtdXN0IGJlIGNhcmVmdWwgdG8gY29uc2lkZXIKK3RoZSAiZGV0YWNoZWQiIGNh c2UgYW5kIGdyYWNlZnVsbHkgaGFuZGxlIG51bGwgcG9pbnRlcnMuPC9wPgorCis8cHJlIGNsYXNz PSJhc2NpaWFydCI+CisgICstLS0tLS0tLS0rCisgIHwgQ2hyb21lICB8CisgICstLS0tKy0tLS0r CisgICAgICAgfAorICAgKy0tLSstLS0rICAgICArLS0tLS0tLS0tLSsKKyAgIHwgUGFnZSAgKy0t LS0+fCBTZXR0aW5ncyB8CisgICArLS0tKy0tLSsgICAgICstLS0tLS0tLS0tKworICAgICAgIHwK KyAgICAgICArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0gLi4uIG90aGVyIEZyYW1lIG9iamVj dHMKKyAgICAgICB8CisgICArLS0tKy0tLSsgICArLS0tLS0tLS0tLS0tLSsgICAgICAgICAgICAg ICAgICAgKy0tLS0tLS0tLS0tLS0tLS0tLS0rCisgICB8IEZyYW1lICstLS0rIEZyYW1lTG9hZGVy ICsgICAgICAgICAgICAgICAgICAgfCBKU0RPTVdpbmRvd1NoZWxsICB8CisgICArLS0tKy0tLSsg ICArLS0tLS0tLS0tLS0tLSsgICAgICAgICAgICAgICAgICAgKy0tLS0tLS0tLSstLS0tLS0tLS0r CisgICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwKKyAgICAgICB8ICAgICAgICAgL1wgIFJlLXVzZWQgYWZ0ZXIgbmF2aWdhdGlvbiAgIC9c ICAgICAgICAgfAorLi4uLi4uLnwuLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4u Li4uLi4uLi4uLi4uLi58Li4uLi4uLi4uLi4uCisgICAgICAgfCAgICAgICAgIFwvICBSZXBsYWNl ZCBhZnRlciBuYXZpZ2F0aW9uICBcLyAgICAgICAgIHwKKyAgICAgICB8ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAorICAgICAgIHwgPC0tIE51bGwg YWZ0ZXIgbmF2aWdhdGlvbiAgICAgICAgICAgICAgICAgICAgICAgICB8CisgICAgICAgfCAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKKyArLS0tLS0r LS0tLS0rICAgICAgICAgKy0tLS0tLS0tLS0tLS0rICAgICAgICAgICAgICAgICAgICAgfAorIHwg RE9NV2luZG93IHw8LS1pbXBsLS0rIEpTRE9NV2luZG93IHw8LS0tLS0tLXdpbmRvdy0tLS0tLS0r CisgKy0tLS0tKy0tLS0tKyAgICAgICAgICstLS0tLS0tLS0tLS0tKworICAgICAgIHwKKyAgICAg ICB8IDwtLSBDYW4gYmUgbnVsbCBmb3IgRG9jdW1lbnRzIGNyZWF0ZWQgYnkgWE1MSHR0cFJlcXVl c3QKKyAgICAgICB8CisgKy0tLS0tKy0tLS0tKyAgICAgICAgICstLS0tLS0tLS0tLS0tKworIHwg RG9jdW1lbnQgIHw8LS1pbXBsLS0rIEpTRG9jdW1lbnQgIHwKKyArLS0tLS0rLS0tLS0rICAgICAg ICAgKy0tLS0tLS0tLS0tLS0rCisgICAgICAgfAorICAgICAgIHwgPC0tIENhbiBiZSBudWxsIGZv ciBEb2N1bWVudFR5cGUgb2JqZWN0cworICAgICAgIHwKKyAgICstLS0rLS0tKyAgICAgICAgICAg Ky0tLS0tLS0tKworICAgfCBOb2RlICB8PC0tLWltcGwtLS18IEpTTm9kZSB8CisgICArLS0tLS0t LSsgICAgICAgICAgICstLS0tLS0tLSsKKzwvcHJlPgorCis8cD5JZiB5b3UgaGF2ZSBhbnkgY29t bWVudHMgb24gdGhlIGFib3ZlIG9yIG90aGVyIGlkZWFzIGFib3V0IGltcHJvdmluZyB0aGUgY2xh cml0eSwKK3Njb3BlLCBvciBwcmVzZW50YXRpb24sIHBsZWFzZSBzZW5kIG1haWwgdG8gdGhlIDxh IGhyZWY9Ii9jb250YWN0Lmh0bWwiPldlYktpdCBtYWlsaW5nIGxpc3Q8L2E+LjwvcD4KKworPD9w aHAKKyAgICBpbmNsdWRlKCIuLi9mb290ZXIuaW5jIik7Cis/Pg== 34636 2009-08-11 21:40:36 -0700 2009-08-11 21:48:25 -0700 Patch v1 bug-28210-20090811214034.patch text/plain 3230 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggYTkwNmRmMC4uZDM3NmExNiAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wOC0xMSAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERvY3VtZW50IHJlbGF0aW9uIGJldHdlZW4gbWFqb3Ig b2JqZWN0cyBpbiBXZWJDb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yODIxMAorCisgICAgICAgIEFkZGVkIGEgZGlhZ3JhbSBzaG93aW5nIHRoZSBy ZWxhdGlvbiBiZXR3ZWVuIG1ham9yIG9iamVjdHMuCisKKyAgICAgICAgKiBjb2RpbmcvbWFqb3It b2JqZWN0cy5odG1sOiBBZGRlZC4KKwogMjAwOS0wOC0wNyAgSm9zZXBoIFBlY29yYXJvICA8am9l cGVjazAyQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KZGlm ZiAtLWdpdCBhL1dlYktpdFNpdGUvY29kaW5nL21ham9yLW9iamVjdHMuaHRtbCBiL1dlYktpdFNp dGUvY29kaW5nL21ham9yLW9iamVjdHMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi5hNDRlNTljCi0tLSAvZGV2L251bGwKKysrIGIvV2ViS2l0U2l0ZS9jb2RpbmcvbWFq b3Itb2JqZWN0cy5odG1sCkBAIC0wLDAgKzEsNjkgQEAKKzw/cGhwIAorICAgICR0aXRsZT0iTWFq b3IgT2JqZWN0IGluIFdlYkNvcmUiOworICAgIGluY2x1ZGUoIi4uL2hlYWRlci5pbmMiKTsgCis/ PgorCis8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgorICAgIC5hc2NpaWFydCB7CisgICAgICAgIGJh Y2tncm91bmQtY29sb3I6ICNlZWU7CisgICAgICAgIHBhZGRpbmc6IDFlbTsKKyAgICAgICAgbWFy Z2luLWxlZnQ6IDJlbTsKKyAgICAgICAgbWFyZ2luLXJpZ2h0OiAyZW07CisgICAgICAgIG92ZXJm bG93LXg6IGF1dG87CisgICAgfQorPC9zdHlsZT4KKworPGgxPk1ham9yIE9iamVjdHMgaW4gV2Vi Q29yZTwvaDE+Cis8ZGl2PkFkYW0gQmFydGg8L2Rpdj4KKzxkaXY+Zmlyc3QgZHJhZnQsIDIwMDkt MDgtMTE8L2Rpdj4KKworPHA+V2ViQ29yZSB1c2VzIGEgbnVtYmVyIG9mIG9iamVjdHMgdG8gcmVw cmVzZW50IGEgd2ViIHBhZ2UgaW4gbWVtb3J5LiAgVGhpcworZG9jdW1lbnQgZGVzY3JpYmVzIHRo ZSBtYWpvciBvYmplY3RzIGFuZCB0aGUgcmVsYXRpb24gYmV0d2VlbiB0aGVtLiAgSW4gc29tZQor Y2FzZXMsIHRoZSBjb25uZWN0aW9uIGJldHdlZW4gdGhlc2Ugb2JqZWN0cyBjYW4gYmUgYnJva2Vu LCByZXN1bHRpbmcgaW4gbnVsbAorcG9pbnRlcnMuICBXaGVuIHRyYXZlcnNpbmcgdGhlc2UgcG9p bnRlcnMsIGNvZGUgbXVzdCBiZSBjYXJlZnVsIHRvIGNvbnNpZGVyCit0aGUgImRldGFjaGVkIiBj YXNlIGFuZCBncmFjZWZ1bGx5IGhhbmRsZSBudWxsIHBvaW50ZXJzLjwvcD4KKworPHByZSBjbGFz cz0iYXNjaWlhcnQiPgorICArLS0tLS0tLS0tKworICB8IENocm9tZSAgfAorICArLS0tLSstLS0t KworICAgICAgIHwKKyAgICstLS0rLS0tKyAgICAgKy0tLS0tLS0tLS0rCisgICB8IFBhZ2UgICst LS0tPnwgU2V0dGluZ3MgfAorICAgKy0tLSstLS0rICAgICArLS0tLS0tLS0tLSsKKyAgICAgICB8 CisgICAgICAgKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tIC4uLiBvdGhlciBGcmFtZSBvYmpl Y3RzCisgICAgICAgfAorICAgKy0tLSstLS0rICAgKy0tLS0tLS0tLS0tLS0rICAgICAgICAgICAg ICAgICAgICstLS0tLS0tLS0tLS0tLS0tLS0tKworICAgfCBGcmFtZSArLS0tKyBGcmFtZUxvYWRl ciArICAgICAgICAgICAgICAgICAgIHwgSlNET01XaW5kb3dTaGVsbCAgfAorICAgKy0tLSstLS0r ICAgKy0tLS0tLS0tLS0tLS0rICAgICAgICAgICAgICAgICAgICstLS0tLS0tLS0rLS0tLS0tLS0t KworICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB8CisgICAgICAgfCAgICAgICAgIC9cICBSZS11c2VkIGFmdGVyIG5hdmlnYXRpb24gICAv XCAgICAgICAgIHwKKy4uLi4uLi58Li4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4u Li4uLi4uLi4uLi4uLi4ufC4uLi4uLi4uLi4uLgorICAgICAgIHwgICAgICAgICBcLyAgUmVwbGFj ZWQgYWZ0ZXIgbmF2aWdhdGlvbiAgXC8gICAgICAgICB8CisgICAgICAgfCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKKyAgICAgICB8IDwtLSBOdWxs IGFmdGVyIG5hdmlnYXRpb24gICAgICAgICAgICAgICAgICAgICAgICAgfAorICAgICAgIHwgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CisgKy0tLS0t Ky0tLS0tKyAgICAgICAgICstLS0tLS0tLS0tLS0tKyAgICAgICAgICAgICAgICAgICAgIHwKKyB8 IERPTVdpbmRvdyB8PC0taW1wbC0tKyBKU0RPTVdpbmRvdyB8PC0tLS0tLS13aW5kb3ctLS0tLS0t KworICstLS0tLSstLS0tLSsgICAgICAgICArLS0tLS0tLS0tLS0tLSsKKyAgICAgICB8CisgICAg ICAgfCA8LS0gQ2FuIGJlIG51bGwgZm9yIERvY3VtZW50cyBjcmVhdGVkIGJ5IFhNTEh0dHBSZXF1 ZXN0CisgICAgICAgfAorICstLS0tLSstLS0tLSsgICAgICAgICArLS0tLS0tLS0tLS0tLSsKKyB8 IERvY3VtZW50ICB8PC0taW1wbC0tKyBKU0RvY3VtZW50ICB8CisgKy0tLS0tKy0tLS0tKyAgICAg ICAgICstLS0tLS0tLS0tLS0tKworICAgICAgIHwKKyAgICAgICB8IDwtLSBDYW4gYmUgbnVsbCBm b3IgRG9jdW1lbnRUeXBlIG9iamVjdHMKKyAgICAgICB8CisgICArLS0tKy0tLSsgICAgICAgICAg ICstLS0tLS0tLSsKKyAgIHwgTm9kZSAgfDwtLS1pbXBsLS0tfCBKU05vZGUgfAorICAgKy0tLS0t LS0rICAgICAgICAgICArLS0tLS0tLS0rCis8L3ByZT4KKworPHA+SWYgeW91IGhhdmUgYW55IGNv bW1lbnRzIG9uIHRoZSBhYm92ZSBvciBvdGhlciBpZGVhcyBhYm91dCBpbXByb3ZpbmcgdGhlIGNs YXJpdHksCitzY29wZSwgb3IgcHJlc2VudGF0aW9uLCBwbGVhc2Ugc2VuZCBtYWlsIHRvIHRoZSA8 YSBocmVmPSIvY29udGFjdC5odG1sIj5XZWJLaXQgbWFpbGluZyBsaXN0PC9hPi48L3A+CisKKzw/ cGhwCisgICAgaW5jbHVkZSgiLi4vZm9vdGVyLmluYyIpOworPz4=