28205 2009-08-11 17:54:49 -0700 [Chromium] drop down menu letter selection, skip selections 2009-08-13 19:53:40 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED http://www.njtransit.com/sf/sf_servlet.srv?hdnPageAction=TrainSchedulesTo P2 Normal --- 0 xji webkit-unassigned eric hbono xji oldest_to_newest 139185 0 xji 2009-08-11 17:54:49 -0700 steps to reproduce the problem? 1. go to the above website with a dropdown selection menu 2. click the drop down menu to show selections 3. press a letter (such as 'A') to skip to the selection you want 4. it will automatically skip to the 2nd corresponding lettered selection 5. continue press 'A', it selects every other item. Chromium bug: http://code.google.com/p/chromium/issues/detail?id=18950 139200 1 34631 xji 2009-08-11 18:26:48 -0700 Created attachment 34631 patch w/ manual test 139386 2 34631 eric 2009-08-12 10:20:25 -0700 Comment on attachment 34631 patch w/ manual test OK. 139533 3 34631 eric 2009-08-12 14:09:04 -0700 Comment on attachment 34631 patch w/ manual test Rejecting patch 34631 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1 139543 4 34631 eric 2009-08-12 14:17:23 -0700 Comment on attachment 34631 patch w/ manual test The failure was: Testing 11049 test cases. fast/js/global-constructors.html -> failed Which should be unrelated. I expect the bots just went red and I didn't notice. 139560 5 xji 2009-08-12 14:41:50 -0700 (In reply to comment #4) > (From update of attachment 34631 [details]) > The failure was: > Testing 11049 test cases. > fast/js/global-constructors.html -> failed > > Which should be unrelated. I expect the bots just went red and I didn't > notice. you probably right. There is no such failure in my local run with my change. 139563 6 34631 eric 2009-08-12 14:49:26 -0700 Comment on attachment 34631 patch w/ manual test Clearing flags on attachment: 34631 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/manual-tests/keyboard_select_elements_with_same_beginning.html M WebCore/platform/chromium/PopupMenuChromium.cpp Committed r47150 M WebCore/ChangeLog M WebCore/platform/chromium/PopupMenuChromium.cpp A WebCore/manual-tests/keyboard_select_elements_with_same_beginning.html r47150 = bc763ed3dfd04ac8690009160a8baa8af4d3053e (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47150 139564 7 eric 2009-08-12 14:49:30 -0700 All reviewed patches have been landed. Closing bug. 140128 8 hbono 2009-08-13 19:53:40 -0700 *** Bug 28254 has been marked as a duplicate of this bug. *** 34631 2009-08-11 18:26:48 -0700 2009-08-12 14:49:26 -0700 patch w/ manual test 28205.v1 text/plain 5311 xji SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzA3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDktMDgtMTEgIFhpYW9tZWkgSmkgIDx4amlAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBb Q2hyb21pdW1dIGRyb3AgZG93biBtZW51IGxldHRlciBzZWxlY3Rpb24sIHNraXAgc2VsZWN0aW9u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgyMDUK KworICAgICAgICBOb3QgYXV0by10ZXN0YWJsZSBzaW5jZSBpdCBpcyBjaHJvbWltIHBsYXRmb3Jt IHNwZWNpZmljIGNvZGUsIGFuZCBpdCBpbnZvbHZlcyBzZW5kaW5nIGEga2V5Ym9hcmQgCisgICAg ICAgIGV2ZW50IHRvIHRoZSBwb3B1cCwgd2hpY2ggaXMgbm90IHBvc3NpYmxlIChldmVudFNlbmRl ciBzZW5kcyB0aGUga2V5CisgICAgICAgIGV2ZW50cyB0aHJvdWdoIHdlYnZpZXcsIHdlIHdhbnQg dG8gZ28gdGhyb3VnaCB0aGUgd2Vid2lkZ2V0KS4KKworICAgICAgICAqIG1hbnVhbC10ZXN0cy9r ZXlib2FyZF9zZWxlY3RfZWxlbWVudHNfd2l0aF9zYW1lX2JlZ2lubmluZy5odG1sOiBBZGRlZC4K KyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjppc0NoYXJhY3RlclR5cGVFdmVudCk6IHN0eWxlIGNoYW5nZS4KKyAgICAg ICAgKFdlYkNvcmU6OlBvcHVwTGlzdEJveDo6aGFuZGxlS2V5RXZlbnQpOiB0eXBlQWhlYWRGaW5k IHNob3VsZCBiZSBjYWxsZWQgb25seSB3aGVuIHRoZSBldmVudCBpcworICAgICAgICBhIGNoYXJh Y3RlciB0eXBlIGV2ZW50IHRvIGF2b2lkIGNhbGxpbmcgdHdpY2UgZm9yIEVuZ2xpc2guCisgICAg ICAgIChXZWJDb3JlOjpQb3B1cExpc3RCb3g6OnR5cGVBaGVhZEZpbmQpOiByZW1vdmUgdW5uZWNl c3NhcnkgY2hlY2tpbmcgb2YgaXNDaGFyYWN0ZXJUeXBlRXZlbnQoKSBzaW5jZSB0aGUgd2hvbGUg ZnVuY3Rpb24gaXMgb25seSBjYWxsZWQgdW5kZXIgdGhhdCBjb25kaXRpb24uCisKIDIwMDktMDgt MTEgIERyZXcgV2lsc29uICA8YXR3aWxzb25AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYkNvcmUvbWFudWFsLXRlc3RzL2tleWJvYXJkX3Nl bGVjdF9lbGVtZW50c193aXRoX3NhbWVfYmVnaW5uaW5nLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9tYW51YWwtdGVzdHMva2V5Ym9hcmRfc2VsZWN0X2VsZW1lbnRzX3dpdGhfc2FtZV9iZWdp bm5pbmcuaHRtbAkocmV2aXNpb24gMCkKKysrIFdlYkNvcmUvbWFudWFsLXRlc3RzL2tleWJvYXJk X3NlbGVjdF9lbGVtZW50c193aXRoX3NhbWVfYmVnaW5uaW5nLmh0bWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMjkgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxNRVRBIEhU VFAtRVFVSVY9IkNPTlRFTlQtVFlQRSIgQ09OVEVOVD0idGV4dC9odG1sOyBjaGFyc2V0PVVURi04 Ij4KKzx0aXRsZT4KK1Rlc3Qgc2VsZWN0IG9uIGVsZW1lbnRzIHdpdGggc2FtZSBiZWdpbm5pbmcg bGV0dGVyCis8L3RpdGxlPgorPC9oZWFkPgorPGJvZHk+CitTZWUgYnVnOjxhIGhyZWY9Imh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODIwNSI+MjgyMDU8L2E+LgorPHA+ CitDbGljayB0aGUgZHJvcC1kb3duIHRvIHNob3cgc2VsZWN0aW9ucyAobm90IG5hdmlnYXRlIHRv IHRoZSBzZWxlY3Rpb24gYm94KS4KK1R5cGUgdGhlIGZpcnN0IGxldHRlciAnQScgdG8gZ28gdG8g dGhlIGVsZW1lbnRzIHN0YXJ0IHdpdGggJ0EnLgorSXQgc2hvdWxkIHNlbGVjdCB0aGUgZmlyc3Qg aXRlbSBzdGFydHMgd2l0aCAnQScuCitJbiB3aW5kb3dzLCBDb250aW51ZSB0eXBpbmcgJ0EnLCBp dCBzaG91bGQgY29udGludWUgdG8gc2VsZWN0IHRoZSBuZXh0IGl0ZW0gc3RhcnRzIHdpdGggJ0En LgorPHA+Cis8c2VsZWN0IG5hbWU9InNlbE9yaWdpbiI+IAorICAgIDxvcHRpb24gdmFsdWU9IiI+ U2VsZWN0IFN0YXRpb248L29wdGlvbj4gCisgICAgPG9wdGlvbiB2YWx1ZT0iMzcxNjlfTkpDTCI+ QWJlcmRlZW4gTWF0YXdhbjwvb3B0aW9uPiAKKyAgICA8b3B0aW9uIHZhbHVlPSIyX0FUTEMiPkFi c2Vjb248L29wdGlvbj4gCisgICAgPG9wdGlvbiB2YWx1ZT0iM19NTkJOIj5BbGxlbmRhbGU8L29w dGlvbj4gCisgICAgPG9wdGlvbiB2YWx1ZT0iNF9OSkNMIj5BbGxlbmh1cnN0PC9vcHRpb24+IAor ICAgIDxvcHRpb24gdmFsdWU9IjEyX01ORSI+QmFza2luZyBSaWRnZTwvb3B0aW9uPiAKKyAgICA8 b3B0aW9uIHZhbHVlPSIxM19OSkNMIj5CYXkgSGVhZDwvb3B0aW9uPiAKKyAgICA8b3B0aW9uIHZh bHVlPSIxNF9CTlROIj5CYXkgU3RyZWV0PC9vcHRpb24+IAorICAgIDxvcHRpb24gdmFsdWU9IjE1 X05KQ0wiPkJlbG1hcjwvb3B0aW9uPiAKKzwvc2VsZWN0PgorPC9ib2R5PgorPC9odG1sPgpJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAJ KHJldmlzaW9uIDQ3MDY3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVD aHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwMSw2ICs2MDEsMjIgQEAgYm9vbCBQb3B1 cExpc3RCb3g6OmlzSW50ZXJlc3RlZEluRXZlbnRGbwogICAgIH0KIH0KIAorc3RhdGljIGJvb2wg aXNDaGFyYWN0ZXJUeXBlRXZlbnQoY29uc3QgUGxhdGZvcm1LZXlib2FyZEV2ZW50JiBldmVudCkK K3sKKyAgICAvLyBDaGVjayB3aGV0aGVyIHRoZSBldmVudCBpcyBhIGNoYXJhY3Rlci10eXBlZCBl dmVudCBvciBub3QuCisgICAgLy8gSW4gV2luZG93cywgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpD aGFyIChub3QgUmF3S2V5RG93bikgdHlwZSBldmVudAorICAgIC8vIGlzIGNvbnNpZGVyZWQgYXMg Y2hhcmFjdGVyIHR5cGUgZXZlbnQuIEluIE1hYyBPUywgS2V5RG93biAobm90CisgICAgLy8gS2V5 VXApIGlzIGNvbnNpZGVyZWQgYXMgY2hhcmFjdGVyIHR5cGUgZXZlbnQuCisjaWYgUExBVEZPUk0o V0lOX09TKQorICAgIGlmIChldmVudC50eXBlKCkgPT0gUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpD aGFyKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbHNlCisgICAgaWYgKGV2ZW50LnR5cGUoKSA9 PSBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OktleURvd24pCisgICAgICAgIHJldHVybiB0cnVlOwor I2VuZGlmCisgICAgcmV0dXJuIGZhbHNlOworfQorCiBib29sIFBvcHVwTGlzdEJveDo6aGFuZGxl S2V5RXZlbnQoY29uc3QgUGxhdGZvcm1LZXlib2FyZEV2ZW50JiBldmVudCkKIHsKICAgICBpZiAo ZXZlbnQudHlwZSgpID09IFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6S2V5VXApCkBAIC02NDEsNyAr NjU3LDggQEAgYm9vbCBQb3B1cExpc3RCb3g6OmhhbmRsZUtleUV2ZW50KGNvbnN0IAogICAgICAg ICBicmVhazsKICAgICBkZWZhdWx0OgogICAgICAgICBpZiAoIWV2ZW50LmN0cmxLZXkoKSAmJiAh ZXZlbnQuYWx0S2V5KCkgJiYgIWV2ZW50Lm1ldGFLZXkoKQotICAgICAgICAgICAgJiYgaXNQcmlu dGFibGVDaGFyKGV2ZW50LndpbmRvd3NWaXJ0dWFsS2V5Q29kZSgpKSkKKyAgICAgICAgICAgICYm IGlzUHJpbnRhYmxlQ2hhcihldmVudC53aW5kb3dzVmlydHVhbEtleUNvZGUoKSkKKyAgICAgICAg ICAgICYmIGlzQ2hhcmFjdGVyVHlwZUV2ZW50KGV2ZW50KSkKICAgICAgICAgICAgIHR5cGVBaGVh ZEZpbmQoZXZlbnQpOwogICAgICAgICBicmVhazsKICAgICB9CkBAIC02OTAsMjEgKzcwNyw2IEBA IHN0YXRpYyBTdHJpbmcgc3RyaXBMZWFkaW5nV2hpdGVTcGFjZShjb24KICAgICByZXR1cm4gc3Ry aW5nLnN1YnN0cmluZyhpLCBsZW5ndGggLSBpKTsKIH0KIAotc3RhdGljIGJvb2wgaXNDaGFyYWN0 ZXJUeXBlRXZlbnQoY29uc3QgUGxhdGZvcm1LZXlib2FyZEV2ZW50JiBldmVudCkgewotICAgIC8v IENoZWNrIHdoZXRoZXIgdGhlIGV2ZW50IGlzIGEgY2hhcmFjdGVyLXR5cGVkIGV2ZW50IG9yIG5v dC4gCi0gICAgLy8gSW4gV2luZG93cywgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpDaGFyIChub3Qg UmF3S2V5RG93bikgdHlwZSBldmVudAotICAgIC8vIGlzIGNvbnNpZGVyZWQgYXMgY2hhcmFjdGVy IHR5cGUgZXZlbnQuIEluIE1hYyBPUywgS2V5RG93biAobm90IAotICAgIC8vIEtleVVwKSBpcyBj b25zaWRlcmVkIGFzIGNoYXJhY3RlciB0eXBlIGV2ZW50LgotI2lmIFBMQVRGT1JNKFdJTl9PUykK LSAgICBpZiAoZXZlbnQudHlwZSgpID09IFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Q2hhcikKLSAg ICAgICAgcmV0dXJuIHRydWU7Ci0jZWxzZQotICAgIGlmIChldmVudC50eXBlKCkgPT0gUGxhdGZv cm1LZXlib2FyZEV2ZW50OjpLZXlEb3duKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLSNlbmRpZgot ICAgIHJldHVybiBmYWxzZTsKLX0KLQogLy8gRnJvbSBIVE1MU2VsZWN0RWxlbWVudC5jcHAsIHdp dGggbW9kaWZpY2F0aW9ucwogdm9pZCBQb3B1cExpc3RCb3g6OnR5cGVBaGVhZEZpbmQoY29uc3Qg UGxhdGZvcm1LZXlib2FyZEV2ZW50JiBldmVudCkKIHsKQEAgLTcxNCw4ICs3MTYsNyBAQCB2b2lk IFBvcHVwTGlzdEJveDo6dHlwZUFoZWFkRmluZChjb25zdCBQCiAgICAgLy8gUmVzZXQgdGhlIHRp bWUgd2hlbiB1c2VyIHR5cGVzIGluIGEgY2hhcmFjdGVyLiBUaGUgdGltZSBnYXAgYmV0d2Vlbgog ICAgIC8vIGxhc3QgY2hhcmFjdGVyIGFuZCB0aGUgY3VycmVudCBjaGFyYWN0ZXIgaXMgdXNlZCB0 byBpbmRpY2F0ZSB3aGV0aGVyCiAgICAgLy8gdXNlciB0eXBlZCBpbiBhIHN0cmluZyBvciBqdXN0 IGEgY2hhcmFjdGVyIGFzIHRoZSBzZWFyY2ggcHJlZml4LgotICAgIGlmIChpc0NoYXJhY3RlclR5 cGVFdmVudChldmVudCkpCi0gICAgICAgIG1fbGFzdENoYXJUaW1lID0gbm93OworICAgIG1fbGFz dENoYXJUaW1lID0gbm93OwogCiAgICAgVUNoYXIgYyA9IGV2ZW50LndpbmRvd3NWaXJ0dWFsS2V5 Q29kZSgpOwogCg==