28204 2009-08-11 17:52:02 -0700 Not possible to build WebCore+V8 with -fno-exceptions on Mac 2009-08-12 12:06:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mark webkit-unassigned abarth eric oldest_to_newest 139182 0 mark 2009-08-11 17:52:02 -0700 I'm turning off C++ exception support in the Mac Chromium build. Note that it's already off in the Apple build. WebCore with V8 doesn't currently build with -fno-exceptions on the Mac because of the following snippet in WebCorePrefix.h, the prefix header implicitly included in every other file in the Mac WebCore build: /* Work around a bug with C++ library that screws up Objective-C++ when exception support is disabled. */ #if defined(__APPLE__) #undef try #undef catch #endif When exceptions are disabled, the C++ STL provides backup definitions for |try| and |catch| to allow exception-ready C++ code to build in the absence of language support for |try| and |catch|. From /usr/include/c++/4.0.0/exception_defines.h: #ifndef __EXCEPTIONS // Iff -fno-exceptions, transform error handling code to work without it. # define try if (true) # define catch(X) if (false) g++ defines __EXCEPTIONS only when exception support is enabled; it is undefined when building with -fno-exceptions. exception_defines.h is included in WebCorePrefix.h indirectly by its inclusion of <algorithm>. WebCorePrefix.h is therefore effective at blocking the STL's definitions of |try| and |catch|. This becomes a problem when a file in the WebCore build later attempts to include a bit of the STL that uses exceptions. This happens during the V8 build, when bindings/v8/V8Proxy.h bring in additional bits of STL, <iterator> and <list>. The exception_defines.h |try| and |catch| fallback macros are no longer defined, which results in a build failure. My solution to this problem is to #undef these macros only when building Objective-C[++] code, and to leave the STL definitions intact when building C++ code that's not also Objective. 139186 1 34623 mark 2009-08-11 17:55:39 -0700 Created attachment 34623 Only undefine |try| and |catch| when building Objective-C[++] 139189 2 34623 darin 2009-08-11 17:57:57 -0700 Comment on attachment 34623 Only undefine |try| and |catch| when building Objective-C[++] > +/* When C++ exceptions are disabled, the C++ STL defines |try| and |catch| to > + * allow C++ code that expects exceptions to build. These definitions We use one space after a period, not two. It would be nice to have your comment follow that rule. I think the use of the term STL in this comment is a little dated. That's really not the name for it any more. This is definitely a bug in the C++ library, but one that the folks who maintain it have declined to fix. 139191 3 34626 mark 2009-08-11 18:01:35 -0700 Created attachment 34626 Comments updated 139194 4 34627 mark 2009-08-11 18:11:15 -0700 Created attachment 34627 Fix "Reviewed by". 139399 5 34627 eric 2009-08-12 10:30:20 -0700 Comment on attachment 34627 Fix "Reviewed by". Rejecting patch 34627 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1 139409 6 34627 eric 2009-08-12 10:38:33 -0700 Comment on attachment 34627 Fix "Reviewed by". fast/layers/video-layer.html -> failed media/audio-delete-while-step-button-clicked.html -> failed media/video-controls-transformed.html -> failed media/video-controls-zoomed.html -> failed Test failures caused this regression. I don't think they were caused by this patch. Adding back to commit queue. 139456 7 34627 eric 2009-08-12 11:49:29 -0700 Comment on attachment 34627 Fix "Reviewed by". Rejecting patch 34627 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None 139463 8 eric 2009-08-12 12:06:00 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCorePrefix.h Committed r47131 M WebCore/ChangeLog M WebCore/WebCorePrefix.h r47131 = e75e0df501e7cf6f156c0582d8339c21f55de469 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47131 34623 2009-08-11 17:55:39 -0700 2009-08-11 18:01:35 -0700 Only undefine |try| and |catch| when building Objective-C[++] webkit.28204.1.patch text/plain 1445 mark SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzA3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDgtMTEgIE1hcmsgTWVudG92YWkgIDxtYXJrQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgyMDQKKyAgICAgICAgQWxs b3cgQysrIGV4Y2VwdGlvbnMgdG8gYmUgZGlzYWJsZWQgaW4gV2ViQ29yZSdzIFY4IE1hYyBidWls ZC4KKworICAgICAgICAqIFdlYkNvcmVQcmVmaXguaDoKKyAgICAgICAgT25seSB1bmRlZmluZSB8 dHJ5fCBhbmQgfGNhdGNofCB3aGVuIGJ1aWxkaW5nIE9iamVjdGl2ZS1DWysrXSwKKyAgICAgICAg bGVhdmluZyB0aGUgU1RMIGRlZmluaXRpb25zIGludGFjdCBmb3IgQysrLgorCiAyMDA5LTA4LTEx ICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIFRyZWF0LgpJbmRleDogV2ViQ29yZS9XZWJDb3JlUHJlZml4LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9XZWJDb3JlUHJlZml4LmgJKHJldmlzaW9uIDQ3MDc0KQorKysgV2ViQ29y ZS9XZWJDb3JlUHJlZml4LmgJKHdvcmtpbmcgY29weSkKQEAgLTEyNSw4ICsxMjUsMTEgQEAKICNk ZWZpbmUgZGVsZXRlICgiaWYgeW91IHVzZSBuZXcvZGVsZXRlIG1ha2Ugc3VyZSB0byBpbmNsdWRl IGNvbmZpZy5oIGF0IHRoZSB0b3Agb2YgdGhlIGZpbGUiKCkpIAogI2VuZGlmCiAKLS8qIFdvcmsg YXJvdW5kIGEgYnVnIHdpdGggQysrIGxpYnJhcnkgdGhhdCBzY3Jld3MgdXAgT2JqZWN0aXZlLUMr KyB3aGVuIGV4Y2VwdGlvbiBzdXBwb3J0IGlzIGRpc2FibGVkLiAqLwotI2lmIGRlZmluZWQoX19B UFBMRV9fKQorLyogV2hlbiBDKysgZXhjZXB0aW9ucyBhcmUgZGlzYWJsZWQsIHRoZSBDKysgU1RM IGRlZmluZXMgfHRyeXwgYW5kIHxjYXRjaHwgdG8KKyAqIGFsbG93IEMrKyBjb2RlIHRoYXQgZXhw ZWN0cyBleGNlcHRpb25zIHRvIGJ1aWxkLiAgVGhlc2UgZGVmaW5pdGlvbnMKKyAqIGludGVyZmVy ZSB3aXRoIE9iamVjdGl2ZS1DKysgdXNlcyBvZiBPYmplY3RpdmUtQyBleGNlcHRpb24gaGFuZGxl cnMsIHdoaWNoCisgKiB1c2UgfEB0cnl8IGFuZCB8QGNhdGNofC4gIEFzIGEgd29ya2Fyb3VuZCwg dW5kZWZpbmUgdGhlc2UgbWFjcm9zLiAqLworI2lmZGVmIF9fT0JKQ19fCiAjdW5kZWYgdHJ5CiAj dW5kZWYgY2F0Y2gKICNlbmRpZgo= 34626 2009-08-11 18:01:35 -0700 2009-08-11 18:11:28 -0700 Comments updated webkit.28204.2.patch text/plain 1455 mark SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzA3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDgtMTEgIE1hcmsgTWVudG92YWkgIDxtYXJrQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgyMDQKKyAgICAgICAgQWxs b3cgQysrIGV4Y2VwdGlvbnMgdG8gYmUgZGlzYWJsZWQgaW4gV2ViQ29yZSdzIFY4IE1hYyBidWls ZC4KKworICAgICAgICAqIFdlYkNvcmVQcmVmaXguaDoKKyAgICAgICAgT25seSB1bmRlZmluZSB8 dHJ5fCBhbmQgfGNhdGNofCB3aGVuIGJ1aWxkaW5nIE9iamVjdGl2ZS1DWysrXSwKKyAgICAgICAg bGVhdmluZyB0aGUgQysrIGxpYnJhcnkgZGVmaW5pdGlvbnMgaW50YWN0IGZvciBDKysuCisKIDIw MDktMDgtMTEgIFBldGVyIEthc3RpbmcgIDxwa2FzdGluZ0Bnb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEFkYW0gVHJlYXQuCkluZGV4OiBXZWJDb3JlL1dlYkNvcmVQcmVmaXguaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmVQcmVmaXguaAkocmV2aXNpb24gNDcwNzQpCisr KyBXZWJDb3JlL1dlYkNvcmVQcmVmaXguaAkod29ya2luZyBjb3B5KQpAQCAtMTI1LDggKzEyNSwx MSBAQAogI2RlZmluZSBkZWxldGUgKCJpZiB5b3UgdXNlIG5ldy9kZWxldGUgbWFrZSBzdXJlIHRv IGluY2x1ZGUgY29uZmlnLmggYXQgdGhlIHRvcCBvZiB0aGUgZmlsZSIoKSkgCiAjZW5kaWYKIAot LyogV29yayBhcm91bmQgYSBidWcgd2l0aCBDKysgbGlicmFyeSB0aGF0IHNjcmV3cyB1cCBPYmpl Y3RpdmUtQysrIHdoZW4gZXhjZXB0aW9uIHN1cHBvcnQgaXMgZGlzYWJsZWQuICovCi0jaWYgZGVm aW5lZChfX0FQUExFX18pCisvKiBXaGVuIEMrKyBleGNlcHRpb25zIGFyZSBkaXNhYmxlZCwgdGhl IEMrKyBsaWJyYXJ5IGRlZmluZXMgfHRyeXwgYW5kIHxjYXRjaHwKKyAqIHRvIGFsbG93IEMrKyBj b2RlIHRoYXQgZXhwZWN0cyBleGNlcHRpb25zIHRvIGJ1aWxkLiBUaGVzZSBkZWZpbml0aW9ucwor ICogaW50ZXJmZXJlIHdpdGggT2JqZWN0aXZlLUMrKyB1c2VzIG9mIE9iamVjdGl2ZS1DIGV4Y2Vw dGlvbiBoYW5kbGVycywgd2hpY2gKKyAqIHVzZSB8QHRyeXwgYW5kIHxAY2F0Y2h8LiBBcyBhIHdv cmthcm91bmQsIHVuZGVmaW5lIHRoZXNlIG1hY3Jvcy4gKi8KKyNpZmRlZiBfX09CSkNfXwogI3Vu ZGVmIHRyeQogI3VuZGVmIGNhdGNoCiAjZW5kaWYK 34627 2009-08-11 18:11:15 -0700 2009-08-12 11:49:29 -0700 Fix "Reviewed by". webkit.28204.3.patch text/plain 1452 mark SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzA3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDgtMTEgIE1hcmsgTWVudG92YWkgIDxtYXJrQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgyMDQKKyAgICAgICAgQWxsb3cg QysrIGV4Y2VwdGlvbnMgdG8gYmUgZGlzYWJsZWQgaW4gV2ViQ29yZSdzIFY4IE1hYyBidWlsZC4K KworICAgICAgICAqIFdlYkNvcmVQcmVmaXguaDoKKyAgICAgICAgT25seSB1bmRlZmluZSB8dHJ5 fCBhbmQgfGNhdGNofCB3aGVuIGJ1aWxkaW5nIE9iamVjdGl2ZS1DWysrXSwKKyAgICAgICAgbGVh dmluZyB0aGUgQysrIGxpYnJhcnkgZGVmaW5pdGlvbnMgaW50YWN0IGZvciBDKysuCisKIDIwMDkt MDgtMTEgIFBldGVyIEthc3RpbmcgIDxwa2FzdGluZ0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFkYW0gVHJlYXQuCkluZGV4OiBXZWJDb3JlL1dlYkNvcmVQcmVmaXguaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmVQcmVmaXguaAkocmV2aXNpb24gNDcwNzQpCisrKyBX ZWJDb3JlL1dlYkNvcmVQcmVmaXguaAkod29ya2luZyBjb3B5KQpAQCAtMTI1LDggKzEyNSwxMSBA QAogI2RlZmluZSBkZWxldGUgKCJpZiB5b3UgdXNlIG5ldy9kZWxldGUgbWFrZSBzdXJlIHRvIGlu Y2x1ZGUgY29uZmlnLmggYXQgdGhlIHRvcCBvZiB0aGUgZmlsZSIoKSkgCiAjZW5kaWYKIAotLyog V29yayBhcm91bmQgYSBidWcgd2l0aCBDKysgbGlicmFyeSB0aGF0IHNjcmV3cyB1cCBPYmplY3Rp dmUtQysrIHdoZW4gZXhjZXB0aW9uIHN1cHBvcnQgaXMgZGlzYWJsZWQuICovCi0jaWYgZGVmaW5l ZChfX0FQUExFX18pCisvKiBXaGVuIEMrKyBleGNlcHRpb25zIGFyZSBkaXNhYmxlZCwgdGhlIEMr KyBsaWJyYXJ5IGRlZmluZXMgfHRyeXwgYW5kIHxjYXRjaHwKKyAqIHRvIGFsbG93IEMrKyBjb2Rl IHRoYXQgZXhwZWN0cyBleGNlcHRpb25zIHRvIGJ1aWxkLiBUaGVzZSBkZWZpbml0aW9ucworICog aW50ZXJmZXJlIHdpdGggT2JqZWN0aXZlLUMrKyB1c2VzIG9mIE9iamVjdGl2ZS1DIGV4Y2VwdGlv biBoYW5kbGVycywgd2hpY2gKKyAqIHVzZSB8QHRyeXwgYW5kIHxAY2F0Y2h8LiBBcyBhIHdvcmth cm91bmQsIHVuZGVmaW5lIHRoZXNlIG1hY3Jvcy4gKi8KKyNpZmRlZiBfX09CSkNfXwogI3VuZGVm IHRyeQogI3VuZGVmIGNhdGNoCiAjZW5kaWYK