28202 2009-08-11 16:49:13 -0700 REGRESSION: run-webkit-tests --quiet hangs 2009-08-12 09:17:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned oldest_to_newest 139167 0 eric 2009-08-11 16:49:13 -0700 run-webkit-tests --quiet hangs My perl-fu is not strong. :( 139168 1 eric 2009-08-11 16:49:35 -0700 I talked this out with "buu" in #perl, and this was the best we came up with. 139169 2 34614 eric 2009-08-11 16:50:50 -0700 Created attachment 34614 Patch v1 139344 3 eric 2009-08-12 09:11:44 -0700 I'm going to check this in w/o review to fix the regression that --quiet now hangs. (Alternatively I could roll out my other patch which caused it to hang.) If anyone has suggestions as to how I should improve this code, I'm happy to change it further. This code is specifically trying to avoid turning the args array back into a string. Perl doesn't seem to have an elegant way to deal with an args array *and* route stderr to /dev/null. Another way I could handle this would be to override the parent's stdout/stderr before running the normal "system" call. But that's also pretty nasty (although slightly less code). 139346 4 eric 2009-08-12 09:17:28 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests Committed r47109 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests r47109 = 86eae88a818613b99c22db8d9631abf4c36eca43 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47109 34614 2009-08-11 16:50:50 -0700 2009-08-12 09:17:35 -0700 Patch v1 bug-28202-20090811165050.patch text/plain 1921 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkODc1YTRiLi44MjNlMWVlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTcgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBydW4td2Via2l0LXRlc3Rz IC0tcXVpZXQgaGFuZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI4MjAyCisKKyAgICAgICAgRG8gYSBodWdlIGRhbmNlIHRvIGdldCBvcGVuMyB0byBw aXBlIHRvIC9kZXYvbnVsbCB3L28gYmxvY2tpbmcuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13 ZWJraXQtdGVzdHM6CisKKzIwMDktMDgtMTEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIGJ1Z3pp bGxhLXRvb2wgOiB2YXJpb3VzIGltcHJvdmVtZW50cyBmb3IgcnVubmluZyB0aGUgY29tbWl0LXF1 ZXVlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODE5 OQogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKaW5kZXggN2FhZWFhOC4uMWY5MDhl YyAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCisrKyBi L1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwpAQCAtMjk5LDE3ICsyOTksMjcg QEAgY2hkaXJXZWJLaXQoKTsKIGlmICghZGVmaW5lZCgkcm9vdCkpIHsKICAgICBwcmludCBTVERF UlIgIlJ1bm5pbmcgYnVpbGQtZHVtcHJlbmRlcnRyZWVcbiI7CiAKKyAgICBsb2NhbCAqREVWTlVM TDsKICAgICBteSAoJGNoaWxkSW4sICRjaGlsZE91dCwgJGNoaWxkRXJyKTsKLSAgICBpZiAoISRx dWlldCkgeworICAgIGlmICgkcXVpZXQpIHsKKyAgICAgICAgb3BlbihERVZOVUxMLCAiPiIsIEZp bGU6OlNwZWMtPmRldm51bGwpIG9yIGRpZSAiRmFpbGVkIHRvIG9wZW4gL2Rldi9udWxsIjsKKyAg ICAgICAgJGNoaWxkT3V0ID0gIj4mREVWTlVMTCI7CisgICAgICAgICRjaGlsZEVyciA9ICI+JkRF Vk5VTEwiOworICAgIH0gZWxzZSB7CiAgICAgICAgICMgV2hlbiBub3QgcXVpZXQsIGxldCB0aGUg Y2hpbGQgdXNlIG91ciBzdGRvdXQvc3RkZXJyLgogICAgICAgICAkY2hpbGRPdXQgPSAiPiZTVERP VVQiOwogICAgICAgICAkY2hpbGRFcnIgPSAiPiZTVERFUlIiOwogICAgIH0KIAogICAgIG15IEBh cmdzID0gYXJndW1lbnRzRm9yQ29uZmlndXJhdGlvbigpOwotICAgIG15ICRidWlsZFByb2Nlc3Mg PSBvcGVuMygkY2hpbGRJbiwgJGNoaWxkT3V0LCAkY2hpbGRFcnIsICJXZWJLaXRUb29scy9TY3Jp cHRzL2J1aWxkLWR1bXByZW5kZXJ0cmVlIiwgQGFyZ3MpOworICAgIG15ICRidWlsZFByb2Nlc3Mg PSBvcGVuMygkY2hpbGRJbiwgJGNoaWxkT3V0LCAkY2hpbGRFcnIsICJXZWJLaXRUb29scy9TY3Jp cHRzL2J1aWxkLWR1bXByZW5kZXJ0cmVlIiwgQGFyZ3MpIG9yIGRpZSAiRmFpbGVkIHRvIHJ1biBi dWlsZC1kdW1wcmVuZGVydHJlZSI7CisgICAgY2xvc2UoJGNoaWxkSW4pOwogICAgIHdhaXRwaWQg JGJ1aWxkUHJvY2VzcywgMDsKICAgICBteSAkYnVpbGRSZXN1bHQgPSAkPzsKKyAgICBjbG9zZSgk Y2hpbGRPdXQpOworICAgIGNsb3NlKCRjaGlsZEVycik7CisKKyAgICBjbG9zZSBERVZOVUxMIGlm ICgkcXVpZXQpOwogCiAgICAgaWYgKCRidWlsZFJlc3VsdCkgewogICAgICAgICBwcmludCBTVERF UlIgIkNvbXBpbGluZyBEdW1wUmVuZGVyVHJlZSBmYWlsZWQhXG4iOw==