282018 2024-10-23 17:13:41 -0700 [FFC] Move resolveNonLogicalValues to FlexFormattingUtils 2024-10-25 05:35:17 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 2070249 0 zalan 2024-10-23 17:13:41 -0700 ssia 2070250 1 473027 zalan 2024-10-23 17:15:48 -0700 Created attachment 473027 [fast-cq]Patch 2070547 2 ews-feeder 2024-10-25 05:34:20 -0700 Committed 285698@main (bb00023f390a): <https://commits.webkit.org/285698@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 473027. 2070548 3 webkit-bug-importer 2024-10-25 05:35:17 -0700 <rdar://problem/138627970> 473027 2024-10-23 17:15:48 -0700 2024-10-25 05:34:22 -0700 [fast-cq]Patch bug-282018-20241023171547.patch text/plain 7311 zalan RnJvbSAyMzQ4ZTE0NDQxYmY4MTAxOGFlZDEwNDBmMDMzNjc4YTI4Y2RjOTdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFdlZCwgMjMgT2N0IDIwMjQgMTc6MTM6NDkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBbRkZDXSBN b3ZlIHJlc29sdmVOb25Mb2dpY2FsVmFsdWVzIHRvIEZsZXhGb3JtYXR0aW5nVXRpbHMKIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODIwMTgKClJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRz L2ZsZXgvRmxleEZvcm1hdHRpbmdVdGlscy5jcHA6CihXZWJDb3JlOjpMYXlvdXQ6OkZsZXhGb3Jt YXR0aW5nVXRpbHM6OmxvZ2ljYWxKdXN0aWZ5Q29udGVudFBvc2l0aW9uVmFsdWUpOgooV2ViQ29y ZTo6TGF5b3V0OjpGbGV4Rm9ybWF0dGluZ1V0aWxzOjppc01haW5BeGlzUGFyYWxsZWxXaXRoTGVm dFJpZ2h0QXhpcyk6IERlbGV0ZWQuCihXZWJDb3JlOjpMYXlvdXQ6OkZsZXhGb3JtYXR0aW5nVXRp bHM6OmlzSW5saW5lRGlyZWN0aW9uUlRMKTogRGVsZXRlZC4KKiBTb3VyY2UvV2ViQ29yZS9sYXlv dXQvZm9ybWF0dGluZ0NvbnRleHRzL2ZsZXgvRmxleEZvcm1hdHRpbmdVdGlscy5oOgoqIFNvdXJj ZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvZmxleC9GbGV4TGF5b3V0LmNwcDoK KFdlYkNvcmU6OkxheW91dDo6RmxleExheW91dDo6aGFuZGxlTWFpbkF4aXNBbGlnbm1lbnQgY29u c3QpOgotLS0KIC4uLi9mbGV4L0ZsZXhGb3JtYXR0aW5nVXRpbHMuY3BwICAgICAgICAgICAgICB8 IDI1ICsrKysrKysrKysrLS0tLS0tLS0KIC4uLi9mbGV4L0ZsZXhGb3JtYXR0aW5nVXRpbHMuaCAg ICAgICAgICAgICAgICB8ICA0ICstLQogLi4uL2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhM YXlvdXQuY3BwICAgIHwgMTUgKy0tLS0tLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0 aW9ucygrKSwgMjYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhGb3JtYXR0aW5nVXRpbHMuY3BwIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhGb3JtYXR0aW5n VXRpbHMuY3BwCmluZGV4IGU4OGY3NmU4NThhNS4uOTEyYTg4ZGUwZTk0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2ZsZXgvRmxleEZvcm1hdHRp bmdVdGlscy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0 cy9mbGV4L0ZsZXhGb3JtYXR0aW5nVXRpbHMuY3BwCkBAIC00OCwxOSArNDgsMjQgQEAgYm9vbCBG bGV4Rm9ybWF0dGluZ1V0aWxzOjppc01haW5BeGlzUGFyYWxsZWxXaXRoSW5saW5lQXhpcyhjb25z dCBFbGVtZW50Qm94JiBmbGUKICAgICByZXR1cm4gKGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlICYm IChmbGV4RGlyZWN0aW9uID09IEZsZXhEaXJlY3Rpb246OlJvdyB8fCBmbGV4RGlyZWN0aW9uID09 IEZsZXhEaXJlY3Rpb246OlJvd1JldmVyc2UpKSB8fCAoIWlzSG9yaXpvbnRhbFdyaXRpbmdNb2Rl ICYmIChmbGV4RGlyZWN0aW9uID09IEZsZXhEaXJlY3Rpb246OkNvbHVtbiB8fCBmbGV4RGlyZWN0 aW9uID09IEZsZXhEaXJlY3Rpb246OkNvbHVtblJldmVyc2UpKTsKIH0KIAotYm9vbCBGbGV4Rm9y bWF0dGluZ1V0aWxzOjppc01haW5BeGlzUGFyYWxsZWxXaXRoTGVmdFJpZ2h0QXhpcyhjb25zdCBF bGVtZW50Qm94JiBmbGV4Q29udGFpbmVyKQorQ29udGVudFBvc2l0aW9uIEZsZXhGb3JtYXR0aW5n VXRpbHM6OmxvZ2ljYWxKdXN0aWZ5Q29udGVudFBvc2l0aW9uKGNvbnN0IEVsZW1lbnRCb3gmIGZs ZXhDb250YWluZXIsIENvbnRlbnRQb3NpdGlvbiBqdXN0aWZ5Q29udGVudFBvc2l0aW9uKQogewot ICAgIC8vIEN1cnJlbnRseSwgdGhlIG9ubHkgY2FzZSB3aGVyZSB0aGUgcHJvcGVydHnigJlzIGF4 aXMgaXMgbm90IHBhcmFsbGVsIHdpdGggZWl0aGVyIGxlZnTihpRyaWdodCBheGlzIGlzIGluIGEg Y29sdW1uIGZsZXhib3guCi0gICAgLy8gaHR0cHM6Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzcy1hbGln bi8jcG9zaXRpb25hbC12YWx1ZXMKICAgICBBU1NFUlQoZmxleENvbnRhaW5lci5pc0ZsZXhCb3go KSk7Ci0gICAgYXV0byBmbGV4RGlyZWN0aW9uID0gZmxleENvbnRhaW5lci5zdHlsZSgpLmZsZXhE aXJlY3Rpb24oKTsKLSAgICByZXR1cm4gZmxleERpcmVjdGlvbiA9PSBGbGV4RGlyZWN0aW9uOjpS b3cgfHwgZmxleERpcmVjdGlvbiA9PSBGbGV4RGlyZWN0aW9uOjpSb3dSZXZlcnNlOwotfQogCi1i b29sIEZsZXhGb3JtYXR0aW5nVXRpbHM6OmlzSW5saW5lRGlyZWN0aW9uUlRMKGNvbnN0IEVsZW1l bnRCb3gmIGZsZXhDb250YWluZXIpCi17Ci0gICAgQVNTRVJUKGZsZXhDb250YWluZXIuaXNGbGV4 Qm94KCkpOwotICAgIHJldHVybiAhZmxleENvbnRhaW5lci53cml0aW5nTW9kZSgpLmlzTG9naWNh bExlZnRJbmxpbmVTdGFydCgpOworICAgIGlmIChqdXN0aWZ5Q29udGVudFBvc2l0aW9uICE9IENv bnRlbnRQb3NpdGlvbjo6UmlnaHQgJiYganVzdGlmeUNvbnRlbnRQb3NpdGlvbiAhPSBDb250ZW50 UG9zaXRpb246OkxlZnQpCisgICAgICAgIHJldHVybiBqdXN0aWZ5Q29udGVudFBvc2l0aW9uOwor CisgICAgYXV0byYgZmxleENvbnRhaW5lclN0eWxlID0gZmxleENvbnRhaW5lci5zdHlsZSgpOwor ICAgIC8vIElmIHRoZSBwcm9wZXJ0eSdzIGF4aXMgaXMgbm90IHBhcmFsbGVsIHdpdGggZWl0aGVy IGxlZnQ8LT5yaWdodCBheGlzLCB0aGlzIHZhbHVlIGJlaGF2ZXMgYXMgc3RhcnQgKGh0dHBzOi8v ZHJhZnRzLmNzc3dnLm9yZy9jc3MtYWxpZ24vI3Bvc2l0aW9uYWwtdmFsdWVzKQorICAgIC8vIEN1 cnJlbnRseSwgdGhlIG9ubHkgY2FzZSB3aGVyZSB0aGUgcHJvcGVydHnigJlzIGF4aXMgaXMgbm90 IHBhcmFsbGVsIHdpdGggZWl0aGVyIGxlZnQ8LT5yaWdodCBheGlzIGlzIGluIGEgY29sdW1uIGZs ZXhib3guCisgICAgLy8gaHR0cHM6Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzcy1hbGlnbi8jcG9zaXRp b25hbC12YWx1ZXMKKyAgICBpZiAoZmxleENvbnRhaW5lclN0eWxlLmlzQ29sdW1uRmxleERpcmVj dGlvbigpICYmIGZsZXhDb250YWluZXJTdHlsZS53cml0aW5nTW9kZSgpLmlzSG9yaXpvbnRhbCgp KQorICAgICAgICByZXR1cm4gQ29udGVudFBvc2l0aW9uOjpTdGFydDsKKworICAgIGF1dG8gaXNM ZWZ0VG9SaWdodEluQXhpc0RpcmVjdGlvbiA9IGZsZXhDb250YWluZXJTdHlsZS5pc1Jvd0ZsZXhE aXJlY3Rpb24oKSA/IGZsZXhDb250YWluZXJTdHlsZS53cml0aW5nTW9kZSgpLmlzTG9naWNhbExl ZnRJbmxpbmVTdGFydCgpIDogZmxleENvbnRhaW5lclN0eWxlLndyaXRpbmdNb2RlKCkuaXNCbG9j a0xlZnRUb1JpZ2h0KCk7CisgICAgaWYgKGp1c3RpZnlDb250ZW50UG9zaXRpb24gPT0gQ29udGVu dFBvc2l0aW9uOjpMZWZ0KQorICAgICAgICByZXR1cm4gaXNMZWZ0VG9SaWdodEluQXhpc0RpcmVj dGlvbiA/IENvbnRlbnRQb3NpdGlvbjo6U3RhcnQgOiBDb250ZW50UG9zaXRpb246OkVuZDsKKyAg ICByZXR1cm4gaXNMZWZ0VG9SaWdodEluQXhpc0RpcmVjdGlvbiA/IENvbnRlbnRQb3NpdGlvbjo6 RW5kIDogQ29udGVudFBvc2l0aW9uOjpTdGFydDsKIH0KIAogYm9vbCBGbGV4Rm9ybWF0dGluZ1V0 aWxzOjppc01haW5SZXZlcnNlZFRvQ29udGVudERpcmVjdGlvbihjb25zdCBFbGVtZW50Qm94JiBm bGV4Q29udGFpbmVyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRp bmdDb250ZXh0cy9mbGV4L0ZsZXhGb3JtYXR0aW5nVXRpbHMuaCBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9mb3JtYXR0aW5nQ29udGV4dHMvZmxleC9GbGV4Rm9ybWF0dGluZ1V0aWxzLmgKaW5kZXgg ZDkzZTliZjEzYjdhLi4wZTAxODNlZTdkN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9mb3JtYXR0aW5nQ29udGV4dHMvZmxleC9GbGV4Rm9ybWF0dGluZ1V0aWxzLmgKKysrIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhGb3JtYXR0 aW5nVXRpbHMuaApAQCAtMzksOCArMzksNiBAQCBwdWJsaWM6CiAgICAgRmxleEZvcm1hdHRpbmdV dGlscyhjb25zdCBGbGV4Rm9ybWF0dGluZ0NvbnRleHQmKTsKIAogICAgIHN0YXRpYyBib29sIGlz TWFpbkF4aXNQYXJhbGxlbFdpdGhJbmxpbmVBeGlzKGNvbnN0IEVsZW1lbnRCb3gmIGZsZXhDb250 YWluZXIpOwotICAgIHN0YXRpYyBib29sIGlzTWFpbkF4aXNQYXJhbGxlbFdpdGhMZWZ0UmlnaHRB eGlzKGNvbnN0IEVsZW1lbnRCb3gmIGZsZXhDb250YWluZXIpOwotICAgIHN0YXRpYyBib29sIGlz SW5saW5lRGlyZWN0aW9uUlRMKGNvbnN0IEVsZW1lbnRCb3gmIGZsZXhDb250YWluZXIpOwogICAg IHN0YXRpYyBib29sIGlzTWFpblJldmVyc2VkVG9Db250ZW50RGlyZWN0aW9uKGNvbnN0IEVsZW1l bnRCb3gmIGZsZXhDb250YWluZXIpOwogICAgIHN0YXRpYyBib29sIGFyZUZsZXhMaW5lc1JldmVy c2VkSW5Dcm9zc0F4aXMoY29uc3QgRWxlbWVudEJveCYgZmxleENvbnRhaW5lcik7CiAKQEAgLTQ4 LDYgKzQ2LDggQEAgcHVibGljOgogICAgIHN0YXRpYyBMYXlvdXRVbml0IG1haW5BeGlzR2FwVmFs dWUoY29uc3QgRWxlbWVudEJveCYgZmxleENvbnRhaW5lciwgTGF5b3V0VW5pdCBmbGV4Q29udGFp bmVyQ29udGVudEJveFdpZHRoKTsKICAgICBzdGF0aWMgTGF5b3V0VW5pdCBjcm9zc0F4aXNHYXBW YWx1ZShjb25zdCBFbGVtZW50Qm94JiBmbGV4Q29udGFpbmVyLCBMYXlvdXRVbml0IGZsZXhDb250 YWluZXJDb250ZW50Qm94SGVpZ2h0KTsKIAorICAgIHN0YXRpYyBDb250ZW50UG9zaXRpb24gbG9n aWNhbEp1c3RpZnlDb250ZW50UG9zaXRpb24oY29uc3QgRWxlbWVudEJveCYgZmxleENvbnRhaW5l ciwgQ29udGVudFBvc2l0aW9uKTsKKwogICAgIExheW91dFVuaXQgdXNlZE1pbmltdW1TaXplSW5N YWluQXhpcyhjb25zdCBMb2dpY2FsRmxleEl0ZW0mKSBjb25zdDsKICAgICBzdGQ6Om9wdGlvbmFs PExheW91dFVuaXQ+IHVzZWRNYXhpbXVtU2l6ZUluTWFpbkF4aXMoY29uc3QgTG9naWNhbEZsZXhJ dGVtJikgY29uc3Q7CiAgICAgTGF5b3V0VW5pdCB1c2VkTWF4Q29udGVudFNpemVJbk1haW5BeGlz KGNvbnN0IExvZ2ljYWxGbGV4SXRlbSYpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhMYXlvdXQuY3BwIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhMYXlvdXQuY3BwCmlu ZGV4IDYwMDhjNWM2Nzc0NS4uYzlmNDM5YWFiNDYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2ZsZXgvRmxleExheW91dC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhMYXlvdXQuY3Bw CkBAIC01ODQsMTkgKzU4NCw2IEBAIEZsZXhMYXlvdXQ6OlBvc2l0aW9uQW5kTWFyZ2luc0xpc3Qg RmxleExheW91dDo6aGFuZGxlTWFpbkF4aXNBbGlnbm1lbnQoTGF5b3V0VW5pCiAgICAgICAgIH07 CiAgICAgICAgIHNldEZhbGxiYWNrVmFsdWVzSWZBcHBsaWNhYmxlKCk7CiAKLSAgICAgICAgYXV0 byByZXNvbHZlTm9uTG9naWNhbFZhbHVlcyA9IFsmXSB7Ci0gICAgICAgICAgICBpZiAoanVzdGlm eUNvbnRlbnRQb3NpdGlvbiAhPSBDb250ZW50UG9zaXRpb246OlJpZ2h0ICYmIGp1c3RpZnlDb250 ZW50UG9zaXRpb24gIT0gQ29udGVudFBvc2l0aW9uOjpMZWZ0KQotICAgICAgICAgICAgICAgIHJl dHVybjsKLSAgICAgICAgICAgIGlmICghRmxleEZvcm1hdHRpbmdVdGlsczo6aXNNYWluQXhpc1Bh cmFsbGVsV2l0aExlZnRSaWdodEF4aXMoZmxleENvbnRhaW5lcigpKSkgewotICAgICAgICAgICAg ICAgIC8vIElmIHRoZSBwcm9wZXJ0eSdzIGF4aXMgaXMgbm90IHBhcmFsbGVsIHdpdGggZWl0aGVy IGxlZnQ8LT5yaWdodCBheGlzLCB0aGlzIHZhbHVlIGJlaGF2ZXMgYXMgc3RhcnQgKGh0dHBzOi8v ZHJhZnRzLmNzc3dnLm9yZy9jc3MtYWxpZ24vI3Bvc2l0aW9uYWwtdmFsdWVzKQotICAgICAgICAg ICAgICAgIGp1c3RpZnlDb250ZW50UG9zaXRpb24gPSBDb250ZW50UG9zaXRpb246OlN0YXJ0Owot ICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAgIH0KLSAgICAgICAgICAgIGF1dG8g bGVmdFJpZ2h0TmVlZHNGbGlwcGluZyA9IEZsZXhGb3JtYXR0aW5nVXRpbHM6OmlzSW5saW5lRGly ZWN0aW9uUlRMKGZsZXhDb250YWluZXIoKSk7Ci0gICAgICAgICAgICBqdXN0aWZ5Q29udGVudFBv c2l0aW9uID0ganVzdGlmeUNvbnRlbnRQb3NpdGlvbiA9PSBDb250ZW50UG9zaXRpb246OkxlZnQg PyAoIWxlZnRSaWdodE5lZWRzRmxpcHBpbmcgPyBDb250ZW50UG9zaXRpb246OlN0YXJ0IDogQ29u dGVudFBvc2l0aW9uOjpFbmQpIDogKCFsZWZ0UmlnaHROZWVkc0ZsaXBwaW5nID8gQ29udGVudFBv c2l0aW9uOjpFbmQgOiBDb250ZW50UG9zaXRpb246OlN0YXJ0KTsKLSAgICAgICAgfTsKLSAgICAg ICAgcmVzb2x2ZU5vbkxvZ2ljYWxWYWx1ZXMoKTsKLQogICAgICAgICBhdXRvIGp1c3RpZnlDb250 ZW50ID0gWyZdIHsKICAgICAgICAgICAgIC8vIDIuIEFsaWduIHRoZSBpdGVtcyBhbG9uZyB0aGUg bWFpbi1heGlzIHBlciBqdXN0aWZ5LWNvbnRlbnQuCiAgICAgICAgICAgICBhdXRvIGluaXRpYWxP ZmZzZXQgPSBbJl0gewpAQCAtNjE1LDcgKzYwMiw3IEBAIEZsZXhMYXlvdXQ6OlBvc2l0aW9uQW5k TWFyZ2luc0xpc3QgRmxleExheW91dDo6aGFuZGxlTWFpbkF4aXNBbGlnbm1lbnQoTGF5b3V0VW5p CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAg ICAgICBzd2l0Y2ggKGp1c3RpZnlDb250ZW50UG9zaXRpb24pIHsKKyAgICAgICAgICAgICAgICBz d2l0Y2ggKEZsZXhGb3JtYXR0aW5nVXRpbHM6OmxvZ2ljYWxKdXN0aWZ5Q29udGVudFBvc2l0aW9u KGZsZXhDb250YWluZXIoKSwganVzdGlmeUNvbnRlbnRQb3NpdGlvbikpIHsKICAgICAgICAgICAg ICAgICBjYXNlIENvbnRlbnRQb3NpdGlvbjo6Tm9ybWFsOgogICAgICAgICAgICAgICAgIGNhc2Ug Q29udGVudFBvc2l0aW9uOjpGbGV4U3RhcnQ6CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBM YXlvdXRVbml0IHsgfTsK