281994 2024-10-23 10:40:46 -0700 Add static_assert to spanReinterpretCast<>() to prevent unnecessary casts 2024-10-23 14:33:38 -0700 1 1 1 Unclassified WebKit Web Template Framework Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=281944 InRadar P2 Normal --- 1 ddkilzer ddkilzer webkit-bug-importer oldest_to_newest 2070146 0 ddkilzer 2024-10-23 10:40:46 -0700 Add static_assert to spanReinterpretCast<>() to prevent unnecessary casts. Idea from Darin Adler here: <https://github.com/WebKit/WebKit/pull/35601#discussion_r1811793553> This was seen once in Source/WTF/wtf/text/AtomStringImpl.cpp prior to fixing Bug 281944: ``` RefPtr<AtomStringImpl> AtomStringImpl::add(std::span<const char8_t> characters) { HashedUTF8Characters buffer { characters, computeUTF16LengthWithHash(spanReinterpretCast<const char8_t>(characters)) }; [...] ``` 2070152 1 webkit-bug-importer 2024-10-23 10:53:55 -0700 <rdar://problem/138491814> 2070163 2 ddkilzer 2024-10-23 11:35:54 -0700 Pull request: https://github.com/WebKit/WebKit/pull/35638 2070200 3 ews-feeder 2024-10-23 14:33:36 -0700 Committed 285623@main (4543cc7cb73c): <https://commits.webkit.org/285623@main> Reviewed commits have been landed. Closing PR #35638 and removing active labels.