<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>281919</bug_id>
          
          <creation_ts>2024-10-22 14:22:56 -0700</creation_ts>
          <short_desc>WebCore::DecodedHTMLEntity::span() should use std::span::first()</short_desc>
          <delta_ts>2024-10-22 19:40:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=281892</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=281917</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="David Kilzer (:ddkilzer)">ddkilzer</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2069872</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2024-10-22 14:22:56 -0700</bug_when>
    <thetext>WebCore::DecodedHTMLEntity::span() should use std::span::first().

This code currently avoids bounds checking of `m_characters` when creating std::span:

```
    constexpr std::span&lt;const UChar&gt; span() const { return { m_characters.data(), m_length }; }
```

Found by std::span clang static analysis checker under development.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2069876</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-10-22 14:25:53 -0700</bug_when>
    <thetext>&lt;rdar://problem/138431470&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2069885</commentid>
    <comment_count>2</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2024-10-22 14:32:15 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/35585</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2069969</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-10-22 19:40:04 -0700</bug_when>
    <thetext>Committed 285583@main (b8b9ecf63b67): &lt;https://commits.webkit.org/285583@main&gt;

Reviewed commits have been landed. Closing PR #35585 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>