281895 2024-10-21 22:11:25 -0700 [JSC] Refactor `Element` in `IntlDurationFormat` 2024-10-31 19:34:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sosuke webkit-unassigned webkit-bug-importer oldest_to_newest 2069753 0 sosuke 2024-10-21 22:11:25 -0700 The `Element` struct in `IntlDurationFormat`'s `collectElements` function holds the value of each duration unit as the `m_value` field. The `m_value` field is used to pass following two pieces of information to `NumberFormat`: 1. The sign bit 2. The value's type (`infinity`, `NaN`, or `integer`) The type of `m_value` is always `integer`. Therefore, the `Element` struct only needs to hold the sign bit of `m_value` rather than `m_value` itself. This patch removes the `m_value` field from the `Element` struct and adds an `m_valueSign` field instead. 2069754 1 sosuke 2024-10-21 22:12:07 -0700 Pull request: https://github.com/WebKit/WebKit/pull/35564 2071170 2 webkit-bug-importer 2024-10-28 22:12:16 -0700 <rdar://problem/138817542> 2072030 3 ews-feeder 2024-10-31 19:34:00 -0700 Committed 285992@main (831c463d4efc): <https://commits.webkit.org/285992@main> Reviewed commits have been landed. Closing PR #35564 and removing active labels.