28187 2009-08-11 14:20:10 -0700 "Double-click to add" new style button does not always show up 2009-08-12 09:43:37 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://webkit.org P2 Normal --- 1 sam webkit-unassigned eric joepeck timothy oldest_to_newest 139095 0 sam 2009-08-11 14:20:10 -0700 On http://webkit.org, the "Double-click to add" button does not show up for the body element in the elements pane. 139097 1 joepeck 2009-08-11 14:24:13 -0700 Seems to be due to "could not parse color" warnings. I'll work on this right now. 139109 2 joepeck 2009-08-11 14:39:56 -0700 Interesting. The incoming CSS of: url(/images/green.png) Has the string "green" inside it and "green" swatch is (incorrectly) made for it: http://tr.im/wdZz?grabup WebInspector.Color is invoked if there was a swatch on the massaged CSS value, and it throws an error because it cannot parse the following as a valid color: url(<ahref="http://webkit.org/images/green-background.png"class="webkit-html-resource-link"title="http://webkit.org/images/green-background.png"target="_blank">http://webkit.org/images/green-background.png</a>) Since this affects the WebKit Nightly right now I will throw up a "quick fix" patch that catches the WebInspector.Color error and therefore takes us back to the expected old behavior with the swatch still incorrectly showing. I'll then work on cleaning this up in general. 139112 3 34597 joepeck 2009-08-11 14:49:00 -0700 Created attachment 34597 Quick Fix This is the quick fix for the Nightly Build. --- I think a more optimal solution would be to avoid throwing an error at all. Instead something like WebInspector.Color.parseColor() factory method which would return either 'null' or a WebInspector.Color object. That way we won't have to worry about any throw/catch. Along with the other improvements mentioned previously, including: - swatch shows up accidentally - all swatches should be clickable to toggle colors - swatches should be clickable in shorthand properties 139368 4 34597 eric 2009-08-12 09:43:34 -0700 Comment on attachment 34597 Quick Fix Clearing flags on attachment: 34597 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/StylesSidebarPane.js Committed r47116 M WebCore/ChangeLog M WebCore/inspector/front-end/StylesSidebarPane.js r47116 = 339ebebf103c8020a3164de2578c2171389b539a (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47116 139369 5 eric 2009-08-12 09:43:37 -0700 All reviewed patches have been landed. Closing bug. 34597 2009-08-11 14:49:00 -0700 2009-08-12 09:43:34 -0700 Quick Fix quick_fix.patch text/plain 6146 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDNlZDIzNC4uMmExMzQ5NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBAQAorMjAwOS0wOC0xMSAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVjazAyQGdtYWlsLmNvbT4KKworICAgICAgICAiRG91YmxlLWNsaWNrIHRvIGFk ZCIgbmV3IHN0eWxlIGJ1dHRvbiBkb2VzIG5vdCBhbHdheXMgc2hvdyB1cCBbcXVpY2sgZml4XQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgxODcKKwor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZS51cGRh dGVUaXRsZSk6CisKIDIwMDktMDgtMTAgIEFudGhvbnkgUmljYXVkICA8cmlrQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCmluZGV4IDhhM2E2N2YuLjI3 YmMyMjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRl YmFyUGFuZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJh clBhbmUuanMKQEAgLTg5Niw2MyArODk2LDcwIEBAIFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5 VHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAgICAgICAgLy8gU2ltcGxlOiByZ2IgLT4g aHNsIC0+IG5pY2tuYW1lPyAtPiBzaG9ydGhleD8gLT4gaGV4IC0+IC4uLgogICAgICAgICAgICAg Ly8gQWR2YW5jZWQ6IHJnYmEgLT4gaHNsYSAtPiBuaWNrbmFtZT8gLT4gLi4uICAgICAgICAgICAg CiAgICAgICAgICAgICBpZiAoY29sb3JzICYmIGNvbG9ycy5sZW5ndGggPT09IDEpIHsKLSAgICAg ICAgICAgICAgICB2YXIgY29sb3IgPSBuZXcgV2ViSW5zcGVjdG9yLkNvbG9yKGh0bWxWYWx1ZSk7 Ci0gICAgICAgICAgICAgICAgc3dhdGNoLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgY2hhbmdl Q29sb3JEaXNwbGF5LCBmYWxzZSk7Ci0gICAgICAgICAgICAgICAgc3dhdGNoLmFkZEV2ZW50TGlz dGVuZXIoImRibGNsaWNrIiwgZnVuY3Rpb24oZXZlbnQpIHsKLSAgICAgICAgICAgICAgICAgICAg ZXZlbnQuc3RvcFByb3BhZ2F0aW9uKCk7Ci0gICAgICAgICAgICAgICAgfSwgZmFsc2UpOwotCi0g ICAgICAgICAgICAgICAgdmFyIG1vZGUgPSBjb2xvci5tb2RlOwotICAgICAgICAgICAgICAgIHZh ciB2YWx1ZUVsZW1lbnQgPSB0aGlzLnZhbHVlRWxlbWVudDsKLSAgICAgICAgICAgICAgICBmdW5j dGlvbiBjaGFuZ2VDb2xvckRpc3BsYXkoZXZlbnQpIHsKLQotICAgICAgICAgICAgICAgICAgICBm dW5jdGlvbiBjaGFuZ2VUbyhuZXdNb2RlLCBjb250ZW50KSB7Ci0gICAgICAgICAgICAgICAgICAg ICAgICBtb2RlID0gbmV3TW9kZTsKLSAgICAgICAgICAgICAgICAgICAgICAgIHZhbHVlRWxlbWVu dC50ZXh0Q29udGVudCA9IGNvbnRlbnQ7Ci0gICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAg ICAgICAgICB0cnkgeworICAgICAgICAgICAgICAgICAgICB2YXIgY29sb3IgPSBuZXcgV2ViSW5z cGVjdG9yLkNvbG9yKGh0bWxWYWx1ZSk7CisgICAgICAgICAgICAgICAgfSBjYXRjaChlKSB7Cisg ICAgICAgICAgICAgICAgICAgIHZhciBjb2xvciA9IG51bGw7CisgICAgICAgICAgICAgICAgfQog Ci0gICAgICAgICAgICAgICAgICAgIHN3aXRjaCAobW9kZSkgewotICAgICAgICAgICAgICAgICAg ICAgICAgY2FzZSAicmdiIjoKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFuZ2VUbygi aHNsIiwgY29sb3IudG9Ic2woKSk7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7 CisgICAgICAgICAgICAgICAgaWYgKGNvbG9yKSB7CisgICAgICAgICAgICAgICAgICAgIHN3YXRj aC5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIGNoYW5nZUNvbG9yRGlzcGxheSwgZmFsc2UpOwor ICAgICAgICAgICAgICAgICAgICBzd2F0Y2guYWRkRXZlbnRMaXN0ZW5lcigiZGJsY2xpY2siLCBm dW5jdGlvbihldmVudCkgeworICAgICAgICAgICAgICAgICAgICAgICAgZXZlbnQuc3RvcFByb3Bh Z2F0aW9uKCk7CisgICAgICAgICAgICAgICAgICAgIH0sIGZhbHNlKTsKIAotICAgICAgICAgICAg ICAgICAgICAgICAgY2FzZSAic2hvcnRoZXgiOgotICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNoYW5nZVRvKCJoZXgiLCBjb2xvci50b0hleCgpKTsKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICBicmVhazsKKyAgICAgICAgICAgICAgICAgICAgdmFyIG1vZGUgPSBjb2xvci5tb2RlOwor ICAgICAgICAgICAgICAgICAgICB2YXIgdmFsdWVFbGVtZW50ID0gdGhpcy52YWx1ZUVsZW1lbnQ7 CisgICAgICAgICAgICAgICAgICAgIGZ1bmN0aW9uIGNoYW5nZUNvbG9yRGlzcGxheShldmVudCkg ewogCi0gICAgICAgICAgICAgICAgICAgICAgICBjYXNlICJoZXgiOgotICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNoYW5nZVRvKCJyZ2IiLCBjb2xvci50b1JnYigpKTsKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICAgICAgICAgIGZ1bmN0aW9u IGNoYW5nZVRvKG5ld01vZGUsIGNvbnRlbnQpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICBtb2RlID0gbmV3TW9kZTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB2YWx1ZUVsZW1l bnQudGV4dENvbnRlbnQgPSBjb250ZW50OworICAgICAgICAgICAgICAgICAgICAgICAgfQogCi0g ICAgICAgICAgICAgICAgICAgICAgICBjYXNlICJuaWNrbmFtZSI6Ci0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgaWYgKGNvbG9yLnNpbXBsZSkgewotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBpZiAoY29sb3IuaGFzU2hvcnRIZXgoKSkKKyAgICAgICAgICAgICAgICAgICAgICAg IHN3aXRjaCAobW9kZSkgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNhc2UgInJnYiI6 CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNoYW5nZVRvKCJoc2wiLCBjb2xvci50 b0hzbCgpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICBjYXNlICJzaG9ydGhleCI6CisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGNoYW5nZVRvKCJoZXgiLCBjb2xvci50b0hleCgpKTsKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICBjYXNlICJoZXgiOgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFuZ2VU bygicmdiIiwgY29sb3IudG9SZ2IoKSk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGJyZWFrOworCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2FzZSAibmlja25hbWUiOgor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoY29sb3Iuc2ltcGxlKSB7CisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoY29sb3IuaGFzU2hvcnRIZXgoKSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFuZ2VUbygic2hvcnRo ZXgiLCBjb2xvci50b1Nob3J0SGV4KCkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNoYW5n ZVRvKCJoZXgiLCBjb2xvci50b0hleCgpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgfSBlbHNlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFuZ2VUbygi cmdiYSIsIGNvbG9yLnRvUmdiYSgpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg YnJlYWs7CisKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBjYXNlICJoc2wiOgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoY29sb3Iubmlja25hbWUpCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFuZ2VUbygibmlja25hbWUiLCBjb2xvci50b05p Y2tuYW1lKCkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbHNlIGlmIChjb2xv ci5oYXNTaG9ydEhleCgpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2hh bmdlVG8oInNob3J0aGV4IiwgY29sb3IudG9TaG9ydEhleCgpKTsKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y2hhbmdlVG8oImhleCIsIGNvbG9yLnRvSGV4KCkpOwotICAgICAgICAgICAgICAgICAgICAgICAg ICAgIH0gZWxzZQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFuZ2VUbygicmdi YSIsIGNvbG9yLnRvUmdiYSgpKTsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsK LQotICAgICAgICAgICAgICAgICAgICAgICAgY2FzZSAiaHNsIjoKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICBpZiAoY29sb3Iubmlja25hbWUpCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNoYW5nZVRvKCJuaWNrbmFtZSIsIGNvbG9yLnRvTmlja25hbWUoKSk7Ci0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgZWxzZSBpZiAoY29sb3IuaGFzU2hvcnRIZXgoKSkKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY2hhbmdlVG8oInNob3J0aGV4IiwgY29sb3IudG9T aG9ydEhleCgpKTsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNoYW5nZVRvKCJoZXgiLCBjb2xvci50b0hleCgpKTsKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKLQotICAgICAgICAgICAgICAgICAgICAg ICAgY2FzZSAicmdiYSI6Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgY2hhbmdlVG8oImhz bGEiLCBjb2xvci50b0hzbGEoKSk7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7 Ci0KLSAgICAgICAgICAgICAgICAgICAgICAgIGNhc2UgImhzbGEiOgotICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGlmIChjb2xvci5uaWNrbmFtZSkKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgY2hhbmdlVG8oIm5pY2tuYW1lIiwgY29sb3IudG9OaWNrbmFtZSgpKTsKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGNoYW5nZVRvKCJyZ2JhIiwgY29sb3IudG9SZ2JhKCkpOwotICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsK KworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNhc2UgInJnYmEiOgorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBjaGFuZ2VUbygiaHNsYSIsIGNvbG9yLnRvSHNsYSgpKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjYXNlICJoc2xhIjoKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg aWYgKGNvbG9yLm5pY2tuYW1lKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y2hhbmdlVG8oIm5pY2tuYW1lIiwgY29sb3IudG9OaWNrbmFtZSgpKTsKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY2hhbmdlVG8oInJnYmEiLCBjb2xvci50b1JnYmEoKSk7CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAg ICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQo=