<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>28183</bug_id>
          
          <creation_ts>2009-08-11 11:45:12 -0700</creation_ts>
          <short_desc>Support Visual Studio 2008 in webkitdirs.pm, pdevenv</short_desc>
          <delta_ts>2009-08-11 12:13:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Peter Kasting">pkasting</reporter>
          <assigned_to name="Peter Kasting">pkasting</assigned_to>
          <cc>sfalken</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>139054</commentid>
    <comment_count>0</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2009-08-11 11:45:12 -0700</bug_when>
    <thetext>The checked-in .sln files are VS2005 and don&apos;t build in VS2008 without manual conversion; I don&apos;t intend to change that.  However, a few of the scripts in WebKitTools/Scripts can be very simply modified to support both VS2005 and VS2008, for developers with VS2008 who want to try converting things locally.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139055</commentid>
    <comment_count>1</comment_count>
      <attachid>34582</attachid>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2009-08-11 11:49:12 -0700</bug_when>
    <thetext>Created attachment 34582
Fix two scripts

I think this even makes webkitdirs.pm simpler.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139062</commentid>
    <comment_count>2</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2009-08-11 12:13:50 -0700</bug_when>
    <thetext>Fixed in r47045.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34582</attachid>
            <date>2009-08-11 11:49:12 -0700</date>
            <delta_ts>2009-08-11 11:54:06 -0700</delta_ts>
            <desc>Fix two scripts</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>3680</size>
            <attacher name="Peter Kasting">pkasting</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdFRvb2xz
L0NoYW5nZUxvZwkocmV2aXNpb24gNDcwNDEpCisrKyBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHdv
cmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wOC0xMSAgUGV0ZXIgS2FzdGluZyAg
PHBrYXN0aW5nQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4
MTgzCisgICAgICAgIFN1cHBvcnQgVlMyMDA4IGFzIHdlbGwgYXMgVlMyMDA1IGluIGEgZmV3IHNj
cmlwdHMuCisKKyAgICAgICAgKiBTY3JpcHRzL3BkZXZlbnY6IENoZWNrIGJvdGggJFZTODBDT01O
VE9PTFMgYW5kICRWUzkwQ09NTlRPT0xTLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w
bTogVXNlICRWU0lOU1RBTExESVIgaWYgYXZhaWxhYmxlIGluc3RlYWQgb2YgaGFyZGNvZGluZyB0
aGUgVlMyMDA1IGRpci4KKwogMjAwOS0wOC0xMSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5v
cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJLaXRUb29s
cy9TY3JpcHRzL3BkZXZlbnYNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3Bk
ZXZlbnYJKHJldmlzaW9uIDQ2OTk0KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9wZGV2ZW52CSh3
b3JraW5nIGNvcHkpCkBAIC0xMSw4ICsxMSwyMiBAQCBteSAoJGZoLCAkcGF0aCkgPSB0ZW1wZmls
ZShVTkxJTksgPT4gMCwgCiBjaG9tcChteSAkdmNCaW4gPSBgY3lncGF0aCAtdyAiJEZpbmRCaW46
OkJpbi8uLi92Y2JpbiJgKTsKIGNob21wKG15ICRzY3JpcHRzUGF0aCA9IGBjeWdwYXRoIC13ICIk
RmluZEJpbjo6QmluImApOwogCitteSAkdnNUb29sc1ZhcjsKK2lmICgkRU5WeydWUzgwQ09NTlRP
T0xTJ30pIHsNCisgICAgJHZzVG9vbHNWYXIgPSAiVlM4MENPTU5UT09MUyI7DQorfSBlbHNpZiAo
JEVOVnsnVlM5MENPTU5UT09MUyd9KSB7DQorICAgICR2c1Rvb2xzVmFyID0gIlZTOTBDT01OVE9P
TFMiOw0KK30gZWxzZSB7DQorICAgIHByaW50ICIqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqXG4iOw0KKyAgICBwcmludCAiQ2Fubm90
IGZpbmQgVmlzdWFsIFN0dWRpbyB0b29scyBkaXIuXG4iOw0KKyAgICBwcmludCAiUGxlYXNlIGVu
c3VyZSB0aGF0IFwkVlM4MENPTU5UT09MUyBvciBcJFZTOTBDT01OVE9PTFNcbiI7DQorICAgIHBy
aW50ICJpcyBzZXQgdG8gYSB2YWxpZCBsb2NhdGlvbi5cbiI7DQorICAgIHByaW50ICIqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqXG4i
Ow0KKyAgICBkaWU7DQorfQ0KKwogcHJpbnQgJGZoICJcQGVjaG8gb2ZmXG5cbiI7Ci1wcmludCAk
ZmggImNhbGwgXCJcJVZTODBDT01OVE9PTFNcJVxcdnN2YXJzMzIuYmF0XCJcblxuIjsKK3ByaW50
ICRmaCAiY2FsbCBcIlwlIiAuICR2c1Rvb2xzVmFyIC4gIlwlXFx2c3ZhcnMzMi5iYXRcIlxuXG4i
OwogcHJpbnQgJGZoICJzZXQgUEFUSD0kdmNCaW47JHNjcmlwdHNQYXRoO1wlUEFUSFwlXG5cbiI7
CiBwcmludCAkZmggIklGIEVYSVNUIFwiXCVWU0lOU1RBTExESVJcJVxcQ29tbW9uN1xcSURFXFxk
ZXZlbnYuY29tXCIgKGRldmVudi5jb20gL3VzZWVudiAiIC4gam9pbigiICIsIEBBUkdWKSAuICIp
IEVMU0UgIjsKIHByaW50ICRmaCAiVkNFeHByZXNzLmV4ZSAvdXNlZW52ICIgLiBqb2luKCIgIiwg
QEFSR1YpIC4gIlxuIjsKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQ0K
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQ0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNp
b24gNDY5OTQpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtpbmcg
Y29weSkKQEAgLTk1MiwyMyArOTUyLDIxIEBAIHN1YiBzZXR1cEN5Z3dpbkVudigpCiAgICAgcmV0
dXJuIGlmICFpc0N5Z3dpbigpOwogICAgIHJldHVybiBpZiAkdmNCdWlsZFBhdGg7CiAKLSAgICBt
eSAkcHJvZ3JhbUZpbGVzUGF0aCA9IGBjeWdwYXRoICIkRU5WeydQUk9HUkFNRklMRVMnfSJgOwot
ICAgIGNob21wICRwcm9ncmFtRmlsZXNQYXRoOwotICAgICR2Y0J1aWxkUGF0aCA9ICIkcHJvZ3Jh
bUZpbGVzUGF0aC9NaWNyb3NvZnQgVmlzdWFsIFN0dWRpbyA4L0NvbW1vbjcvSURFL2RldmVudi5j
b20iOworICAgIG15ICR2c0luc3RhbGxEaXI7CisgICAgbXkgJHByb2dyYW1GaWxlc1BhdGggPSAk
RU5WeydQUk9HUkFNRklMRVMnfSB8fCAiQzpcXFByb2dyYW0gRmlsZXMiOworICAgIGlmICgkRU5W
eydWU0lOU1RBTExESVInfSkgeworICAgICAgICAkdnNJbnN0YWxsRGlyID0gJEVOVnsnVlNJTlNU
QUxMRElSJ307CisgICAgfSBlbHNlIHsKKyAgICAgICAgJHZzSW5zdGFsbERpciA9ICIkcHJvZ3Jh
bUZpbGVzUGF0aC9NaWNyb3NvZnQgVmlzdWFsIFN0dWRpbyA4IjsKKyAgICB9CisgICAgJHZzSW5z
dGFsbERpciA9IGBjeWdwYXRoICIkdnNJbnN0YWxsRGlyImA7CisgICAgY2hvbXAgJHZzSW5zdGFs
bERpcjsKKyAgICAkdmNCdWlsZFBhdGggPSAiJHZzSW5zdGFsbERpci9Db21tb243L0lERS9kZXZl
bnYuY29tIjsKICAgICBpZiAoLWUgJHZjQnVpbGRQYXRoKSB7CiAgICAgICAgICMgVmlzdWFsIFN0
dWRpbyBpcyBpbnN0YWxsZWQ7IHdlIGNhbiB1c2UgcGRldmVudiB0byBidWlsZC4KICAgICAgICAg
JHZjQnVpbGRQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZShzb3VyY2VEaXIoKSwgcXcoV2ViS2l0
VG9vbHMgU2NyaXB0cyBwZGV2ZW52KSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgIyBWaXN1YWwg
U3R1ZGlvIG5vdCBmb3VuZCwgdHJ5IFZDKysgRXhwcmVzcwotICAgICAgICBteSAkdnNJbnN0YWxs
RGlyOwotICAgICAgICBpZiAoJEVOVnsnVlNJTlNUQUxMRElSJ30pIHsKLSAgICAgICAgICAgICR2
c0luc3RhbGxEaXIgPSAkRU5WeydWU0lOU1RBTExESVInfTsKLSAgICAgICAgfSBlbHNlIHsKLSAg
ICAgICAgICAgICRwcm9ncmFtRmlsZXNQYXRoID0gJEVOVnsnUFJPR1JBTUZJTEVTJ30gfHwgIkM6
XFxQcm9ncmFtIEZpbGVzIjsKLSAgICAgICAgICAgICR2c0luc3RhbGxEaXIgPSAiJHByb2dyYW1G
aWxlc1BhdGgvTWljcm9zb2Z0IFZpc3VhbCBTdHVkaW8gOCI7Ci0gICAgICAgIH0KLSAgICAgICAg
JHZzSW5zdGFsbERpciA9IGBjeWdwYXRoICIkdnNJbnN0YWxsRGlyImA7Ci0gICAgICAgIGNob21w
ICR2c0luc3RhbGxEaXI7CiAgICAgICAgICR2Y0J1aWxkUGF0aCA9ICIkdnNJbnN0YWxsRGlyL0Nv
bW1vbjcvSURFL1ZDRXhwcmVzcy5leGUiOwogICAgICAgICBpZiAoISAtZSAkdmNCdWlsZFBhdGgp
IHsKICAgICAgICAgICAgIHByaW50ICIqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqXG4iOwo=
</data>
<flag name="review"
          id="18737"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>