281751 2024-10-18 07:55:45 -0700 [WPE] Rename WPEMonitor to WPEScreen 2024-10-22 21:40:48 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jani webkit-unassigned bugs-noreply oldest_to_newest 2069118 0 jani 2024-10-18 07:55:45 -0700 The current naming of "WPEMonitor" in the WPE Platform doesn’t fit well across all device form factors. "WPEMonitor" suggests an individual display screen, but this naming feels out of place for smaller devices such as mobile phones. This naming convention is inherited from Gtk/Gdk, where GdkMonitor was introduced in GTK4 to replace the older GdkScreen. However, GdkMonitor was a compromise due to accumulated technical debt in GdkScreen. Additionally, in WebKit, there are many "*Monitor" classes used to monitor events, progress, and other functionalities. "WPEMonitor" could easily be confused with these, leading to potential misunderstandings about its purpose. Therefore, renaming WPEMonitor to WPEScreen would provide a clearer and more appropriate representation of its function. 2069139 1 jani 2024-10-18 08:37:28 -0700 Pull request: https://github.com/WebKit/WebKit/pull/35433 2069984 2 ews-feeder 2024-10-22 21:40:45 -0700 Committed 285586@main (ac17704df9a5): <https://commits.webkit.org/285586@main> Reviewed commits have been landed. Closing PR #35433 and removing active labels.