<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>28175</bug_id>
          
          <creation_ts>2009-08-11 06:21:18 -0700</creation_ts>
          <short_desc>HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit</short_desc>
          <delta_ts>2009-08-12 09:42:08 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Laszlo Gombos">laszlo.gombos</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>138946</commentid>
    <comment_count>0</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-08-11 06:21:18 -0700</bug_when>
    <thetext>The path separators in the path that is being passed to sqlite is not the native OS path; instead it is always the &quot;/&quot; - the Qt universal directory separator. Most OS (even Windows I think) understands the &quot;/&quot; separator - but not Symbian. The problem could be solved by calling QDir::toNativeSeparators() before the path is passed to the OS.

The problem and the possible solution was brought to my attention by David Leong.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138947</commentid>
    <comment_count>1</comment_count>
      <attachid>34553</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-08-11 06:27:44 -0700</bug_when>
    <thetext>Created attachment 34553
proposed patch.

WebCore::pathByAppendingComponent() seems to be a good place to call QDir::toNativeSeparators before the path is passed to the OS. All the path construction to sqlite DBs are going trough this function.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139240</commentid>
    <comment_count>2</comment_count>
      <attachid>34553</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-11 22:32:21 -0700</bug_when>
    <thetext>Comment on attachment 34553
proposed patch.

Seems OK.  I&apos;m not sure this is the right place for this change.  But i&apos;m not sure I have a better suggestion.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139363</commentid>
    <comment_count>3</comment_count>
      <attachid>34553</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-12 09:42:05 -0700</bug_when>
    <thetext>Comment on attachment 34553
proposed patch.

Clearing flags on attachment: 34553

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/qt/FileSystemQt.cpp
Committed r47114
	M	WebCore/ChangeLog
	M	WebCore/platform/qt/FileSystemQt.cpp
r47114 = 7f2ff9356922227e477417a6efb09c9d854e485e (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47114</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139364</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-12 09:42:08 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34553</attachid>
            <date>2009-08-11 06:27:44 -0700</date>
            <delta_ts>2009-08-12 09:42:05 -0700</delta_ts>
            <desc>proposed patch.</desc>
            <filename>patch_28175.txt</filename>
            <type>text/plain</type>
            <size>1264</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0NzAzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTcgQEAKKzIwMDktMDgtMTEgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i
b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEhUTUwgNSBkYXRhYmFzZSBhbmQgTG9jYWxTdG9yYWdlIGlzIG5vdCBwZXJzaXN0ZW50
IG9uIHRoZSBTeW1iaWFuIHBvcnQgb2YgUXRXZWJLaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4MTc1CisKKyAgICAgICAgQ2FsbCBRRGlyOjp0b05h
dGl2ZVNlcGFyYXRvcnMoKSBiZWZvcmUgdGhlIHBhdGggaXMgcGFzc2VkIHRvIHRoZSBPUy4KKwor
ICAgICAgICBCYXNlZCBvbiB3b3JrIGJ5IERhdmlkIExlb25nLgorICAgICAgICAKKyAgICAgICAg
KiBwbGF0Zm9ybS9xdC9GaWxlU3lzdGVtUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGF0aEJ5
QXBwZW5kaW5nQ29tcG9uZW50KToKKwogMjAwOS0wOC0xMSAgU2ltb24gSGF1c21hbm4gIDxzaW1v
bi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChidWls
ZCBmaXgpLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9xdC9GaWxlU3lzdGVtUXQuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vcXQvRmlsZVN5c3RlbVF0LmNwcAkocmV2aXNpb24g
NDY5NjkpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3F0L0ZpbGVTeXN0ZW1RdC5jcHAJKHdvcmtpbmcg
Y29weSkKQEAgLTgxLDcgKzgxLDcgQEAgYm9vbCBtYWtlQWxsRGlyZWN0b3JpZXMoY29uc3QgU3Ry
aW5nJiBwYQogCiBTdHJpbmcgcGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KGNvbnN0IFN0cmluZyYg
cGF0aCwgY29uc3QgU3RyaW5nJiBjb21wb25lbnQpCiB7Ci0gICAgcmV0dXJuIFFEaXIocGF0aCku
ZmlsZVBhdGgoY29tcG9uZW50KTsKKyAgICByZXR1cm4gUURpcjo6dG9OYXRpdmVTZXBhcmF0b3Jz
KFFEaXIocGF0aCkuZmlsZVBhdGgoY29tcG9uZW50KSk7CiB9CiAKIFN0cmluZyBob21lRGlyZWN0
b3J5UGF0aCgpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>