<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>28172</bug_id>
          
          <creation_ts>2009-08-11 00:37:20 -0700</creation_ts>
          <short_desc>fix a typo in platform/graphics/skia/PlatformContextSkia.cpp</short_desc>
          <delta_ts>2009-08-20 23:26:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Shinichiro Hamaji">hamaji</reporter>
          <assigned_to name="Adam Langley">agl</assigned_to>
          <cc>agl</cc>
    
    <cc>eric</cc>
    
    <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>138917</commentid>
    <comment_count>0</comment_count>
    <who name="Shinichiro Hamaji">hamaji</who>
    <bug_when>2009-08-11 00:37:20 -0700</bug_when>
    <thetext>If has the following line:

#ifdef SK_DEBUGx

The macro should be SK_DEBUG, I think.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138918</commentid>
    <comment_count>1</comment_count>
      <attachid>34543</attachid>
    <who name="Shinichiro Hamaji">hamaji</who>
    <bug_when>2009-08-11 00:38:42 -0700</bug_when>
    <thetext>Created attachment 34543
Patch v1


---
 2 files changed, 13 insertions(+), 1 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139621</commentid>
    <comment_count>2</comment_count>
      <attachid>34543</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-12 15:56:05 -0700</bug_when>
    <thetext>Comment on attachment 34543
Patch v1

Clearing flags on attachment: 34543

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/skia/PlatformContextSkia.cpp
Committed r47157
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/skia/PlatformContextSkia.cpp
r47157 = 26175092e7df7fdb43ae216e3e6bcfa058bb59d0 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47157</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139622</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-12 15:56:08 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139771</commentid>
    <comment_count>4</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-08-13 03:20:06 -0700</bug_when>
    <thetext>This patch broke Chromium Linux so I had to roll it out: http://trac.webkit.org/changeset/47189


Adam, would you investigate or find someone to do so?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139924</commentid>
    <comment_count>5</comment_count>
    <who name="Adam Langley">agl</who>
    <bug_when>2009-08-13 10:52:33 -0700</bug_when>
    <thetext>Upstreamed: http://codereview.appspot.com/105103</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141832</commentid>
    <comment_count>6</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-08-20 23:26:57 -0700</bug_when>
    <thetext>Refreshing bugzilla&apos;s memory loss:

This got another patch added to it by Stephen White which was r+ by Eric and then 
Committed r47607: &lt;http://trac.webkit.org/changeset/47607&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34543</attachid>
            <date>2009-08-11 00:38:42 -0700</date>
            <delta_ts>2009-08-12 15:56:05 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-28172-20090811163841.patch</filename>
            <type>text/plain</type>
            <size>1160</size>
            <attacher name="Shinichiro Hamaji">hamaji</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NTNjMjY5MC4uYTUxZGY4MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0xMSAgU2hpbmljaGlybyBI
YW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIGZpeCBhIHR5cG8gaW4gcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp
YS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjgxNzIKKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBp
dCdzIGEganVzdCB0eXBvIGZpeC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEv
UGxhdGZvcm1Db250ZXh0U2tpYS5jcHA6CisgICAgICAgIChQbGF0Zm9ybUNvbnRleHRTa2lhOjpz
ZXR1cFBhaW50Q29tbW9uKToKKwogMjAwOS0wOC0xMSAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5o
YXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZyZXl0aGVy
LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29u
dGV4dFNraWEuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29u
dGV4dFNraWEuY3BwCmluZGV4IGUwYTI5MmMuLmJmNmJhZTIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAorKysgYi9XZWJD
b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAKQEAgLTI5
NSw3ICsyOTUsNyBAQCB2b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OmRyYXdSZWN0KFNrUmVjdCBy
ZWN0KQogCiB2b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OnNldHVwUGFpbnRDb21tb24oU2tQYWlu
dCogcGFpbnQpIGNvbnN0CiB7Ci0jaWZkZWYgU0tfREVCVUd4CisjaWZkZWYgU0tfREVCVUcKICAg
ICB7CiAgICAgICAgIFNrUGFpbnQgZGVmYXVsdFBhaW50OwogICAgICAgICBTa0FTU0VSVCgqcGFp
bnQgPT0gZGVmYXVsdFBhaW50KTs=
</data>

          </attachment>
      

    </bug>

</bugzilla>