281715 2024-10-17 19:21:51 -0700 [FFC][Integration] Take writing-mode into account when computing flex item geometry 2024-10-18 07:21:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 2068986 0 zalan 2024-10-17 19:21:51 -0700 ssia 2068988 1 472977 zalan 2024-10-17 19:25:16 -0700 Created attachment 472977 [fast-cq]Patch 2069109 2 ews-feeder 2024-10-18 07:20:46 -0700 Committed 285401@main (23f40f9dd212): <https://commits.webkit.org/285401@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472977. 2069110 3 webkit-bug-importer 2024-10-18 07:21:16 -0700 <rdar://problem/138183704> 472977 2024-10-17 19:25:16 -0700 2024-10-18 07:20:47 -0700 [fast-cq]Patch bug-281715-20241017192515.patch text/plain 7376 zalan RnJvbSA3MTE4ZGNmYzA5MDQ1NzljNzUxNTllYjI1Y2FmNWM4NmQ0ZDQwOTMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFRodSwgMTcgT2N0IDIwMjQgMTk6MjE6NTkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBbRkZDXVtJ bnRlZ3JhdGlvbl0gVGFrZSB3cml0aW5nLW1vZGUgaW50byBhY2NvdW50IHdoZW4KIGNvbXB1dGlu ZyBmbGV4IGl0ZW0gZ2VvbWV0cnkgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTI4MTcxNQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpMZXQgaXNNYWluQXhpc1Bh cmFsbGVsV2l0aElubGluZUF4aXMgY29uc3VsdCB3cml0aW5nIG1vZGUuIEl0IG1ha2VzIHRoZSBy ZXN0IG9mIHRoZSBmbGV4CmxheW91dCB1bmF3YXJlIG9mIHRoZSBhY3R1YWwgd3JpdGluZyBtb2Rl LgoKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2ZsZXgvRmxleEZv cm1hdHRpbmdDb250ZXh0LmNwcDoKKFdlYkNvcmU6OkxheW91dDo6RmxleEZvcm1hdHRpbmdDb250 ZXh0OjpzZXRGbGV4SXRlbXNHZW9tZXRyeSk6CiogU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1h dHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhGb3JtYXR0aW5nVXRpbHMuY3BwOgooV2ViQ29yZTo6TGF5 b3V0OjpGbGV4Rm9ybWF0dGluZ1V0aWxzOjppc01haW5BeGlzUGFyYWxsZWxXaXRoSW5saW5lQXhp cyk6CiogU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL2ZsZXgvTGF5b3V0SW50ZWdy YXRpb25GbGV4TGF5b3V0LmNwcDoKKFdlYkNvcmU6OkxheW91dEludGVncmF0aW9uOjpGbGV4TGF5 b3V0OjpsYXlvdXQpOgooV2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRpb246OkZsZXhMYXlvdXQ6OnVw ZGF0ZVJlbmRlcmVycyk6Ci0tLQogLi4uL2ZsZXgvRmxleEZvcm1hdHRpbmdDb250ZXh0LmNwcCAg ICAgICAgICAgICB8ICA2ICsrKy0tLQogLi4uL2ZsZXgvRmxleEZvcm1hdHRpbmdVdGlscy5jcHAg ICAgICAgICAgICAgICB8ICA2ICsrKystLQogLi4uL2ZsZXgvTGF5b3V0SW50ZWdyYXRpb25GbGV4 TGF5b3V0LmNwcCAgICAgICB8IDE4ICsrKysrKysrKysrLS0tLS0tLQogMyBmaWxlcyBjaGFuZ2Vk LCAxOCBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2ZsZXgvRmxleEZvcm1hdHRpbmdDb250 ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvZmxleC9G bGV4Rm9ybWF0dGluZ0NvbnRleHQuY3BwCmluZGV4IGQ5MGJkZjBhMTg0NS4uZTExNGY4N2QyNDdj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2Zs ZXgvRmxleEZvcm1hdHRpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv Zm9ybWF0dGluZ0NvbnRleHRzL2ZsZXgvRmxleEZvcm1hdHRpbmdDb250ZXh0LmNwcApAQCAtMjEz LDcgKzIxMyw3IEBAIHZvaWQgRmxleEZvcm1hdHRpbmdDb250ZXh0OjpzZXRGbGV4SXRlbXNHZW9t ZXRyeShjb25zdCBGbGV4TGF5b3V0OjpMb2dpY2FsRmxleEl0CiB7CiAgICAgYXV0byYgZmxleEJv eFN0eWxlID0gcm9vdCgpLnN0eWxlKCk7CiAgICAgYXV0byBmbGV4RGlyZWN0aW9uID0gZmxleEJv eFN0eWxlLmZsZXhEaXJlY3Rpb24oKTsKLSAgICBhdXRvIGlzTWFpbkF4aXNQYXJhbGxlbFdpdGhJ bmxpbmVBeGlzID0gRmxleEZvcm1hdHRpbmdVdGlsczo6aXNNYWluQXhpc1BhcmFsbGVsV2l0aElu bGluZUF4aXMocm9vdCgpKTsKKyAgICBhdXRvIGlzUm93RGlyZWN0aW9uID0gZmxleERpcmVjdGlv biA9PSBGbGV4RGlyZWN0aW9uOjpSb3cgfHwgZmxleERpcmVjdGlvbiA9PSBGbGV4RGlyZWN0aW9u OjpSb3dSZXZlcnNlOwogICAgIGF1dG8gZmxleENvbnRhaW5lckNvbnRlbnRCb3hQb3NpdGlvbiA9 IExheW91dFBvaW50IHsgY29uc3RyYWludHMubWFpbkF4aXMoKS5zdGFydFBvc2l0aW9uLCBjb25z dHJhaW50cy5jcm9zc0F4aXMoKS5zdGFydFBvc2l0aW9uIH07CiAgICAgYXV0byBmbGV4Q29udGVu dExvZ2ljYWxIZWlnaHRGb3JXYXJwUmV2ZXJzZSA9IFsmXSgpIC0+IHN0ZDo6b3B0aW9uYWw8TGF5 b3V0VW5pdD4gewogICAgICAgICBpZiAoZmxleEJveFN0eWxlLmZsZXhXcmFwKCkgIT0gRmxleFdy YXA6OlJldmVyc2UpCkBAIC0yNzQsOCArMjc0LDggQEAgdm9pZCBGbGV4Rm9ybWF0dGluZ0NvbnRl eHQ6OnNldEZsZXhJdGVtc0dlb21ldHJ5KGNvbnN0IEZsZXhMYXlvdXQ6OkxvZ2ljYWxGbGV4SXQK ICAgICAgICAgfQogICAgICAgICBmbGV4SXRlbUdlb21ldHJ5LnNldFRvcExlZnQoeyBib3JkZXJC b3hMZWZ0LCBib3JkZXJCb3hUb3AgfSk7CiAKLSAgICAgICAgYXV0byBjb250ZW50Qm94V2lkdGgg PSBpc01haW5BeGlzUGFyYWxsZWxXaXRoSW5saW5lQXhpcyA/IGxvZ2ljYWxSZWN0LndpZHRoKCkg OiBsb2dpY2FsUmVjdC5oZWlnaHQoKTsKLSAgICAgICAgYXV0byBjb250ZW50Qm94SGVpZ2h0ID0g aXNNYWluQXhpc1BhcmFsbGVsV2l0aElubGluZUF4aXMgPyBsb2dpY2FsUmVjdC5oZWlnaHQoKSA6 IGxvZ2ljYWxSZWN0LndpZHRoKCk7CisgICAgICAgIGF1dG8gY29udGVudEJveFdpZHRoID0gaXNS b3dEaXJlY3Rpb24gPyBsb2dpY2FsUmVjdC53aWR0aCgpIDogbG9naWNhbFJlY3QuaGVpZ2h0KCk7 CisgICAgICAgIGF1dG8gY29udGVudEJveEhlaWdodCA9IGlzUm93RGlyZWN0aW9uID8gbG9naWNh bFJlY3QuaGVpZ2h0KCkgOiBsb2dpY2FsUmVjdC53aWR0aCgpOwogICAgICAgICBpZiAoIWxvZ2lj YWxGbGV4SXRlbS5pc0NvbnRlbnRCb3hCYXNlZCgpKSB7CiAgICAgICAgICAgICBjb250ZW50Qm94 V2lkdGggLT0gZmxleEl0ZW1HZW9tZXRyeS5ob3Jpem9udGFsQm9yZGVyQW5kUGFkZGluZygpOwog ICAgICAgICAgICAgY29udGVudEJveEhlaWdodCAtPSBmbGV4SXRlbUdlb21ldHJ5LnZlcnRpY2Fs Qm9yZGVyQW5kUGFkZGluZygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zv cm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhGb3JtYXR0aW5nVXRpbHMuY3BwIGIvU291cmNlL1dl YkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhGb3JtYXR0aW5nVXRpbHMu Y3BwCmluZGV4IDlhNjkxYjhkNDEwNi4uNjdlN2JlZTBjMzNmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2ZsZXgvRmxleEZvcm1hdHRpbmdVdGls cy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4 L0ZsZXhGb3JtYXR0aW5nVXRpbHMuY3BwCkBAIC00Miw4ICs0MiwxMCBAQCBGbGV4Rm9ybWF0dGlu Z1V0aWxzOjpGbGV4Rm9ybWF0dGluZ1V0aWxzKGNvbnN0IEZsZXhGb3JtYXR0aW5nQ29udGV4dCYg ZmxleEZvcm1hdAogYm9vbCBGbGV4Rm9ybWF0dGluZ1V0aWxzOjppc01haW5BeGlzUGFyYWxsZWxX aXRoSW5saW5lQXhpcyhjb25zdCBFbGVtZW50Qm94JiBmbGV4Q29udGFpbmVyKQogewogICAgIEFT U0VSVChmbGV4Q29udGFpbmVyLmlzRmxleEJveCgpKTsKLSAgICBhdXRvIGZsZXhEaXJlY3Rpb24g PSBmbGV4Q29udGFpbmVyLnN0eWxlKCkuZmxleERpcmVjdGlvbigpOwotICAgIHJldHVybiBmbGV4 RGlyZWN0aW9uID09IEZsZXhEaXJlY3Rpb246OlJvdyB8fCBmbGV4RGlyZWN0aW9uID09IEZsZXhE aXJlY3Rpb246OlJvd1JldmVyc2U7CisgICAgYXV0byYgZmxleENvbnRhaW5lclN0eWxlID0gZmxl eENvbnRhaW5lci5zdHlsZSgpOworICAgIGF1dG8gaXNIb3Jpem9udGFsV3JpdGluZ01vZGUgPSBm bGV4Q29udGFpbmVyU3R5bGUuaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKTsKKyAgICBhdXRvIGZs ZXhEaXJlY3Rpb24gPSBmbGV4Q29udGFpbmVyU3R5bGUuZmxleERpcmVjdGlvbigpOworICAgIHJl dHVybiAoaXNIb3Jpem9udGFsV3JpdGluZ01vZGUgJiYgKGZsZXhEaXJlY3Rpb24gPT0gRmxleERp cmVjdGlvbjo6Um93IHx8IGZsZXhEaXJlY3Rpb24gPT0gRmxleERpcmVjdGlvbjo6Um93UmV2ZXJz ZSkpIHx8ICghaXNIb3Jpem9udGFsV3JpdGluZ01vZGUgJiYgKGZsZXhEaXJlY3Rpb24gPT0gRmxl eERpcmVjdGlvbjo6Q29sdW1uIHx8IGZsZXhEaXJlY3Rpb24gPT0gRmxleERpcmVjdGlvbjo6Q29s dW1uUmV2ZXJzZSkpOwogfQogCiBib29sIEZsZXhGb3JtYXR0aW5nVXRpbHM6OmlzTWFpblJldmVy c2VkVG9Db250ZW50RGlyZWN0aW9uKGNvbnN0IEVsZW1lbnRCb3gmIGZsZXhDb250YWluZXIpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vZmxleC9MYXlvdXRJ bnRlZ3JhdGlvbkZsZXhMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0 aW9uL2ZsZXgvTGF5b3V0SW50ZWdyYXRpb25GbGV4TGF5b3V0LmNwcAppbmRleCA2M2M1OWNkNmVm ZWUuLjkzMzA5M2MxZGNmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVn cmF0aW9uL2ZsZXgvTGF5b3V0SW50ZWdyYXRpb25GbGV4TGF5b3V0LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vZmxleC9MYXlvdXRJbnRlZ3JhdGlvbkZsZXhMYXlv dXQuY3BwCkBAIC0xMzgsMjIgKzEzOCwyNSBAQCB2b2lkIEZsZXhMYXlvdXQ6OmxheW91dCgpCiAg ICAgYXV0byByZWxheW91dEZsZXhJdGVtcyA9IFsmXSB7CiAgICAgICAgIC8vIEZsZXggaXRlbXMg bmVlZCB0byBiZSBsYWlkIG91dCBub3cgd2l0aCB0aGVpciBmaW5hbCBzaXplIChhbmQgdGhyb3Vn aCBzZXRPdmVycmlkaW5nTG9naWNhbFdpZHRoL0hlaWdodCkKICAgICAgICAgLy8gTm90ZSB0aGF0 IHRoZXkgbWF5IHJlLXNpemUgdGhlbXNlbHZlcy4KKyAgICAgICAgYXV0byBpc0hvcml6b250YWxX cml0aW5nTW9kZSA9IGZsZXhCb3goKS5zdHlsZSgpLmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCk7 CiAgICAgICAgIGZvciAoYXV0byYgbGF5b3V0Qm94IDogZm9ybWF0dGluZ0NvbnRleHRCb3hlcyhm bGV4Qm94KCkpKSB7CiAgICAgICAgICAgICBhdXRvJiByZW5kZXJlciA9IGRvd25jYXN0PFJlbmRl ckJveD4oKmxheW91dEJveC5yZW5kZXJlckZvckludGVncmF0aW9uKCkpOwogICAgICAgICAgICAg YXV0byBib3JkZXJCb3ggPSBMYXlvdXQ6OkJveEdlb21ldHJ5Ojpib3JkZXJCb3hSZWN0KGxheW91 dFN0YXRlKCkuZ2VvbWV0cnlGb3JCb3gobGF5b3V0Qm94KSk7CisgICAgICAgICAgICBhdXRvIGJv cmRlckJveFdpZHRoID0gaXNIb3Jpem9udGFsV3JpdGluZ01vZGUgPyBib3JkZXJCb3gud2lkdGgo KSA6IGJvcmRlckJveC5oZWlnaHQoKTsKKyAgICAgICAgICAgIGF1dG8gYm9yZGVyQm94SGVpZ2h0 ID0gaXNIb3Jpem9udGFsV3JpdGluZ01vZGUgPyBib3JkZXJCb3guaGVpZ2h0KCkgOiBib3JkZXJC b3gud2lkdGgoKTsKIAogICAgICAgICAgICAgcmVuZGVyZXIuc2V0V2lkdGgoTGF5b3V0VW5pdCB7 IH0pOwogICAgICAgICAgICAgcmVuZGVyZXIuc2V0SGVpZ2h0KExheW91dFVuaXQgeyB9KTsKICAg ICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIG1heSBuZWVkIGEgdmlzdWFsIHZzLiBsb2dpY2FsIGZs aXAuCi0gICAgICAgICAgICByZW5kZXJlci5zZXRPdmVycmlkaW5nTG9naWNhbFdpZHRoKGJvcmRl ckJveC53aWR0aCgpKTsKLSAgICAgICAgICAgIHJlbmRlcmVyLnNldE92ZXJyaWRpbmdMb2dpY2Fs SGVpZ2h0KGJvcmRlckJveC5oZWlnaHQoKSk7CisgICAgICAgICAgICByZW5kZXJlci5zZXRPdmVy cmlkaW5nTG9naWNhbFdpZHRoKGJvcmRlckJveFdpZHRoKTsKKyAgICAgICAgICAgIHJlbmRlcmVy LnNldE92ZXJyaWRpbmdMb2dpY2FsSGVpZ2h0KGJvcmRlckJveEhlaWdodCk7CiAKICAgICAgICAg ICAgIHJlbmRlcmVyLnNldENoaWxkTmVlZHNMYXlvdXQoTWFya09ubHlUaGlzKTsKICAgICAgICAg ICAgIHJlbmRlcmVyLmxheW91dElmTmVlZGVkKCk7CiAgICAgICAgICAgICByZW5kZXJlci5jbGVh ck92ZXJyaWRpbmdDb250ZW50U2l6ZSgpOwogCi0gICAgICAgICAgICByZW5kZXJlci5zZXRXaWR0 aChib3JkZXJCb3gud2lkdGgoKSk7Ci0gICAgICAgICAgICByZW5kZXJlci5zZXRIZWlnaHQoYm9y ZGVyQm94LmhlaWdodCgpKTsKKyAgICAgICAgICAgIHJlbmRlcmVyLnNldFdpZHRoKGJvcmRlckJv eFdpZHRoKTsKKyAgICAgICAgICAgIHJlbmRlcmVyLnNldEhlaWdodChib3JkZXJCb3hIZWlnaHQp OwogICAgICAgICB9CiAgICAgfTsKICAgICByZWxheW91dEZsZXhJdGVtcygpOwpAQCAtMTYxLDEz ICsxNjQsMTQgQEAgdm9pZCBGbGV4TGF5b3V0OjpsYXlvdXQoKQogCiB2b2lkIEZsZXhMYXlvdXQ6 OnVwZGF0ZVJlbmRlcmVycygpCiB7CisgICAgYXV0byBpc0hvcml6b250YWxXcml0aW5nTW9kZSA9 IGZsZXhCb3goKS5zdHlsZSgpLmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCk7CiAgICAgZm9yIChh dXRvJiBsYXlvdXRCb3ggOiBmb3JtYXR0aW5nQ29udGV4dEJveGVzKGZsZXhCb3goKSkpIHsKICAg ICAgICAgYXV0byYgcmVuZGVyZXIgPSBkb3duY2FzdDxSZW5kZXJCb3g+KCpsYXlvdXRCb3gucmVu ZGVyZXJGb3JJbnRlZ3JhdGlvbigpKTsKICAgICAgICAgYXV0byYgZmxleEl0ZW1HZW9tZXRyeSA9 IGxheW91dFN0YXRlKCkuZ2VvbWV0cnlGb3JCb3gobGF5b3V0Qm94KTsKICAgICAgICAgYXV0byBi b3JkZXJCb3ggPSBMYXlvdXQ6OkJveEdlb21ldHJ5Ojpib3JkZXJCb3hSZWN0KGZsZXhJdGVtR2Vv bWV0cnkpOwotICAgICAgICByZW5kZXJlci5zZXRMb2NhdGlvbihib3JkZXJCb3gudG9wTGVmdCgp KTsKLSAgICAgICAgcmVuZGVyZXIuc2V0V2lkdGgoYm9yZGVyQm94LndpZHRoKCkpOwotICAgICAg ICByZW5kZXJlci5zZXRIZWlnaHQoYm9yZGVyQm94LmhlaWdodCgpKTsKKyAgICAgICAgcmVuZGVy ZXIuc2V0TG9jYXRpb24oaXNIb3Jpem9udGFsV3JpdGluZ01vZGUgPyBib3JkZXJCb3gudG9wTGVm dCgpIDogYm9yZGVyQm94LnRvcExlZnQoKS50cmFuc3Bvc2VkUG9pbnQoKSk7CisgICAgICAgIHJl bmRlcmVyLnNldFdpZHRoKGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlID8gYm9yZGVyQm94LndpZHRo KCkgOiBib3JkZXJCb3guaGVpZ2h0KCkpOworICAgICAgICByZW5kZXJlci5zZXRIZWlnaHQoaXNI b3Jpem9udGFsV3JpdGluZ01vZGUgPyBib3JkZXJCb3guaGVpZ2h0KCkgOiBib3JkZXJCb3gud2lk dGgoKSk7CiAKICAgICAgICAgcmVuZGVyZXIuc2V0TWFyZ2luU3RhcnQoZmxleEl0ZW1HZW9tZXRy eS5tYXJnaW5TdGFydCgpKTsKICAgICAgICAgcmVuZGVyZXIuc2V0TWFyZ2luRW5kKGZsZXhJdGVt R2VvbWV0cnkubWFyZ2luRW5kKCkpOwo=