28164 2009-08-10 13:25:19 -0700 check-webkit-style doesn't catch braces around single line statements when followed by else. 2009-08-10 15:13:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 levin levin abarth ddkilzer eric manyoso oldest_to_newest 138794 0 levin 2009-08-10 13:25:19 -0700 This was noticed in bug https://bugs.webkit.org/show_bug.cgi?id=28134 138800 1 34509 levin 2009-08-10 13:35:38 -0700 Created attachment 34509 Proposed fix. 138832 2 34509 ddkilzer 2009-08-10 15:01:58 -0700 Comment on attachment 34509 Proposed fix. r=me 138836 3 levin 2009-08-10 15:13:40 -0700 Committed as http://trac.webkit.org/changeset/47006 34509 2009-08-10 13:35:38 -0700 2009-08-10 15:01:57 -0700 Proposed fix. patch.txt text/plain 2184 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjZjI5NmU5Li5mYjk3NWI2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDgt MTAgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBkb2Vzbid0 IGNhdGNoIGJyYWNlcyBhcm91bmQgc2luZ2xlIGxpbmUgc3RhdGVtZW50cyB3aGVuIGZvbGxvd2Vk IGJ5IGVsc2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yODE2NAorCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weTogQWRkZWQg ZWxzZSB0byB0aGUgcmVnZXggdGhhdCBmaW5kcyBlbmRpbmcgfSdzIHdoZW4KKyAgICAgICAgICBj aGVja2luZyB0aGUgbm8gYnJhY2VzIGZvciAic2luZ2xlIGxpbmVzIiBydWxlLgorICAgICAgICAq IFNjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHk6IEFkZGVkIHRlc3QgY2FzZS4K KwogMjAwOS0wOC0wNSAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j cHBfc3R5bGUucHkKaW5kZXggN2MxNTMyYS4uMDZhM2VjOSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRz L21vZHVsZXMvY3BwX3N0eWxlLnB5CkBAIC0xODMwLDcgKzE4MzAsNyBAQCBkZWYgY2hlY2tfYnJh Y2VzKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKToKICAgICAgICAg ZXJyb3IoZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9icmFjZXMnLCA0LAogICAg ICAgICAgICAgICAnUGxhY2UgYnJhY2Ugb24gaXRzIG93biBsaW5lIGZvciBmdW5jdGlvbiBkZWZp bml0aW9ucy4nKQogCi0gICAgaWYgKG1hdGNoKHInXHMqfVxzKiQnLCBsaW5lKSBhbmQgbGluZV9u dW1iZXIgPiAxKToKKyAgICBpZiAobWF0Y2gocidccyp9XHMqKGVsc2Vccyooe1xzKik/KT8kJywg bGluZSkgYW5kIGxpbmVfbnVtYmVyID4gMSk6CiAgICAgICAgICMgV2UgY2hlY2sgaWYgYSBjbG9z ZWQgYnJhY2UgaGFzIHN0YXJ0ZWQgYSBsaW5lIHRvIHNlZSBpZiBhCiAgICAgICAgICMgb25lIGxp bmUgY29udHJvbCBzdGF0ZW1lbnQgd2FzIHByZXZpb3VzLgogICAgICAgICBwcmV2aW91c19saW5l ID0gY2xlYW5fbGluZXMuZWxpZGVkW2xpbmVfbnVtYmVyIC0gMl0KZGlmZiAtLWdpdCBhL1dlYktp dFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29s cy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CmluZGV4IDdmYmNlODQuLjBi N2EzZWEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVf dW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91 bml0dGVzdC5weQpAQCAtMzI4Niw2ICszMjg2LDEzIEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChD cHBTdHlsZVRlc3RCYXNlKToKIAogICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQo CiAgICAgICAgICAgICAnaWYgKHRydWUpIHtcbicKKyAgICAgICAgICAgICcgICAgaW50IGZvbztc bicKKyAgICAgICAgICAgICd9IGVsc2VcbicKKyAgICAgICAgICAgICcgICAgaW50IGZvbztcbics CisgICAgICAgICAgICAnT25lIGxpbmUgY29udHJvbCBjbGF1c2VzIHNob3VsZCBub3QgdXNlIGJy YWNlcy4gIFt3aGl0ZXNwYWNlL2JyYWNlc10gWzRdJykKKworICAgICAgICBzZWxmLmFzc2VydF9t dWx0aV9saW5lX2xpbnQoCisgICAgICAgICAgICAnaWYgKHRydWUpIHtcbicKICAgICAgICAgICAg ICcgICAgLy8gU29tZSBjb21tZW50XG4nCiAgICAgICAgICAgICAnICAgIGludCBmb287XG4nCiAg ICAgICAgICAgICAnfVxuJywK