28162 2009-08-10 12:57:44 -0700 [Qt] QtLauncher crashes when trying to change zoom level 2009-08-12 15:49:27 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gwright webkit-unassigned eric oldest_to_newest 138778 0 gwright 2009-08-10 12:57:44 -0700 Trying to change zoom level on QtLauncher causes the app to abort and exit: george@iridium ~/gwright-sandbox/WebKitBuild/Debug/bin $ ./QtLauncher ASSERT: "i >= 0" in file /home/george/gwright-sandbox/WebKit/qt/QtLauncher/main.cpp, line 169 zsh: abort ./QtLauncher 138814 1 34513 gwright 2009-08-10 14:15:25 -0700 Created attachment 34513 Fix QtLauncher crash The zoomLevels object is only populated if a valid URL is passed to the application on launch, and it is never populated otherwise. This patch simply populates the zoom level no matter whether a valid URL is supplied or not as it does not depend on a valid URL to function correctly. 139598 2 34513 eric 2009-08-12 15:26:48 -0700 Comment on attachment 34513 Fix QtLauncher crash Adam, since you're a committer, you can just mark this commit-queue+ if you want it committed for you. :) cq=? is for folks who are not committed but want to make sure it's added to the cq. 139616 3 34513 eric 2009-08-12 15:49:23 -0700 Comment on attachment 34513 Fix QtLauncher crash Clearing flags on attachment: 34513 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/qt/ChangeLog M WebKit/qt/QtLauncher/main.cpp Committed r47156 M WebKit/qt/QtLauncher/main.cpp M WebKit/qt/ChangeLog r47156 = 2a552d79fea80795059ae47a478f535d24093bdd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47156 139617 4 eric 2009-08-12 15:49:27 -0700 All reviewed patches have been landed. Closing bug. 34513 2009-08-10 14:15:25 -0700 2009-08-12 15:49:22 -0700 Fix QtLauncher crash qtlauncher-crash.patch text/plain 1373 gwright ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGFhNzY0NDcuLjNjZDIyYTYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTA4LTEwICBHZW9y Z2UgV3JpZ2h0ICA8Z2VvcmdlLndyaWdodEB0b3JjaG1vYmlsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5pdGlhbGlzZSB6b29tIGxldmVs cyBpbmRlcGVuZGVudCBvZiB3aGV0aGVyIGEgVVJMIGlzIHZhbGlkIG9yIG5vdCB0bworICAgICAg ICBmaXggaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4MTYyCisKKyAg ICAgICAgKiBRdExhdW5jaGVyL21haW4uY3BwOgorICAgICAgICAoTWFpbldpbmRvdzo6TWFpbldp bmRvdyk6CisKIDIwMDktMDgtMDUgIENzYWJhIE9zenRyb2dvbmFjICA8b3N6aUBpbmYudS1zemVn ZWQuaHU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQg YS9XZWJLaXQvcXQvUXRMYXVuY2hlci9tYWluLmNwcCBiL1dlYktpdC9xdC9RdExhdW5jaGVyL21h aW4uY3BwCmluZGV4IDljYmFiNTMuLjFjNGQwZWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9RdExh dW5jaGVyL21haW4uY3BwCisrKyBiL1dlYktpdC9xdC9RdExhdW5jaGVyL21haW4uY3BwCkBAIC0x MDMsMTEgKzEwMywxMiBAQCBwdWJsaWM6CiAgICAgICAgICAgICB1cmxFZGl0LT5zZXRUZXh0KHF1 cmwudG9FbmNvZGVkKCkpOwogICAgICAgICAgICAgdmlldy0+bG9hZChxdXJsKTsKIAotICAgICAg ICAgICAgLy8gdGhlIHpvb20gdmFsdWVzIGFyZSBjaG9zZW4gdG8gYmUgbGlrZSBpbiBNb3ppbGxh IEZpcmVmb3ggMwotICAgICAgICAgICAgem9vbUxldmVscyA8PCAzMCA8PCA1MCA8PCA2NyA8PCA4 MCA8PCA5MDsKLSAgICAgICAgICAgIHpvb21MZXZlbHMgPDwgMTAwOwotICAgICAgICAgICAgem9v bUxldmVscyA8PCAxMTAgPDwgMTIwIDw8IDEzMyA8PCAxNTAgPDwgMTcwIDw8IDIwMCA8PCAyNDAg PDwgMzAwOwogICAgICAgICB9CisKKyAgICAgICAgLy8gdGhlIHpvb20gdmFsdWVzIGFyZSBjaG9z ZW4gdG8gYmUgbGlrZSBpbiBNb3ppbGxhIEZpcmVmb3ggMworICAgICAgICB6b29tTGV2ZWxzIDw8 IDMwIDw8IDUwIDw8IDY3IDw8IDgwIDw8IDkwOworICAgICAgICB6b29tTGV2ZWxzIDw8IDEwMDsK KyAgICAgICAgem9vbUxldmVscyA8PCAxMTAgPDwgMTIwIDw8IDEzMyA8PCAxNTAgPDwgMTcwIDw8 IDIwMCA8PCAyNDAgPDwgMzAwOwogICAgIH0KIAogICAgIFFXZWJQYWdlKiB3ZWJQYWdlKCkgY29u c3Qgewo=