28160 2009-08-10 12:21:42 -0700 FastMalloc.h has cross-platform code but marked as WinCE-only 2009-08-10 12:42:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin oldest_to_newest 138768 0 darin 2009-08-10 12:21:42 -0700 I noticed code in FastMalloc.h that is not at all platform-specific, but is marked WinCE-only. 138769 1 34498 darin 2009-08-10 12:22:42 -0700 Created attachment 34498 Patch 138771 2 34498 darin 2009-08-10 12:40:15 -0700 Comment on attachment 34498 Patch Mark reviewed this and provided comments and I've landed it now. 138772 3 darin 2009-08-10 12:42:26 -0700 http://trac.webkit.org/changeset/46999 34498 2009-08-10 12:22:42 -0700 2009-08-10 12:40:15 -0700 Patch MallocPatch.txt text/plain 5068 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2OTg1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDktMDgtMTAgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZhc3RNYWxsb2MuaCBoYXMgY3Jvc3MtcGxhdGZvcm0gY29kZSBidXQg bWFya2VkIGFzIFdpbkNFLW9ubHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI4MTYwCisKKyAgICAgICAgMSkgVGhlIHN1cHBvcnQgZm9yIG5vdGhyb3cg d2FzIGluc2lkZSAjaWYgUExBVEZPUk0oV0lOQ0UpIGV2ZW4gdGhvdWdoIGl0IGlzCisgICAgICAg ICAgIG5vdCBwbGF0Zm9ybS1zcGVjaWZpYy4KKyAgICAgICAgMikgVGhlIGNvZGUgdHJpZWQgdG8g b3ZlcnJpZGUgb3BlcmF0b3IgZGVsZXRlIG5vdGhyb3csIHdoaWNoIGRvZXMgbm90IGV4aXN0Lgor ICAgICAgICAzKSBUaGUgY29kZSBpbiB0aGUgaGVhZGVyIGNoZWNrcyB0aGUgdmFsdWUgb2YgVVNF X1NZU1RFTV9NQUxMT0MsIGJ1dCB0aGUgY29kZQorICAgICAgICAgICBpbiBGYXN0TWFsbG9jLmNw cCBjaGVja3Mgb25seSBpZiB0aGUgbWFjcm8gaXMgZGVmaW5lZC4KKyAgICAgICAgNCkgVGhlIG5v dGhyb3cgdmVyc2lvbiBvZiBvcGVyYXRvciBuZXcgd2FzIGNhbGxpbmcgZmFzdE1hbGxvYygpLCBi dXQgc2luY2UKKyAgICAgICAgICAgdGhpcyBmdW5jdGlvbiBpcyBhbGxvd2VkIHRvIHJldHVybiAw LCBpdCBzaG91bGQgY2FsbCB0cnlGYXN0TWFsbG9jKCkuCisKKyAgICAgICAgKiB3dGYvRmFzdE1h bGxvYy5oOiBTZWUgYWJvdmUuCisgICAgICAgICogd3RmL0Zhc3RNYWxsb2MuY3BwOiBEaXR0by4K KwogMjAwOS0wOC0xMCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCBidWlsZCBmaXguCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxv Yy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCShy ZXZpc2lvbiA0Njk4NSkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMSw2ICsxLDYgQEAKIC8vIENvcHlyaWdodCAoYykgMjAwNSwgMjAwNywg R29vZ2xlIEluYy4KIC8vIEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0vLyBDb3B5cmlnaHQgKEMpIDIw MDUsIDIwMDYsIDIwMDcsIDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorLy8g Q29weXJpZ2h0IChDKSAyMDA1LCAyMDA2LCAyMDA3LCAyMDA4LCAyMDA5IEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KIC8vIAogLy8gUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3Vy Y2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAvLyBtb2RpZmljYXRpb24sIGFy ZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCkBA IC04OSwxMyArODksMTIgQEAKICNlbmRpZgogI2VuZGlmCiAKLSNpZiAhZGVmaW5lZChVU0VfU1lT VEVNX01BTExPQykgJiYgZGVmaW5lZChOREVCVUcpCisjaWYgIShkZWZpbmVkKFVTRV9TWVNURU1f TUFMTE9DKSAmJiBVU0VfU1lTVEVNX01BTExPQykgJiYgZGVmaW5lZChOREVCVUcpCiAjZGVmaW5l IEZPUkNFX1NZU1RFTV9NQUxMT0MgMAogI2Vsc2UKICNkZWZpbmUgRk9SQ0VfU1lTVEVNX01BTExP QyAxCiAjZW5kaWYKIAotCiAvLyBVc2UgYSBiYWNrZ3JvdW5kIHRocmVhZCB0byBwZXJpb2RpY2Fs bHkgc2NhdmVuZ2UgbWVtb3J5IHRvIHJlbGVhc2UgYmFjayB0byB0aGUgc3lzdGVtCiAvLyBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc5MDA6IGRvbid0IHR1cm4gdGhp cyBvbiBmb3IgVGlnZXIgdW50aWwgd2UgaGF2ZSBmaWd1cmVkIG91dCB3aHkgaXQgY2F1c2VkIGEg Y3Jhc2guCiAjaWYgZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikKSW5kZXg6IEphdmFTY3JpcHRD b3JlL3d0Zi9GYXN0TWFsbG9jLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL0Zh c3RNYWxsb2MuaAkocmV2aXNpb24gNDY5ODUpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1h bGxvYy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqICBDb3B5cmlnaHQg KEMpIDIwMDUsIDIwMDYsIDIwMDcsIDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICogIENvcHlyaWdodCAoQykgMjAwNSwgMjAwNiwgMjAwNywgMjAwOCwgMjAwOSBBcHBsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNv ZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqICBtb2RpZnkgaXQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwpAQCAtMjgsMTgg KzI4LDE4IEBACiBuYW1lc3BhY2UgV1RGIHsKIAogICAgIC8vIFRoZXNlIGZ1bmN0aW9ucyBjYWxs IENSQVNIKCkgaWYgYW4gYWxsb2NhdGlvbiBmYWlscy4KLSAgICB2b2lkKiBmYXN0TWFsbG9jKHNp emVfdCBuKTsKLSAgICB2b2lkKiBmYXN0WmVyb2VkTWFsbG9jKHNpemVfdCBuKTsKLSAgICB2b2lk KiBmYXN0Q2FsbG9jKHNpemVfdCBuX2VsZW1lbnRzLCBzaXplX3QgZWxlbWVudF9zaXplKTsKLSAg ICB2b2lkKiBmYXN0UmVhbGxvYyh2b2lkKiBwLCBzaXplX3Qgbik7Ci0KLSAgICAvLyBUaGVzZSBm dW5jdGlvbnMgcmV0dXJuIE5VTEwgaWYgYW4gYWxsb2NhdGlvbiBmYWlscy4KLSAgICB2b2lkKiB0 cnlGYXN0TWFsbG9jKHNpemVfdCBuKTsKLSAgICB2b2lkKiB0cnlGYXN0WmVyb2VkTWFsbG9jKHNp emVfdCBuKTsKLSAgICB2b2lkKiB0cnlGYXN0Q2FsbG9jKHNpemVfdCBuX2VsZW1lbnRzLCBzaXpl X3QgZWxlbWVudF9zaXplKTsKLSAgICB2b2lkKiB0cnlGYXN0UmVhbGxvYyh2b2lkKiBwLCBzaXpl X3Qgbik7CisgICAgdm9pZCogZmFzdE1hbGxvYyhzaXplX3QpOworICAgIHZvaWQqIGZhc3RaZXJv ZWRNYWxsb2Moc2l6ZV90KTsKKyAgICB2b2lkKiBmYXN0Q2FsbG9jKHNpemVfdCBudW1FbGVtZW50 cywgc2l6ZV90IGVsZW1lbnRTaXplKTsKKyAgICB2b2lkKiBmYXN0UmVhbGxvYyh2b2lkKiwgc2l6 ZV90KTsKKworICAgIC8vIFRoZXNlIGZ1bmN0aW9ucyByZXR1cm4gMCBpZiBhbiBhbGxvY2F0aW9u IGZhaWxzLgorICAgIHZvaWQqIHRyeUZhc3RNYWxsb2Moc2l6ZV90KTsKKyAgICB2b2lkKiB0cnlG YXN0WmVyb2VkTWFsbG9jKHNpemVfdCk7CisgICAgdm9pZCogdHJ5RmFzdENhbGxvYyhzaXplX3Qg bnVtRWxlbWVudHMsIHNpemVfdCBlbGVtZW50U2l6ZSk7CisgICAgdm9pZCogdHJ5RmFzdFJlYWxs b2Modm9pZCosIHNpemVfdCk7CiAKLSAgICB2b2lkIGZhc3RGcmVlKHZvaWQqIHApOworICAgIHZv aWQgZmFzdEZyZWUodm9pZCopOwogCiAjaWZuZGVmIE5ERUJVRyAgICAKICAgICB2b2lkIGZhc3RN YWxsb2NGb3JiaWQoKTsKQEAgLTE3MiwyMiArMTcyLDE1IEBAIHVzaW5nIFdURjo6ZmFzdE1hbGxv Y0FsbG93OwogI2RlZmluZSBXVEZfUFJJVkFURV9JTkxJTkUgaW5saW5lCiAjZW5kaWYKIAotI2lm bmRlZiBfQ1JUREJHX01BUF9BTExPQworI2lmICFkZWZpbmVkKF9DUlREQkdfTUFQX0FMTE9DKSAm JiAhKGRlZmluZWQoVVNFX1NZU1RFTV9NQUxMT0MpICYmIFVTRV9TWVNURU1fTUFMTE9DKQogCi0j aWYgIWRlZmluZWQoVVNFX1NZU1RFTV9NQUxMT0MpIHx8ICEoVVNFX1NZU1RFTV9NQUxMT0MpCiBX VEZfUFJJVkFURV9JTkxJTkUgdm9pZCogb3BlcmF0b3IgbmV3KHNpemVfdCBzKSB7IHJldHVybiBm YXN0TWFsbG9jKHMpOyB9CitXVEZfUFJJVkFURV9JTkxJTkUgdm9pZCogb3BlcmF0b3IgbmV3KHNp emVfdCBzLCBjb25zdCBzdGQ6Om5vdGhyb3dfdCYpIHRocm93KCkgeyByZXR1cm4gdHJ5RmFzdE1h bGxvYyhzKTsgfQogV1RGX1BSSVZBVEVfSU5MSU5FIHZvaWQgb3BlcmF0b3IgZGVsZXRlKHZvaWQq IHApIHsgZmFzdEZyZWUocCk7IH0KIFdURl9QUklWQVRFX0lOTElORSB2b2lkKiBvcGVyYXRvciBu ZXdbXShzaXplX3QgcykgeyByZXR1cm4gZmFzdE1hbGxvYyhzKTsgfQorV1RGX1BSSVZBVEVfSU5M SU5FIHZvaWQqIG9wZXJhdG9yIG5ld1tdKHNpemVfdCBzLCBjb25zdCBzdGQ6Om5vdGhyb3dfdCYp IHRocm93KCkgeyByZXR1cm4gdHJ5RmFzdE1hbGxvYyhzKTsgfQogV1RGX1BSSVZBVEVfSU5MSU5F IHZvaWQgb3BlcmF0b3IgZGVsZXRlW10odm9pZCogcCkgeyBmYXN0RnJlZShwKTsgfQogCi0jaWYg UExBVEZPUk0oV0lOQ0UpCi1XVEZfUFJJVkFURV9JTkxJTkUgdm9pZCogb3BlcmF0b3IgbmV3KHNp emVfdCBzLCBjb25zdCBzdGQ6Om5vdGhyb3dfdCYpIHRocm93KCkgeyByZXR1cm4gZmFzdE1hbGxv YyhzKTsgfQotV1RGX1BSSVZBVEVfSU5MSU5FIHZvaWQgb3BlcmF0b3IgZGVsZXRlKHZvaWQqIHAs IGNvbnN0IHN0ZDo6bm90aHJvd190JikgdGhyb3coKSB7IGZhc3RGcmVlKHApOyB9Ci1XVEZfUFJJ VkFURV9JTkxJTkUgdm9pZCogb3BlcmF0b3IgbmV3W10oc2l6ZV90IHMsIGNvbnN0IHN0ZDo6bm90 aHJvd190JikgdGhyb3coKSB7IHJldHVybiBmYXN0TWFsbG9jKHMpOyB9Ci1XVEZfUFJJVkFURV9J TkxJTkUgdm9pZCBvcGVyYXRvciBkZWxldGVbXSh2b2lkKiBwLCBjb25zdCBzdGQ6Om5vdGhyb3df dCYpIHRocm93KCkgeyBmYXN0RnJlZShwKTsgfQogI2VuZGlmCi0jZW5kaWYKLQotI2VuZGlmIC8v IF9DUlREQkdfTUFQX0FMTE9DCiAKICNlbmRpZiAvKiBXVEZfRmFzdE1hbGxvY19oICovCg==