28147 2009-08-10 08:04:49 -0700 Qt build skips fast/borders/border-radius-split-inline.html when it is unnecessary 2009-08-11 09:49:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mifenton webkit-unassigned kenneth oldest_to_newest 138651 0 mifenton 2009-08-10 08:04:49 -0700 Currently the test fast/borders/border-radius-split-inline.html is being skipped because of questionable results, however, results should be added as the test is in fact functioning correctly. The test sets up the css to split a string at 200px, which according to the test (and text used in the test) should result in the string being split over 3 lines. However, in qtwebkit, the font drawing results in this test being drawn over 4 lines instead of 3, while still maintaining the split at 200px, which is what the test is designed to verify. NOTE: When compared with the drawing in FireFox, the test is also split across 4 lines visually appearing identical to the results of running in QtLauncher. 138679 1 34475 mifenton 2009-08-10 08:23:50 -0700 Created attachment 34475 Patch to remove border-radius-split-inline from platform/qt/Skipped and add test results. 138681 2 34475 eric 2009-08-10 09:01:08 -0700 Comment on attachment 34475 Patch to remove border-radius-split-inline from platform/qt/Skipped and add test results. More of the bug description should have been in the ChangeLog. Specifically that the results match FF even though they disagree with other webkit port expectations. Do you believe this test just needs to be re-written? Do we know why it's wrapping to 4 lines? I assume font-sizing differences? 138689 3 34477 mifenton 2009-08-10 09:28:43 -0700 Created attachment 34477 Replace patch with extended ChangeLog. Updated patch with more detailed Changelog. The extra wrapping is due to the font size as surmised. The original test could also be changed to not provide a number of lines but as this currently is only affecting the Qt port, I don't know that it warrants changing the test for every platform. 138994 4 34477 kenneth 2009-08-11 09:48:51 -0700 Comment on attachment 34477 Replace patch with extended ChangeLog. Landed in 47034 34475 2009-08-10 08:23:50 -0700 2009-08-10 09:28:43 -0700 Patch to remove border-radius-split-inline from platform/qt/Skipped and add test results. BorderRadiusSplitTestResults.diff text/plain 2273 mifenton ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5YzY5MTAzLi5hYTMxYjUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDgt MTAgIE1pa2UgRmVudG9uICA8bWlrZS5mZW50b25AdG9yY2htb2JpbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCByZXN1bHRzIGZvciBm YXN0L2JvcmRlcnMvYm9yZGVyLXJhZGl1cy1zcGxpdC1pbmxpbmUgYW5kIHJlbW92ZSBmcm9tIHBs YXRmb3JtL3F0L1NraXBwZWQKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjgxNDcKKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisgICAg ICAgICogcGxhdGZvcm0vcXQvZmFzdC9ib3JkZXJzL2JvcmRlci1yYWRpdXMtc3BsaXQtaW5saW5l LWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMDktMDgtMDYgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9xdC9Ta2lwcGVkCmluZGV4IGUzMTAyMmQuLmM5NzVmNWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tp cHBlZApAQCAtNTEzMCw2ICs1MTMwLDUgQEAgcHJpbnRpbmcvbWVkaWEtcXVlcmllcy1wcmludC5o dG1sCiAjIEZpbmFsIGZvdXIgdGVzdHMgYmVmb3JlIFF0IGJ1aWxkYm90IGlzIGdyZWVuCiAjIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzkxNAogZmFzdC9jc3MvcG9z aXRpb25lZC1vdmVyZmxvdy1zY3JvbGwuaHRtbAotZmFzdC9ib3JkZXJzL2JvcmRlci1yYWRpdXMt c3BsaXQtaW5saW5lLmh0bWwKIGZhc3QvZm9ybXMvc2VsZWN0LXBvcHVwLXBhZ2VrZXlzLmh0bWwK IGZhc3QvZG9tL3Byb3RvdHlwZS1pbmhlcml0YW5jZS0yLmh0bWwKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvYm9yZGVycy9ib3JkZXItcmFkaXVzLXNwbGl0LWlubGlu ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2JvcmRlcnMvYm9y ZGVyLXJhZGl1cy1zcGxpdC1pbmxpbmUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLjMxNDZkYTAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC9mYXN0L2JvcmRlcnMvYm9yZGVyLXJhZGl1cy1zcGxpdC1pbmxpbmUtZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMTYgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBS ZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4 MjY3CisgIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHgyNjcKKyAgICBSZW5k ZXJCb2R5IHtCT0RZfSBhdCAoOCwxMykgc2l6ZSA3ODR4MjQ2CisgICAgICBSZW5kZXJCbG9jayB7 UH0gYXQgKDAsMCkgc2l6ZSA3ODR4MTcKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgw LDApIHNpemUgMzA1eDE3CisgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggMzA1OiAi VGVzdHMgYm9yZGVyLXJhZGl1cyBhbmQgYm94LXNoYWRvdyBvbiBhIHNwbGl0IGlubGluZS4iCisg ICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMCwzMCkgc2l6ZSAyMDB4MjE2CisgICAgICAgIFJl bmRlcklubGluZSB7U1BBTn0gYXQgKDAsMCkgc2l6ZSAxODB4MjA3IFtib3JkZXI6ICgycHggc29s aWQgIzAwODAwMCldCisgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgyLDYpIHNpemUg MTgweDIwMworICAgICAgICAgICAgdGV4dCBydW4gYXQgKDIsNikgd2lkdGggMTY5OiAiSSBhbSBh IHNwYW4iCisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCw2MCkgd2lkdGggMTgwOiAid2hpY2gg aXMgc3BsaXQiCisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwxMTQpIHdpZHRoIDE0NjogIm92 ZXIgdGhyZWUiCisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwxNjgpIHdpZHRoIDY2OiAibGlu ZXMiCisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDB4MAo= 34477 2009-08-10 09:28:43 -0700 2009-08-11 09:48:51 -0700 Replace patch with extended ChangeLog. BorderRadiusSplitTestResults.diff text/plain 2440 mifenton ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5YzY5MTAzLi5hYTMxYjUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDgt MTAgIE1pa2UgRmVudG9uICA8bWlrZS5mZW50b25AdG9yY2htb2JpbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCByZXN1bHRzIGZvciBm YXN0L2JvcmRlcnMvYm9yZGVyLXJhZGl1cy1zcGxpdC1pbmxpbmUgYW5kIHJlbW92ZSBmcm9tIHBs YXRmb3JtL3F0L1NraXBwZWQKKyAgICAgICAgTm90ZTogUmVzdWx0cyB3aWxsIHdyYXAgdG8gNCBs aW5lcyBldmVuIHRob3VnaCBpdCBpbmRpY2F0ZXMgMyBsaW5lcy4gIFRoaXMgaXMgZHVlIHRvIGZv bnQKKyAgICAgICAgc2l6ZSBkaWZmZXJlbmNlcyBpbiBRdCwgYW5kIG1hdGNoZXMgdGhlIG91dHB1 dCBvZiBGaXJlRm94LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yODE0NworCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKyAgICAgICAg KiBwbGF0Zm9ybS9xdC9mYXN0L2JvcmRlcnMvYm9yZGVyLXJhZGl1cy1zcGxpdC1pbmxpbmUtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAwOS0wOC0wNiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 L1NraXBwZWQKaW5kZXggZTMxMDIyZC4uYzk3NWY1ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVk CkBAIC01MTMwLDYgKzUxMzAsNSBAQCBwcmludGluZy9tZWRpYS1xdWVyaWVzLXByaW50Lmh0bWwK ICMgRmluYWwgZm91ciB0ZXN0cyBiZWZvcmUgUXQgYnVpbGRib3QgaXMgZ3JlZW4KICMgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3OTE0CiBmYXN0L2Nzcy9wb3NpdGlv bmVkLW92ZXJmbG93LXNjcm9sbC5odG1sCi1mYXN0L2JvcmRlcnMvYm9yZGVyLXJhZGl1cy1zcGxp dC1pbmxpbmUuaHRtbAogZmFzdC9mb3Jtcy9zZWxlY3QtcG9wdXAtcGFnZWtleXMuaHRtbAogZmFz dC9kb20vcHJvdG90eXBlLWluaGVyaXRhbmNlLTIuaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vcXQvZmFzdC9ib3JkZXJzL2JvcmRlci1yYWRpdXMtc3BsaXQtaW5saW5lLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvYm9yZGVycy9ib3JkZXIt cmFkaXVzLXNwbGl0LWlubGluZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uMzE0NmRhMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L2Zhc3QvYm9yZGVycy9ib3JkZXItcmFkaXVzLXNwbGl0LWlubGluZS1leHBlY3RlZC50 eHQKQEAgLTAsMCArMSwxNiBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRl clZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXplIDgwMHgyNjcK KyAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDI2NworICAgIFJlbmRlckJv ZHkge0JPRFl9IGF0ICg4LDEzKSBzaXplIDc4NHgyNDYKKyAgICAgIFJlbmRlckJsb2NrIHtQfSBh dCAoMCwwKSBzaXplIDc4NHgxNworICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkg c2l6ZSAzMDV4MTcKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAzMDU6ICJUZXN0 cyBib3JkZXItcmFkaXVzIGFuZCBib3gtc2hhZG93IG9uIGEgc3BsaXQgaW5saW5lLiIKKyAgICAg IFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDMwKSBzaXplIDIwMHgyMTYKKyAgICAgICAgUmVuZGVy SW5saW5lIHtTUEFOfSBhdCAoMCwwKSBzaXplIDE4MHgyMDcgW2JvcmRlcjogKDJweCBzb2xpZCAj MDA4MDAwKV0KKyAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDIsNikgc2l6ZSAxODB4 MjAzCisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMiw2KSB3aWR0aCAxNjk6ICJJIGFtIGEgc3Bh biIKKyAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDYwKSB3aWR0aCAxODA6ICJ3aGljaCBpcyBz cGxpdCIKKyAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDExNCkgd2lkdGggMTQ2OiAib3ZlciB0 aHJlZSIKKyAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDE2OCkgd2lkdGggNjY6ICJsaW5lcyIK KyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCg==