28146 2009-08-10 07:08:37 -0700 Allow Inspector's Number.toString to print low-resolution values 2009-08-12 01:00:24 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 0 mnaganov webkit-unassigned eric pfeldman timothy oldest_to_newest 138639 0 mnaganov 2009-08-10 07:08:37 -0700 Currently, Number.toString always prints high-resolution values in KBs and MBs (e.g. 1.234MB). My intention is to allow it to print coarse-grained values (no digits after the decimal point.) 138640 1 34450 mnaganov 2009-08-10 07:15:36 -0700 Created attachment 34450 Proposed change 138685 2 timothy 2009-08-10 09:14:23 -0700 What is the reason for this addition? 138916 3 mnaganov 2009-08-11 00:12:19 -0700 I'm working on the heap profiling page for Chromium. I have one place where I'm displaying memory stats (as a subtitle for memory snapshot items), and there I don't need excessive precision provided by the default version of Number.bytesToString. That's why I decided to provide 'low-res' argument to it. You can check out the current look of the Heap page here: http://build.chromium.org/buildbot/continuous/mac/2009-08-10/22915/chrome-mac.zip As I'm planning to upstream it to WebKit some day, so let's discuss it. The current view is very simple, I have more functionality to add. 139275 4 pfeldman 2009-08-12 01:00:24 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/utilities.js Committed r47095 34450 2009-08-10 07:15:36 -0700 2009-08-11 09:30:06 -0700 Proposed change bytesToString-patch text/plain 1833 mnaganov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzliNmI1Yy4uNmJlYjQ5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wOC0xMCAgTWlraGFpbCBOYWdh bm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZWQgTnVtYmVyLmJ5dGVzVG9TdHJpbmcgdG8gc3Vw cG9ydCBsb3ctcmVzb2x1dGlvbiBvdXRwdXQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI4MTQ2CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL3V0aWxpdGllcy5qczoKKyAgICAgICAgKE51bWJlci5ieXRlc1RvU3RyaW5nKToKKwogMjAw OS0wOC0xMCAgQW5keSBTaGF3IDxhbmR5LnNoYXdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL3V0aWxpdGllcy5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRp ZXMuanMKaW5kZXggZWVjMGI4Ny4uOTc4ZTU4YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvdXRpbGl0aWVzLmpzCkBAIC03OTAsMjAgKzc5MCwyNyBAQCBOdW1iZXIuc2Vjb25kc1RvU3Ry aW5nID0gZnVuY3Rpb24oc2Vjb25kcywgZm9ybWF0dGVyRnVuY3Rpb24sIGhpZ2hlclJlc29sdXRp b24pCiAgICAgcmV0dXJuIGZvcm1hdHRlckZ1bmN0aW9uKCIlLjFmIGRheXMiLCBkYXlzKTsKIH0K IAotTnVtYmVyLmJ5dGVzVG9TdHJpbmcgPSBmdW5jdGlvbihieXRlcywgZm9ybWF0dGVyRnVuY3Rp b24pCitOdW1iZXIuYnl0ZXNUb1N0cmluZyA9IGZ1bmN0aW9uKGJ5dGVzLCBmb3JtYXR0ZXJGdW5j dGlvbiwgaGlnaGVyUmVzb2x1dGlvbikKIHsKICAgICBpZiAoIWZvcm1hdHRlckZ1bmN0aW9uKQog ICAgICAgICBmb3JtYXR0ZXJGdW5jdGlvbiA9IFN0cmluZy5zcHJpbnRmOworICAgIGlmICh0eXBl b2YgaGlnaGVyUmVzb2x1dGlvbiA9PT0gInVuZGVmaW5lZCIpCisgICAgICAgIGhpZ2hlclJlc29s dXRpb24gPSB0cnVlOwogCiAgICAgaWYgKGJ5dGVzIDwgMTAyNCkKICAgICAgICAgcmV0dXJuIGZv cm1hdHRlckZ1bmN0aW9uKCIlLjBmQiIsIGJ5dGVzKTsKIAogICAgIHZhciBraWxvYnl0ZXMgPSBi eXRlcyAvIDEwMjQ7Ci0gICAgaWYgKGtpbG9ieXRlcyA8IDEwMjQpCisgICAgaWYgKGhpZ2hlclJl c29sdXRpb24gJiYga2lsb2J5dGVzIDwgMTAyNCkKICAgICAgICAgcmV0dXJuIGZvcm1hdHRlckZ1 bmN0aW9uKCIlLjJmS0IiLCBraWxvYnl0ZXMpOworICAgIGVsc2UgaWYgKGtpbG9ieXRlcyA8IDEw MjQpCisgICAgICAgIHJldHVybiBmb3JtYXR0ZXJGdW5jdGlvbigiJS4wZktCIiwga2lsb2J5dGVz KTsKIAogICAgIHZhciBtZWdhYnl0ZXMgPSBraWxvYnl0ZXMgLyAxMDI0OwotICAgIHJldHVybiBm b3JtYXR0ZXJGdW5jdGlvbigiJS4zZk1CIiwgbWVnYWJ5dGVzKTsKKyAgICBpZiAoaGlnaGVyUmVz b2x1dGlvbikKKyAgICAgICAgcmV0dXJuIGZvcm1hdHRlckZ1bmN0aW9uKCIlLjNmTUIiLCBtZWdh Ynl0ZXMpOworICAgIGVsc2UKKyAgICAgICAgcmV0dXJuIGZvcm1hdHRlckZ1bmN0aW9uKCIlLjBm TUIiLCBtZWdhYnl0ZXMpOwogfQogCiBOdW1iZXIuY29uc3RyYWluID0gZnVuY3Rpb24obnVtLCBt aW4sIG1heCkK