<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>28121</bug_id>
          
          <creation_ts>2009-08-09 04:41:31 -0700</creation_ts>
          <short_desc>[Haiku] Modifications on JavaScriptCore.</short_desc>
          <delta_ts>2009-08-11 12:51:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Maxime Simon">simon.maxime</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>eric</cc>
    
    <cc>leavengood</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>138475</commentid>
    <comment_count>0</comment_count>
    <who name="Maxime Simon">simon.maxime</who>
    <bug_when>2009-08-09 04:41:31 -0700</bug_when>
    <thetext>Some modifications on JavaScriptCore files to allow the the port.
It also adds a missing header on wtf/haiku/MainThreadHaiku.cpp

Regards,
Maxime</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138476</commentid>
    <comment_count>1</comment_count>
      <attachid>34406</attachid>
    <who name="Maxime Simon">simon.maxime</who>
    <bug_when>2009-08-09 04:50:36 -0700</bug_when>
    <thetext>Created attachment 34406
Modifications on JavaScriptCore to allow Haiku port.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138506</commentid>
    <comment_count>2</comment_count>
      <attachid>34406</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-09 07:39:28 -0700</bug_when>
    <thetext>Comment on attachment 34406
Modifications on JavaScriptCore to allow Haiku port.

Bah!  We need to abstract the Collector to use some sort of Threading* abstraction!

This is the 3rd patch I&apos;ve reviewed this week to add #ifdefs there. :(

+#include &quot;platform/NotImplemented.h&quot;

should be &quot;NotImplemented.h&quot; no need for &quot;platform/&quot;

r- for the wrong include path.  If you&apos;d be kind enough to fix the threading abstraction in some way (e.g. to at least use a static inline function for the Haiku case that would be nice.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138508</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-09 07:40:09 -0700</bug_when>
    <thetext>(Btw, I&apos;m not mad about the collector thing.  I&apos;m just annoyed that no one has abstracted it yet, and that we&apos;ve had so may contributions recently to that #ifdef madness file.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138524</commentid>
    <comment_count>4</comment_count>
    <who name="Ryan Leavengood">leavengood</who>
    <bug_when>2009-08-09 08:32:58 -0700</bug_when>
    <thetext>Eric,

We are definitely interested in improving the general WebKit code as well as having our port code done &quot;better&quot;. In this case some more details on what exactly you are looking for would help.

It seems like even if we added a ThreadingHaiku.cpp and a new static inline method to get the stack base there would still need to be an #elif PLATFORM(HAIKU) in currentThreadStackBase in Collector.cpp.

I suppose the best solution is to move all the associated thread stack base code for all platforms in their respective Threading* classes and then just call that function from Collector.cpp. I suppose that would be your &quot;ideal&quot; solution, right?

Of course there are no files ThreadingSolaris, ThreadingSymbian, ThreadingBSD, ThreadingWinCE, or ThreadingHaiku yet. It seems like the stack base needs to be abstracted out at another level maybe. Or ThreadingPthreads can just have #ifdefs for the various pthread platforms to get the stack base in all those ways. Maybe WinCE could be stuck in with ThreadingWin, since ThreadingWin would need at least 3 #ifdefs as it is for the stack base.

It is definitely a tricky problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138529</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-09 09:00:42 -0700</bug_when>
    <thetext>I think asking you to fix this #ifdef battleground is unecessary.  Your #ifdefs are OK.  the r- was mostly for the include name being wrong.

Maybe in the end we&apos;ll move all this #ifdeffed code out into a .cpp file which can be included by Collector.cpp.  Then at least Collector.cpp could have some semblance of x-platform-ness, and all the #ifdef crud can be elsewhere.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138530</commentid>
    <comment_count>6</comment_count>
      <attachid>34424</attachid>
    <who name="Maxime Simon">simon.maxime</who>
    <bug_when>2009-08-09 09:07:40 -0700</bug_when>
    <thetext>Created attachment 34424
Modifications on JavaScriptCore to allow Haiku port.

This patch doesn&apos;t change anything else but the bad include.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138531</commentid>
    <comment_count>7</comment_count>
      <attachid>34424</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-09 09:43:21 -0700</bug_when>
    <thetext>Comment on attachment 34424
Modifications on JavaScriptCore to allow Haiku port.

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139068</commentid>
    <comment_count>8</comment_count>
      <attachid>34424</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-11 12:51:20 -0700</bug_when>
    <thetext>Comment on attachment 34424
Modifications on JavaScriptCore to allow Haiku port.

Clearing review flag on attachment: 34424

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/runtime/Collector.cpp
	M	JavaScriptCore/wtf/Platform.h
	M	JavaScriptCore/wtf/haiku/MainThreadHaiku.cpp
Committed r47050
	M	JavaScriptCore/runtime/Collector.cpp
	M	JavaScriptCore/wtf/haiku/MainThreadHaiku.cpp
	M	JavaScriptCore/wtf/Platform.h
	M	JavaScriptCore/ChangeLog
r47050 = b11f14b641a8c5357b1ee13ba14846834ae2311e (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47050</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139069</commentid>
    <comment_count>9</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-11 12:51:24 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34406</attachid>
            <date>2009-08-09 04:50:36 -0700</date>
            <delta_ts>2009-08-09 09:07:40 -0700</delta_ts>
            <desc>Modifications on JavaScriptCore to allow Haiku port.</desc>
            <filename>Modifications-on-JavaScriptCore-to-allow-Haiku-port.patch</filename>
            <type>text/plain</type>
            <size>4613</size>
            <attacher name="Maxime Simon">simon.maxime</attacher>
            
              <data encoding="base64">RnJvbSAwYjY4ZGQ1ZmRiZjY0MGVhNDZmYWYyMjRkMTdiNjdlM2JiNTc3ODc5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXhpbWUgU2ltb24gPHNpbW9uLm1heGltZUBnbWFpbC5jb20+
CkRhdGU6IFN1biwgOSBBdWcgMjAwOSAxMzo0ODo0MCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIE1v
ZGlmaWNhdGlvbnMgb24gSmF2YVNjcmlwdENvcmUgdG8gYWxsb3cgSGFpa3UgcG9ydC4KCi0tLQog
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgfCAgIDEyICsrKysr
KysrKysrKwogSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2xsZWN0b3IuY3BwICAgICAgICAgfCAg
IDEwICsrKysrKysrKysKIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oICAgICAgICAgICAg
ICAgIHwgICAyMCArKysrKysrKysrKysrKysrKy0tLQogSmF2YVNjcmlwdENvcmUvd3RmL2hhaWt1
L01haW5UaHJlYWRIYWlrdS5jcHAgfCAgICAxICsKIDQgZmlsZXMgY2hhbmdlZCwgNDAgaW5zZXJ0
aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFu
Z2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggNWY3NWE2ZS4uNTI2N2Q0YiAx
MDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3Jl
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTA4LTA5ICBNYXhpbWUgU2ltb24gIDxz
aW1vbi5tYXhpbWVAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIE1vZGlmaWNhdGlvbnMgb24gSmF2YVNjcmlwdENvcmUgdG8gYWxsb3cg
SGFpa3UgcG9ydC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTI4MTIxCisKKyAgICAgICAgKiBydW50aW1lL0NvbGxlY3Rvci5jcHA6IEhhaWt1IGRvZXNu
J3QgaGF2ZSBzeXMvbW1hbi5oLCB1c2luZyBPUy5oIGluc3RlYWQuCisgICAgICAgIChKU0M6OmN1
cnJlbnRUaHJlYWRTdGFja0Jhc2UpOiBIYWlrdSB1c2VzIGl0cyBvd24gdGhyZWFkaW5nIHN5c3Rl
bS4KKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDogRGVmaW5pbmcgYWxsIEhhaWt1IHBsYXRmb3Jt
IHZhbHVlcy4KKyAgICAgICAgKiB3dGYvaGFpa3UvTWFpblRocmVhZEhhaWt1LmNwcDogQWRkaW5n
IGEgbWlzc2luZyBoZWFkZXIgKE5vdEltcGxlbWVudGVkLmgpLgorCiAyMDA5LTA4LTA4ICBPbGl2
ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBT
ZWlkZWwgYW5kIFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l
L0NvbGxlY3Rvci5jcHAgYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5jcHAKaW5k
ZXggOWE2MTk4MC4uZTQ1MTIzMyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9D
b2xsZWN0b3IuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29sbGVjdG9yLmNwcApA
QCAtNTgsMTAgKzU4LDE2IEBACiAKICNpbmNsdWRlIDx3aW5kb3dzLmg+CiAKKyNlbGlmIFBMQVRG
T1JNKEhBSUtVKQorCisjaW5jbHVkZSA8T1MuaD4KKwogI2VsaWYgUExBVEZPUk0oVU5JWCkKIAog
I2luY2x1ZGUgPHN0ZGxpYi5oPgorI2lmICFQTEFURk9STShIQUlLVSkKICNpbmNsdWRlIDxzeXMv
bW1hbi5oPgorI2VuZGlmCiAjaW5jbHVkZSA8dW5pc3RkLmg+CiAKICNpZiBQTEFURk9STShTT0xB
UklTKQpAQCAtNTI4LDYgKzUzNCwxMCBAQCBzdGF0aWMgaW5saW5lIHZvaWQqIGN1cnJlbnRUaHJl
YWRTdGFja0Jhc2UoKQogICAgICAgICBzdGFja0Jhc2UgPSAodm9pZCopaW5mby5pQmFzZTsKICAg
ICB9CiAgICAgcmV0dXJuICh2b2lkKilzdGFja0Jhc2U7CisjZWxpZiBQTEFURk9STShIQUlLVSkK
KyAgICB0aHJlYWRfaW5mbyB0aHJlYWRJbmZvOworICAgIGdldF90aHJlYWRfaW5mbyhmaW5kX3Ro
cmVhZChOVUxMKSwgJnRocmVhZEluZm8pOworICAgIHJldHVybiB0aHJlYWRJbmZvLnN0YWNrX2Vu
ZDsKICNlbGlmIFBMQVRGT1JNKFVOSVgpCiAgICAgc3RhdGljIHZvaWQqIHN0YWNrQmFzZSA9IDA7
CiAgICAgc3RhdGljIHNpemVfdCBzdGFja1NpemUgPSAwOwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlw
dENvcmUvd3RmL1BsYXRmb3JtLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAppbmRl
eCAwODFlYzQ3Li5iYzk0NmQ3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZv
cm0uaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaApAQCAtMTE4LDcgKzExOCw4
IEBACiAgICB8fCBkZWZpbmVkKHVuaXgpICAgICAgICBcCiAgICB8fCBkZWZpbmVkKF9fdW5peCkg
ICAgICBcCiAgICB8fCBkZWZpbmVkKF9fdW5peF9fKSAgICBcCi0gICB8fCBkZWZpbmVkKF9BSVgp
CisgICB8fCBkZWZpbmVkKF9BSVgpICAgICAgICBcCisgICB8fCBkZWZpbmVkKF9fSEFJS1VfXykK
ICNkZWZpbmUgV1RGX1BMQVRGT1JNX1VOSVggMQogI2VuZGlmCiAKQEAgLTE0Myw2ICsxNDQsOCBA
QAogI2RlZmluZSBXVEZfUExBVEZPUk1fV1ggMQogI2VsaWYgZGVmaW5lZChCVUlMRElOR19HVEtf
XykKICNkZWZpbmUgV1RGX1BMQVRGT1JNX0dUSyAxCisjZWxpZiBkZWZpbmVkKEJVSUxESU5HX0hB
SUtVX18pCisjZGVmaW5lIFdURl9QTEFURk9STV9IQUlLVSAxCiAjZWxpZiBQTEFURk9STShEQVJX
SU4pCiAjZGVmaW5lIFdURl9QTEFURk9STV9NQUMgMQogI2VsaWYgUExBVEZPUk0oV0lOX09TKQpA
QCAtMTg5LDcgKzE5Miw3IEBACiAKIC8qIE1ha2VzIFBMQVRGT1JNKFdJTikgZGVmYXVsdCB0byBQ
TEFURk9STShDQUlSTykgKi8KIC8qIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBjaGFuZ2VkIGZyb20g
YSBibGFja2xpc3QgdG8gYSB3aGl0ZWxpc3QgKi8KLSNpZiAhUExBVEZPUk0oTUFDKSAmJiAhUExB
VEZPUk0oUVQpICYmICFQTEFURk9STShXWCkgJiYgIVBMQVRGT1JNKENIUk9NSVVNKSAmJiAhUExB
VEZPUk0oV0lOQ0UpCisjaWYgIVBMQVRGT1JNKE1BQykgJiYgIVBMQVRGT1JNKFFUKSAmJiAhUExB
VEZPUk0oV1gpICYmICFQTEFURk9STShDSFJPTUlVTSkgJiYgIVBMQVRGT1JNKFdJTkNFKSAmJiAh
UExBVEZPUk0oSEFJS1UpCiAjZGVmaW5lIFdURl9QTEFURk9STV9DQUlSTyAxCiAjZW5kaWYKIApA
QCAtNDI3LDYgKzQzMCwxNCBAQAogI2VuZGlmCiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKEhBSUtV
KQorI2RlZmluZSBIQVZFX1BPU0lYX01FTUFMSUdOIDEKKyNkZWZpbmUgV1RGX1VTRV9DVVJMIDEK
KyNkZWZpbmUgV1RGX1VTRV9QVEhSRUFEUyAxCisjZGVmaW5lIFVTRV9TWVNURU1fTUFMTE9DIDEK
KyNkZWZpbmUgRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEkgMAorI2VuZGlmCisKICNpZiAhZGVm
aW5lZChIQVZFX0FDQ0VTU0lCSUxJVFkpCiAjaWYgUExBVEZPUk0oSVBIT05FKSB8fCBQTEFURk9S
TShNQUMpIHx8IFBMQVRGT1JNKFdJTikgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShDSFJP
TUlVTSkKICNkZWZpbmUgSEFWRV9BQ0NFU1NJQklMSVRZIDEKQEAgLTQzNyw3ICs0NDgsNyBAQAog
I2RlZmluZSBIQVZFX1NJR05BTF9IIDEKICNlbmRpZgogCi0jaWYgIVBMQVRGT1JNKFdJTl9PUykg
JiYgIVBMQVRGT1JNKFNPTEFSSVMpICYmICFQTEFURk9STShTWU1CSUFOKSAmJiAhQ09NUElMRVIo
UlZDVCkKKyNpZiAhUExBVEZPUk0oV0lOX09TKSAmJiAhUExBVEZPUk0oU09MQVJJUykgJiYgIVBM
QVRGT1JNKFNZTUJJQU4pICYmICFQTEFURk9STShIQUlLVSkgJiYgIUNPTVBJTEVSKFJWQ1QpCiAj
ZGVmaW5lIEhBVkVfVE1fR01UT0ZGIDEKICNkZWZpbmUgSEFWRV9UTV9aT05FIDEKICNkZWZpbmUg
SEFWRV9USU1FR00gMQpAQCAtNDkyLDcgKzUwMywxMCBAQAogLyogRklYTUU6IGlzIHRoaXMgYWN0
dWFsbHkgdXNlZCBvciBkbyBvdGhlciBwbGF0Zm9ybXMgZ2VuZXJhdGUgdGhlaXIgb3duIGNvbmZp
Zy5oPyAqLwogCiAjZGVmaW5lIEhBVkVfRVJSTk9fSCAxCisvKiBBcyBsb25nIGFzIEhhaWt1IGRv
ZXNuJ3QgaGF2ZSBhIGNvbXBsZXRlIHN1cHBvcnQgb2YgbG9jYWxlIHRoaXMgd2lsbCBiZSBkaXNh
YmxlZC4gKi8KKyNpZiAhUExBVEZPUk0oSEFJS1UpCiAjZGVmaW5lIEhBVkVfTEFOR0lORk9fSCAx
CisjZW5kaWYKICNkZWZpbmUgSEFWRV9NTUFQIDEKICNkZWZpbmUgSEFWRV9TQlJLIDEKICNkZWZp
bmUgSEFWRV9TVFJJTkdTX0ggMQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL2hhaWt1
L01haW5UaHJlYWRIYWlrdS5jcHAgYi9KYXZhU2NyaXB0Q29yZS93dGYvaGFpa3UvTWFpblRocmVh
ZEhhaWt1LmNwcAppbmRleCA0ZmQ3YjM1Li40ZmRiY2RjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0
Q29yZS93dGYvaGFpa3UvTWFpblRocmVhZEhhaWt1LmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS93
dGYvaGFpa3UvTWFpblRocmVhZEhhaWt1LmNwcApAQCAtMzAsNiArMzAsNyBAQAogI2luY2x1ZGUg
ImNvbmZpZy5oIgogI2luY2x1ZGUgIk1haW5UaHJlYWQuaCIKIAorI2luY2x1ZGUgInBsYXRmb3Jt
L05vdEltcGxlbWVudGVkLmgiCiAKIG5hbWVzcGFjZSBXVEYgewogCi0tIAoxLjYuMy4yCgo=
</data>
<flag name="review"
          id="18587"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34424</attachid>
            <date>2009-08-09 09:07:40 -0700</date>
            <delta_ts>2009-08-11 12:51:20 -0700</delta_ts>
            <desc>Modifications on JavaScriptCore to allow Haiku port.</desc>
            <filename>Modifications-on-JavaScriptCore-to-allow-Haiku-port.patch</filename>
            <type>text/plain</type>
            <size>4604</size>
            <attacher name="Maxime Simon">simon.maxime</attacher>
            
              <data encoding="base64">RnJvbSAwYjY4ZGQ1ZmRiZjY0MGVhNDZmYWYyMjRkMTdiNjdlM2JiNTc3ODc5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXhpbWUgU2ltb24gPHNpbW9uLm1heGltZUBnbWFpbC5jb20+
CkRhdGU6IFN1biwgOSBBdWcgMjAwOSAxMzo0ODo0MCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIE1v
ZGlmaWNhdGlvbnMgb24gSmF2YVNjcmlwdENvcmUgdG8gYWxsb3cgSGFpa3UgcG9ydC4KCi0tLQog
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgfCAgIDEyICsrKysr
KysrKysrKwogSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2xsZWN0b3IuY3BwICAgICAgICAgfCAg
IDEwICsrKysrKysrKysKIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oICAgICAgICAgICAg
ICAgIHwgICAyMCArKysrKysrKysrKysrKysrKy0tLQogSmF2YVNjcmlwdENvcmUvd3RmL2hhaWt1
L01haW5UaHJlYWRIYWlrdS5jcHAgfCAgICAxICsKIDQgZmlsZXMgY2hhbmdlZCwgNDAgaW5zZXJ0
aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFu
Z2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggNWY3NWE2ZS4uNTI2N2Q0YiAx
MDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3Jl
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTA4LTA5ICBNYXhpbWUgU2ltb24gIDxz
aW1vbi5tYXhpbWVAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIE1vZGlmaWNhdGlvbnMgb24gSmF2YVNjcmlwdENvcmUgdG8gYWxsb3cg
SGFpa3UgcG9ydC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTI4MTIxCisKKyAgICAgICAgKiBydW50aW1lL0NvbGxlY3Rvci5jcHA6IEhhaWt1IGRvZXNu
J3QgaGF2ZSBzeXMvbW1hbi5oLCB1c2luZyBPUy5oIGluc3RlYWQuCisgICAgICAgIChKU0M6OmN1
cnJlbnRUaHJlYWRTdGFja0Jhc2UpOiBIYWlrdSB1c2VzIGl0cyBvd24gdGhyZWFkaW5nIHN5c3Rl
bS4KKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDogRGVmaW5pbmcgYWxsIEhhaWt1IHBsYXRmb3Jt
IHZhbHVlcy4KKyAgICAgICAgKiB3dGYvaGFpa3UvTWFpblRocmVhZEhhaWt1LmNwcDogQWRkaW5n
IGEgbWlzc2luZyBoZWFkZXIgKE5vdEltcGxlbWVudGVkLmgpLgorCiAyMDA5LTA4LTA4ICBPbGl2
ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBT
ZWlkZWwgYW5kIFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l
L0NvbGxlY3Rvci5jcHAgYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5jcHAKaW5k
ZXggOWE2MTk4MC4uZTQ1MTIzMyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9D
b2xsZWN0b3IuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29sbGVjdG9yLmNwcApA
QCAtNTgsMTAgKzU4LDE2IEBACiAKICNpbmNsdWRlIDx3aW5kb3dzLmg+CiAKKyNlbGlmIFBMQVRG
T1JNKEhBSUtVKQorCisjaW5jbHVkZSA8T1MuaD4KKwogI2VsaWYgUExBVEZPUk0oVU5JWCkKIAog
I2luY2x1ZGUgPHN0ZGxpYi5oPgorI2lmICFQTEFURk9STShIQUlLVSkKICNpbmNsdWRlIDxzeXMv
bW1hbi5oPgorI2VuZGlmCiAjaW5jbHVkZSA8dW5pc3RkLmg+CiAKICNpZiBQTEFURk9STShTT0xB
UklTKQpAQCAtNTI4LDYgKzUzNCwxMCBAQCBzdGF0aWMgaW5saW5lIHZvaWQqIGN1cnJlbnRUaHJl
YWRTdGFja0Jhc2UoKQogICAgICAgICBzdGFja0Jhc2UgPSAodm9pZCopaW5mby5pQmFzZTsKICAg
ICB9CiAgICAgcmV0dXJuICh2b2lkKilzdGFja0Jhc2U7CisjZWxpZiBQTEFURk9STShIQUlLVSkK
KyAgICB0aHJlYWRfaW5mbyB0aHJlYWRJbmZvOworICAgIGdldF90aHJlYWRfaW5mbyhmaW5kX3Ro
cmVhZChOVUxMKSwgJnRocmVhZEluZm8pOworICAgIHJldHVybiB0aHJlYWRJbmZvLnN0YWNrX2Vu
ZDsKICNlbGlmIFBMQVRGT1JNKFVOSVgpCiAgICAgc3RhdGljIHZvaWQqIHN0YWNrQmFzZSA9IDA7
CiAgICAgc3RhdGljIHNpemVfdCBzdGFja1NpemUgPSAwOwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlw
dENvcmUvd3RmL1BsYXRmb3JtLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAppbmRl
eCAwODFlYzQ3Li5iYzk0NmQ3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZv
cm0uaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaApAQCAtMTE4LDcgKzExOCw4
IEBACiAgICB8fCBkZWZpbmVkKHVuaXgpICAgICAgICBcCiAgICB8fCBkZWZpbmVkKF9fdW5peCkg
ICAgICBcCiAgICB8fCBkZWZpbmVkKF9fdW5peF9fKSAgICBcCi0gICB8fCBkZWZpbmVkKF9BSVgp
CisgICB8fCBkZWZpbmVkKF9BSVgpICAgICAgICBcCisgICB8fCBkZWZpbmVkKF9fSEFJS1VfXykK
ICNkZWZpbmUgV1RGX1BMQVRGT1JNX1VOSVggMQogI2VuZGlmCiAKQEAgLTE0Myw2ICsxNDQsOCBA
QAogI2RlZmluZSBXVEZfUExBVEZPUk1fV1ggMQogI2VsaWYgZGVmaW5lZChCVUlMRElOR19HVEtf
XykKICNkZWZpbmUgV1RGX1BMQVRGT1JNX0dUSyAxCisjZWxpZiBkZWZpbmVkKEJVSUxESU5HX0hB
SUtVX18pCisjZGVmaW5lIFdURl9QTEFURk9STV9IQUlLVSAxCiAjZWxpZiBQTEFURk9STShEQVJX
SU4pCiAjZGVmaW5lIFdURl9QTEFURk9STV9NQUMgMQogI2VsaWYgUExBVEZPUk0oV0lOX09TKQpA
QCAtMTg5LDcgKzE5Miw3IEBACiAKIC8qIE1ha2VzIFBMQVRGT1JNKFdJTikgZGVmYXVsdCB0byBQ
TEFURk9STShDQUlSTykgKi8KIC8qIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBjaGFuZ2VkIGZyb20g
YSBibGFja2xpc3QgdG8gYSB3aGl0ZWxpc3QgKi8KLSNpZiAhUExBVEZPUk0oTUFDKSAmJiAhUExB
VEZPUk0oUVQpICYmICFQTEFURk9STShXWCkgJiYgIVBMQVRGT1JNKENIUk9NSVVNKSAmJiAhUExB
VEZPUk0oV0lOQ0UpCisjaWYgIVBMQVRGT1JNKE1BQykgJiYgIVBMQVRGT1JNKFFUKSAmJiAhUExB
VEZPUk0oV1gpICYmICFQTEFURk9STShDSFJPTUlVTSkgJiYgIVBMQVRGT1JNKFdJTkNFKSAmJiAh
UExBVEZPUk0oSEFJS1UpCiAjZGVmaW5lIFdURl9QTEFURk9STV9DQUlSTyAxCiAjZW5kaWYKIApA
QCAtNDI3LDYgKzQzMCwxNCBAQAogI2VuZGlmCiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKEhBSUtV
KQorI2RlZmluZSBIQVZFX1BPU0lYX01FTUFMSUdOIDEKKyNkZWZpbmUgV1RGX1VTRV9DVVJMIDEK
KyNkZWZpbmUgV1RGX1VTRV9QVEhSRUFEUyAxCisjZGVmaW5lIFVTRV9TWVNURU1fTUFMTE9DIDEK
KyNkZWZpbmUgRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEkgMAorI2VuZGlmCisKICNpZiAhZGVm
aW5lZChIQVZFX0FDQ0VTU0lCSUxJVFkpCiAjaWYgUExBVEZPUk0oSVBIT05FKSB8fCBQTEFURk9S
TShNQUMpIHx8IFBMQVRGT1JNKFdJTikgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShDSFJP
TUlVTSkKICNkZWZpbmUgSEFWRV9BQ0NFU1NJQklMSVRZIDEKQEAgLTQzNyw3ICs0NDgsNyBAQAog
I2RlZmluZSBIQVZFX1NJR05BTF9IIDEKICNlbmRpZgogCi0jaWYgIVBMQVRGT1JNKFdJTl9PUykg
JiYgIVBMQVRGT1JNKFNPTEFSSVMpICYmICFQTEFURk9STShTWU1CSUFOKSAmJiAhQ09NUElMRVIo
UlZDVCkKKyNpZiAhUExBVEZPUk0oV0lOX09TKSAmJiAhUExBVEZPUk0oU09MQVJJUykgJiYgIVBM
QVRGT1JNKFNZTUJJQU4pICYmICFQTEFURk9STShIQUlLVSkgJiYgIUNPTVBJTEVSKFJWQ1QpCiAj
ZGVmaW5lIEhBVkVfVE1fR01UT0ZGIDEKICNkZWZpbmUgSEFWRV9UTV9aT05FIDEKICNkZWZpbmUg
SEFWRV9USU1FR00gMQpAQCAtNDkyLDcgKzUwMywxMCBAQAogLyogRklYTUU6IGlzIHRoaXMgYWN0
dWFsbHkgdXNlZCBvciBkbyBvdGhlciBwbGF0Zm9ybXMgZ2VuZXJhdGUgdGhlaXIgb3duIGNvbmZp
Zy5oPyAqLwogCiAjZGVmaW5lIEhBVkVfRVJSTk9fSCAxCisvKiBBcyBsb25nIGFzIEhhaWt1IGRv
ZXNuJ3QgaGF2ZSBhIGNvbXBsZXRlIHN1cHBvcnQgb2YgbG9jYWxlIHRoaXMgd2lsbCBiZSBkaXNh
YmxlZC4gKi8KKyNpZiAhUExBVEZPUk0oSEFJS1UpCiAjZGVmaW5lIEhBVkVfTEFOR0lORk9fSCAx
CisjZW5kaWYKICNkZWZpbmUgSEFWRV9NTUFQIDEKICNkZWZpbmUgSEFWRV9TQlJLIDEKICNkZWZp
bmUgSEFWRV9TVFJJTkdTX0ggMQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL2hhaWt1
L01haW5UaHJlYWRIYWlrdS5jcHAgYi9KYXZhU2NyaXB0Q29yZS93dGYvaGFpa3UvTWFpblRocmVh
ZEhhaWt1LmNwcAppbmRleCA0ZmQ3YjM1Li40ZmRiY2RjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0
Q29yZS93dGYvaGFpa3UvTWFpblRocmVhZEhhaWt1LmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS93
dGYvaGFpa3UvTWFpblRocmVhZEhhaWt1LmNwcApAQCAtMzAsNiArMzAsNyBAQAogI2luY2x1ZGUg
ImNvbmZpZy5oIgogI2luY2x1ZGUgIk1haW5UaHJlYWQuaCIKIAorI2luY2x1ZGUgIk5vdEltcGxl
bWVudGVkLmgiCiAKIG5hbWVzcGFjZSBXVEYgewogCi0tIAoxLjYuMy4yCgo=
</data>
<flag name="commit-queue"
          id="18606"
          type_id="3"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>