281156 2024-10-09 12:00:05 -0700 [ANGLE] Allow envvar to gate ASSERT at runtime 2024-11-07 16:13:52 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zakr webkit-unassigned djg fujii kbr kkinnunen webkit-bug-importer oldest_to_newest 2066596 0 zakr 2024-10-09 12:00:05 -0700 Add a `ANGLE_ASSERTS_OFF` environment variable that allows us to disable asserts at runtime regardless of how ANGLE was built. This is necessary due to how some of our build systems work, where we need to be able to disable asserts at runtime regardless of if we built ANGLE with the `ANGLE_ASSERT_ALWAYS_ON` or `ANGLE_ENABLE_ASSERTS` flag set. We cache the value from the `envvar`, so that we don't incur a `getenv` check on every ASSERT. Additionally, this will not impact release builds as this function is gated by a guard: `#if defined(ANGLE_ENABLE_ASSERTS)`. 2066598 1 webkit-bug-importer 2024-10-09 12:00:18 -0700 <rdar://problem/137613945> 2066601 2 zakr 2024-10-09 12:04:39 -0700 Pull request: https://github.com/WebKit/WebKit/pull/34919 2066620 3 fujii 2024-10-09 13:25:07 -0700 FWIW, We have ENABLE_WEBKIT_CONJECTURE_ASSERT env var for WebKit. bug#277938 I don't mean you have to use the same env var. 2073620 4 ews-feeder 2024-11-07 15:23:32 -0800 Committed 286306@main (0e0d62f0b2e8): <https://commits.webkit.org/286306@main> Reviewed commits have been landed. Closing PR #34919 and removing active labels. 2073638 5 ews-feeder 2024-11-07 16:13:52 -0800 Committed 286307@main (aff0b1e3ced7): <https://commits.webkit.org/286307@main> Reviewed commits have been landed. Closing PR #36353 and removing active labels.