28115 2009-08-08 15:15:04 -0700 Inspector: Console Drawer is Toggling instead of Staying Open 2009-08-11 12:37:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned eric timothy oldest_to_newest 138430 0 joepeck 2009-08-08 15:15:04 -0700 This is a regression. Typically when using the hotkey or clicking the error/warnings icon the console is forced open, but now if it is open these actions will toggle the console closed. 138431 1 34403 joepeck 2009-08-08 15:18:42 -0700 Created attachment 34403 Ensure The Drawer stays Open A new method Drawer.showView(view) ensures that: - The drawer will be open - The provided view will be showing 139065 2 34403 eric 2009-08-11 12:37:45 -0700 Comment on attachment 34403 Ensure The Drawer stays Open Clearing review flag on attachment: 34403 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/Drawer.js M WebCore/inspector/front-end/inspector.js Committed r47049 M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js M WebCore/inspector/front-end/Drawer.js r47049 = 5847ea6bf7fc1d9f761b3363a847a0978fc69389 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47049 139066 3 eric 2009-08-11 12:37:48 -0700 All reviewed patches have been landed. Closing bug. 34403 2009-08-08 15:18:42 -0700 2009-08-11 12:37:44 -0700 Ensure The Drawer stays Open ensureShowing.patch text/plain 1942 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjIyMDgxOS4uYmIzYWI1NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOC0wOCAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVjazAyQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbnNwZWN0b3I6IENvbnNvbGUgRHJhd2VyIGlzIFRvZ2dsaW5n IGluc3RlYWQgb2YgU3RheWluZyBPcGVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yODExNQorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9E cmF3ZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRHJhd2VyLnByb3RvdHlwZS5zaG93Vmll dyk6IGVuc3VyZXMgdGhlIGRyYXdlciB3aWxsIGJlIG9wZW4gYW5kIHNob3dpbmcgdGhlIHByb3Zp ZGVkIHZpZXcKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5zaG93Q29uc29sZSk6IHVzZWVzIHRoZSBuZXcgc2hvd1ZpZXcg dG8gZ3VhcmFudGVlIHRoZSBEcmF3ZXIgd2lsbCBiZSBvcGVuCisgICAgICAgIChXZWJJbnNwZWN0 b3Iuc2hvd0NoYW5nZXMpOiB1c2VzIHRoZSBuZXcgc2hvd1ZpZXcgZ3VhcmFudGVlIHRoZSBEcmF3 ZXIgd2lsbCBiZSBvcGVuCisKIDIwMDktMDgtMDggIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EcmF3ZXIuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRHJhd2VyLmpzCmluZGV4IDIzZGM0ODMuLjFiNTBmOTEgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EcmF3ZXIuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0RyYXdlci5qcwpAQCAtNjQsNiArNjQsMTIgQEAgV2ViSW5zcGVjdG9yLkRy YXdlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIH0KICAgICB9LAogCisgICAgc2hvd1ZpZXc6IGZ1 bmN0aW9uKHZpZXcpCisgICAgeworICAgICAgICBpZiAoIXRoaXMudmlzaWJsZSB8fCB0aGlzLnZp c2libGVWaWV3ICE9PSB2aWV3KQorICAgICAgICAgICAgdGhpcy52aXNpYmxlVmlldyA9IHZpZXc7 CisgICAgfSwKKwogICAgIHNob3c6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIGlmICh0aGlz Ll9hbmltYXRpbmcgfHwgdGhpcy52aXNpYmxlKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9p bnNwZWN0b3IuanMKaW5kZXggYmY4MjQzOC4uYzY3OTRmOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC04NTMsMTIgKzg1MywxMiBAQCBXZWJJbnNwZWN0b3Iu ZWxlbWVudERyYWdFbmQgPSBmdW5jdGlvbihldmVudCkKIAogV2ViSW5zcGVjdG9yLnNob3dDb25z b2xlID0gZnVuY3Rpb24oKQogewotICAgIHRoaXMuZHJhd2VyLnZpc2libGVWaWV3ID0gdGhpcy5j b25zb2xlOworICAgIHRoaXMuZHJhd2VyLnNob3dWaWV3KHRoaXMuY29uc29sZSk7CiB9CiAKIFdl Ykluc3BlY3Rvci5zaG93Q2hhbmdlcyA9IGZ1bmN0aW9uKCkKIHsKLSAgICB0aGlzLmRyYXdlci52 aXNpYmxlVmlldyA9IHRoaXMuY2hhbmdlczsKKyAgICB0aGlzLmRyYXdlci5zaG93Vmlldyh0aGlz LmNoYW5nZXMpOwogfQogCiBXZWJJbnNwZWN0b3Iuc2hvd0VsZW1lbnRzUGFuZWwgPSBmdW5jdGlv bigpCg==