28092 2009-08-07 19:18:02 -0700 webkit-patch land will land changes even if the ChangeLog is wrong (and thus make the wrong commit message) 2017-07-18 08:29:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 1 abarth webkit-unassigned aroben cjerdonek ddkilzer eric mrowe oldest_to_newest 138263 0 abarth 2009-08-07 19:18:02 -0700 http://trac.webkit.org/changeset/46933 Not sure why. I don't remember anything unusual happening when I ran the tool. 138359 1 eric 2009-08-08 10:25:16 -0700 This is a dupe of one of: https://bugs.webkit.org/show_bug.cgi?id=26730 https://bugs.webkit.org/show_bug.cgi?id=26865 https://bugs.webkit.org/show_bug.cgi?id=27355 138361 2 mrowe 2009-08-08 10:28:24 -0700 And in <http://trac.webkit.org/changeset/46928>. Can we get this fixed so we don't have bogus commit messages sprinkled throughout the SVN history? 138375 3 abarth 2009-08-08 10:38:55 -0700 Eric said on IRC: eseidel: bdash: either svn-apply or bugzilla-tool need to be taught to run resolve-ChangeLogs -f on every ChangeLog We can certainly try that and see if it helps. 138385 4 ddkilzer 2009-08-08 11:08:29 -0700 (In reply to comment #2) > And in <http://trac.webkit.org/changeset/46928>. Can we get this fixed so we > don't have bogus commit messages sprinkled throughout the SVN history? I've seen this happen with prepare-ChangeLog commits as well. (In reply to comment #3) > eseidel: bdash: either svn-apply or bugzilla-tool need to be taught to run > resolve-ChangeLogs -f on every ChangeLog > > We can certainly try that and see if it helps. I would suggest adding an -a|--all swtich to resolve-ChangeLogs (rather than changing the behavior of the -f switch) to make it attempt to fix up every ChangeLog. The -f switch has special behavior that rewrites changelogs on a range of git commits using git-filter-branch --tree-filter. 138388 5 mrowe 2009-08-08 11:13:12 -0700 (In reply to comment #4) > (In reply to comment #2) > > And in <http://trac.webkit.org/changeset/46928>. Can we get this fixed so we > > don't have bogus commit messages sprinkled throughout the SVN history? > > I've seen this happen with prepare-ChangeLog commits as well. I'm not sure what you mean. In this case it seems that the patch author put the ChangeLog at some bizarre location within the file: <https://bugs.webkit.org/attachment.cgi?id=34264&action=prettypatch>. Rather than fixing it up, bugzilla-tool left it in that location and took the first ChangeLog entry as the commit message. I don't think any of our existing scripts will automagically fix this. In <http://trac.webkit.org/changeset/46933> it just appears to be confused about where one ChangeLog entry ends and the second begins. 138435 6 ddkilzer 2009-08-08 16:01:56 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > And in <http://trac.webkit.org/changeset/46928>. Can we get this fixed so we > > > don't have bogus commit messages sprinkled throughout the SVN history? > > > > I've seen this happen with prepare-ChangeLog commits as well. > > I'm not sure what you mean. Sorry, I should have said: I've seen commit-log-editor pick the wrong changelog entries, but it was probably due to the ChangeLog entry being merged into the wrong location. 162143 7 eric 2009-11-10 11:41:37 -0800 I believe these were all caused by bug 30683, which is now resolved. We can keep this open to track adding some sort of pre-commit hook for validating ChangeLog entries (see bug 28291) if you like. Otherwise I think we can close this. Certainly I'm un-aware of any bad ChangeLog entries from bugzilla-tool or the commit-queue since the ones mentioned in this bug. 164096 8 eric 2009-11-16 14:50:51 -0800 Looks like land-diff was at fault in all of these commits. I was initially confused, thinking that this bug was accusing land-patches, which we've never seen this behavior with. http://trac.webkit.org/changeset/51033 was our most recent victim of this behavior. I guess land-diff will need to resolve-ChangeLogs. I'll try to look into it this week. 207698 9 eric 2010-04-01 23:19:24 -0700 webkit-patch land will validate that the Reviewer is correct now. However it doesn't yet validate that the ChangeLog entry being added is the top-most one. That's still on our list to do. It requires webkit-patch to have a bit of diff-parsing knowledge, which it should be able to get from the style package (check-webkit-style) which already has some minimal diff parsing. 207700 10 eric 2010-04-01 23:21:52 -0700 *** Bug 33246 has been marked as a duplicate of this bug. ***