280886 2024-10-04 07:02:33 -0700 [JHBuild] Add libspiel to minimal moduleset 2024-10-23 03:36:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=270742 InRadar P2 Normal --- 281397 1 dpino dpino commit-queue webkit-bug-importer oldest_to_newest 2065447 0 dpino 2024-10-04 07:02:33 -0700 Changeset 284276@main change speech synthesis from experimental feature to always on. It also changed the speech synthesis backend, from flite2 to libspiel. Libspiel is not packaged in any distro yet. Since the feature was removed from experimental features, the Ubuntu and Debian upstream fails failed after 284276@main. The work around the build failure we disbaledspeech synthesis in the bots (-DENABLE_SPEECH_SYNTHESIS=OFF). Since speech synthesis is always on now, support for `libspiel` should be added to JHBuild minimal moduleset, for users that would like to build with this build system. 2065450 1 dpino 2024-10-04 07:06:22 -0700 Pull request: https://github.com/webkit/webkit/pull/34696 2065832 2 ews-feeder 2024-10-07 05:23:14 -0700 Committed 284758@main (30c09a60fec7): <https://commits.webkit.org/284758@main> Reviewed commits have been landed. Closing PR #34696 and removing active labels. 2065834 3 webkit-bug-importer 2024-10-07 05:24:14 -0700 <rdar://problem/137420202> 2067570 4 commit-queue 2024-10-13 04:51:31 -0700 Re-opened since this is blocked by bug 281397 2070033 5 dpino 2024-10-23 03:36:34 -0700 After 285005@main, Libspiel is now optional and it's no longer strictly needed to enable SPEECH_SYNTHESIS. That funcionality is implemented by default by a different backend, Flite2, which is available in every major Linux distribution.