28085 2009-08-07 14:14:20 -0700 Unnecessary 'goto' confuses flow of control in WebHTMLView 2023-10-20 11:47:34 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac OS X 10.5 RESOLVED CONFIGURATION CHANGED P4 Normal --- 1 jens webkit-unassigned ahmad.saleem792 ap oldest_to_newest 138139 0 jens 2009-08-07 14:14:20 -0700 I was just looking through WebHTMLView and found this strange code in the -namesOfPromisedFilesDroppedAtDestination: method: - (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination { NSFileWrapper *wrapper = nil; NSURL *draggingImageURL = nil; if (WebCore::CachedImage* tiffResource = [self promisedDragTIFFDataSource]) { SharedBuffer *buffer = static_cast<CachedResource*>(tiffResource)->data(); if (!buffer) goto noPromisedData; ... } noPromisedData: There's no reason to use a goto there; maybe there was once some complex code in between the goto and the label, but not currently. It can easily be simplified to: if (buffer) { ... } } 1986411 1 ahmad.saleem792 2023-10-20 07:27:02 -0700 I am unable to find 'goto' as of today: https://searchfox.org/wubkat/source/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm#4343 I think this might have changed over the years and this can be marked as 'RESOLVED CONFIGURATION CHANGED'? @Alexey - no idea, who would be right person to conclude on this.