28083 2009-08-07 13:32:29 -0700 [V8] Fix the problem that isAttribute is set to false for onerror and onmessage in worker custom code. 2009-08-07 16:13:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli abarth levin oldest_to_newest 138102 0 jianli 2009-08-07 13:32:29 -0700 Fix the problem that isAttribute is set to false for onerror and onmessage in worker custom code. 138108 1 34320 jianli 2009-08-07 13:39:40 -0700 Created attachment 34320 Proposed Patch 138120 2 34320 dglazkov 2009-08-07 13:48:19 -0700 Comment on attachment 34320 Proposed Patch Wow, good catch. r=me. 138204 3 34320 abarth 2009-08-07 16:13:05 -0700 Comment on attachment 34320 Proposed Patch Clearing review flag on attachment: 34320 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/custom/V8AbstractWorkerCustom.cpp M WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp M WebCore/bindings/v8/custom/V8WorkerCustom.cpp Committed r46922 M WebCore/ChangeLog M WebCore/bindings/v8/custom/V8WorkerCustom.cpp M WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp M WebCore/bindings/v8/custom/V8AbstractWorkerCustom.cpp r46922 = 12e5c15a8427d9e3578e6eea9cf483696beb9dee (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46922 138205 4 abarth 2009-08-07 16:13:09 -0700 All reviewed patches have been landed. Closing bug. 34320 2009-08-07 13:39:40 -0700 2009-08-07 16:13:05 -0700 Proposed Patch 28083 text/plain 6625 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTdiZWU2Zi4uYmIyYWFmYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0wOC0wNyAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1Y4XSBGaXggdGhlIHByb2JsZW0gdGhhdCBpc0F0dHJpYnV0ZSBpcyBzZXQg dG8gZmFsc2UgZm9yIG9uZXJyb3IgYW5kCisgICAgICAgIG9ubWVzc2FnZSBpbiB3b3JrZXIgY3Vz dG9tIGNvZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yODA4MworCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4QWJzdHJhY3RXb3JrZXJD dXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0RXZlbnRMaXN0ZW5lcik6CisgICAgICAg IChXZWJDb3JlOjpBQ0NFU1NPUl9TRVRURVIpOgorICAgICAgICAoV2ViQ29yZTo6Q0FMTEJBQ0tf RlVOQ19ERUNMKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhXb3JrZXJDb250ZXh0 Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFDQ0VTU09SX1NFVFRFUik6CisgICAgICAg ICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4V29ya2VyQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OmdldEV2ZW50TGlzdGVuZXIpOgorICAgICAgICAoV2ViQ29yZTo6QUNDRVNTT1JfU0VUVEVS KToKKwogMjAwOS0wOC0wNyAgU3RldmUgQmxvY2sgIDxzdGV2ZWJsb2NrQGdvb2dsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOEFic3RyYWN0V29ya2VyQ3VzdG9tLmNwcCBiL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4QWJzdHJhY3RXb3JrZXJDdXN0b20uY3BwCmluZGV4IDE0ZDhiZGUu LmNlNzU5ZWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4QWJzdHJh Y3RXb3JrZXJDdXN0b20uY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4QWJz dHJhY3RXb3JrZXJDdXN0b20uY3BwCkBAIC00NSwxOCArNDUsMTggQEAKIAogbmFtZXNwYWNlIFdl YkNvcmUgewogCi1QYXNzUmVmUHRyPEV2ZW50TGlzdGVuZXI+IGdldEV2ZW50TGlzdGVuZXIoQWJz dHJhY3RXb3JrZXIqIHdvcmtlciwgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsdWUsIGJvb2wgZmlu ZE9ubHkpCitQYXNzUmVmUHRyPEV2ZW50TGlzdGVuZXI+IGdldEV2ZW50TGlzdGVuZXIoQWJzdHJh Y3RXb3JrZXIqIHdvcmtlciwgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsdWUsIGJvb2wgaXNBdHRy aWJ1dGUsIGJvb2wgZmluZE9ubHkpCiB7CiAgICAgaWYgKHdvcmtlci0+c2NyaXB0RXhlY3V0aW9u Q29udGV4dCgpLT5pc1dvcmtlckNvbnRleHQoKSkgewogICAgICAgICBXb3JrZXJDb250ZXh0RXhl Y3V0aW9uUHJveHkqIHdvcmtlckNvbnRleHRQcm94eSA9IFdvcmtlckNvbnRleHRFeGVjdXRpb25Q cm94eTo6cmV0cmlldmUoKTsKICAgICAgICAgQVNTRVJUKHdvcmtlckNvbnRleHRQcm94eSk7Ci0g ICAgICAgIHJldHVybiB3b3JrZXJDb250ZXh0UHJveHktPmZpbmRPckNyZWF0ZU9iamVjdEV2ZW50 TGlzdGVuZXIodmFsdWUsIGZhbHNlLCBmaW5kT25seSk7CisgICAgICAgIHJldHVybiB3b3JrZXJD b250ZXh0UHJveHktPmZpbmRPckNyZWF0ZU9iamVjdEV2ZW50TGlzdGVuZXIodmFsdWUsIGlzQXR0 cmlidXRlLCBmaW5kT25seSk7CiAgICAgfQogCiAgICAgVjhQcm94eSogcHJveHkgPSBWOFByb3h5 OjpyZXRyaWV2ZSh3b3JrZXItPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSk7CiAgICAgaWYgKHBy b3h5KSB7CiAgICAgICAgIFY4RXZlbnRMaXN0ZW5lckxpc3QqIGxpc3QgPSBwcm94eS0+b2JqZWN0 TGlzdGVuZXJzKCk7Ci0gICAgICAgIHJldHVybiBmaW5kT25seSA/IGxpc3QtPmZpbmRXcmFwcGVy KHZhbHVlLCBmYWxzZSkgOiBsaXN0LT5maW5kT3JDcmVhdGVXcmFwcGVyPFY4T2JqZWN0RXZlbnRM aXN0ZW5lcj4ocHJveHktPmZyYW1lKCksIHZhbHVlLCBmYWxzZSk7CisgICAgICAgIHJldHVybiBm aW5kT25seSA/IGxpc3QtPmZpbmRXcmFwcGVyKHZhbHVlLCBpc0F0dHJpYnV0ZSkgOiBsaXN0LT5m aW5kT3JDcmVhdGVXcmFwcGVyPFY4T2JqZWN0RXZlbnRMaXN0ZW5lcj4ocHJveHktPmZyYW1lKCks IHZhbHVlLCBpc0F0dHJpYnV0ZSk7CiAgICAgfQogCiAgICAgcmV0dXJuIDA7CkBAIC04OCw3ICs4 OCw3IEBAIEFDQ0VTU09SX1NFVFRFUihBYnN0cmFjdFdvcmtlck9uZXJyb3IpCiAgICAgICAgIC8v IENsZWFyIHRoZSBsaXN0ZW5lci4KICAgICAgICAgd29ya2VyLT5zZXRPbmVycm9yKDApOwogICAg IH0gZWxzZSB7Ci0gICAgICAgIFJlZlB0cjxFdmVudExpc3RlbmVyPiBsaXN0ZW5lciA9IGdldEV2 ZW50TGlzdGVuZXIod29ya2VyLCB2YWx1ZSwgZmFsc2UpOworICAgICAgICBSZWZQdHI8RXZlbnRM aXN0ZW5lcj4gbGlzdGVuZXIgPSBnZXRFdmVudExpc3RlbmVyKHdvcmtlciwgdmFsdWUsIHRydWUs IGZhbHNlKTsKICAgICAgICAgaWYgKGxpc3RlbmVyKSB7CiAgICAgICAgICAgICBpZiAob2xkTGlz dGVuZXIpIHsKICAgICAgICAgICAgICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4gb2xkVjhMaXN0 ZW5lciA9IG9sZExpc3RlbmVyLT5nZXRMaXN0ZW5lck9iamVjdCgpOwpAQCAtMTA2LDcgKzEwNiw3 IEBAIENBTExCQUNLX0ZVTkNfREVDTChBYnN0cmFjdFdvcmtlckFkZEV2ZW50TGlzdGVuZXIpCiAg ICAgSU5DX1NUQVRTKEwiRE9NLkFic3RyYWN0V29ya2VyLmFkZEV2ZW50TGlzdGVuZXIoKSIpOwog ICAgIEFic3RyYWN0V29ya2VyKiB3b3JrZXIgPSBWOERPTVdyYXBwZXI6OmNvbnZlcnRUb05hdGl2 ZU9iamVjdDxBYnN0cmFjdFdvcmtlcj4oVjhDbGFzc0luZGV4OjpBQlNUUkFDVFdPUktFUiwgYXJn cy5Ib2xkZXIoKSk7CiAKLSAgICBSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXIgPSBnZXRF dmVudExpc3RlbmVyKHdvcmtlciwgYXJnc1sxXSwgZmFsc2UpOworICAgIFJlZlB0cjxFdmVudExp c3RlbmVyPiBsaXN0ZW5lciA9IGdldEV2ZW50TGlzdGVuZXIod29ya2VyLCBhcmdzWzFdLCBmYWxz ZSwgZmFsc2UpOwogICAgIGlmIChsaXN0ZW5lcikgewogICAgICAgICBTdHJpbmcgdHlwZSA9IHRv V2ViQ29yZVN0cmluZyhhcmdzWzBdKTsKICAgICAgICAgYm9vbCB1c2VDYXB0dXJlID0gYXJnc1sy XS0+Qm9vbGVhblZhbHVlKCk7CkBAIC0xMjIsNyArMTIyLDcgQEAgQ0FMTEJBQ0tfRlVOQ19ERUNM KEFic3RyYWN0V29ya2VyUmVtb3ZlRXZlbnRMaXN0ZW5lcikKICAgICBJTkNfU1RBVFMoTCJET00u QWJzdHJhY3RXb3JrZXIucmVtb3ZlRXZlbnRMaXN0ZW5lcigpIik7CiAgICAgQWJzdHJhY3RXb3Jr ZXIqIHdvcmtlciA9IFY4RE9NV3JhcHBlcjo6Y29udmVydFRvTmF0aXZlT2JqZWN0PEFic3RyYWN0 V29ya2VyPihWOENsYXNzSW5kZXg6OkFCU1RSQUNUV09SS0VSLCBhcmdzLkhvbGRlcigpKTsKIAot ICAgIFJlZlB0cjxFdmVudExpc3RlbmVyPiBsaXN0ZW5lciA9IGdldEV2ZW50TGlzdGVuZXIod29y a2VyLCBhcmdzWzFdLCB0cnVlKTsKKyAgICBSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXIg PSBnZXRFdmVudExpc3RlbmVyKHdvcmtlciwgYXJnc1sxXSwgZmFsc2UsIHRydWUpOwogICAgIGlm IChsaXN0ZW5lcikgewogICAgICAgICBTdHJpbmcgdHlwZSA9IHRvV2ViQ29yZVN0cmluZyhhcmdz WzBdKTsKICAgICAgICAgYm9vbCB1c2VDYXB0dXJlID0gYXJnc1syXS0+Qm9vbGVhblZhbHVlKCk7 CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdvcmtlckNvbnRleHRD dXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXb3JrZXJDb250ZXh0Q3Vz dG9tLmNwcAppbmRleCAxZTNlMTI1Li5iNTI2MDQwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOFdvcmtlckNvbnRleHRDdXN0b20uY3BwCisrKyBiL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4V29ya2VyQ29udGV4dEN1c3RvbS5jcHAKQEAgLTc4LDcgKzc4LDcg QEAgQUNDRVNTT1JfU0VUVEVSKFdvcmtlckNvbnRleHRPbmVycm9yKQogICAgICAgICAvLyBDbGVh ciB0aGUgbGlzdGVuZXIuCiAgICAgICAgIHdvcmtlckNvbnRleHQtPnNldE9uZXJyb3IoMCk7CiAg ICAgfSBlbHNlIHsKLSAgICAgICAgUmVmUHRyPFY4RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXIgPSB3 b3JrZXJDb250ZXh0LT5zY3JpcHQoKS0+cHJveHkoKS0+ZmluZE9yQ3JlYXRlRXZlbnRMaXN0ZW5l cih2ODo6TG9jYWw8djg6Ok9iamVjdD46OkNhc3QodmFsdWUpLCBmYWxzZSwgZmFsc2UpOworICAg ICAgICBSZWZQdHI8VjhFdmVudExpc3RlbmVyPiBsaXN0ZW5lciA9IHdvcmtlckNvbnRleHQtPnNj cmlwdCgpLT5wcm94eSgpLT5maW5kT3JDcmVhdGVFdmVudExpc3RlbmVyKHY4OjpMb2NhbDx2ODo6 T2JqZWN0Pjo6Q2FzdCh2YWx1ZSksIHRydWUsIGZhbHNlKTsKICAgICAgICAgaWYgKGxpc3RlbmVy KSB7CiAgICAgICAgICAgICBpZiAob2xkTGlzdGVuZXIpIHsKICAgICAgICAgICAgICAgICB2ODo6 TG9jYWw8djg6Ok9iamVjdD4gb2xkVjhMaXN0ZW5lciA9IG9sZExpc3RlbmVyLT5nZXRMaXN0ZW5l ck9iamVjdCgpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXb3Jr ZXJDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXb3JrZXJDdXN0b20u Y3BwCmluZGV4IDA4ZThiZTYuLjMyNDUwYjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4V29ya2VyQ3VzdG9tLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOFdvcmtlckN1c3RvbS5jcHAKQEAgLTkzLDE4ICs5MywxOCBAQCBDQUxMQkFDS19GVU5D X0RFQ0woV29ya2VyQ29uc3RydWN0b3IpCiAgICAgcmV0dXJuIHdyYXBwZXJPYmplY3Q7CiB9CiAK LVBhc3NSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gZ2V0RXZlbnRMaXN0ZW5lcihXb3JrZXIqIHdvcmtl ciwgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsdWUsIGJvb2wgZmluZE9ubHkpCitQYXNzUmVmUHRy PEV2ZW50TGlzdGVuZXI+IGdldEV2ZW50TGlzdGVuZXIoV29ya2VyKiB3b3JrZXIsIHY4OjpMb2Nh bDx2ODo6VmFsdWU+IHZhbHVlLCBib29sIGlzQXR0cmlidXRlLCBib29sIGZpbmRPbmx5KQogewog ICAgIGlmICh3b3JrZXItPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+aXNXb3JrZXJDb250ZXh0 KCkpIHsKICAgICAgICAgV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5KiB3b3JrZXJDb250ZXh0 UHJveHkgPSBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OnJldHJpZXZlKCk7CiAgICAgICAg IEFTU0VSVCh3b3JrZXJDb250ZXh0UHJveHkpOwotICAgICAgICByZXR1cm4gd29ya2VyQ29udGV4 dFByb3h5LT5maW5kT3JDcmVhdGVPYmplY3RFdmVudExpc3RlbmVyKHZhbHVlLCBmYWxzZSwgZmlu ZE9ubHkpOworICAgICAgICByZXR1cm4gd29ya2VyQ29udGV4dFByb3h5LT5maW5kT3JDcmVhdGVP YmplY3RFdmVudExpc3RlbmVyKHZhbHVlLCBpc0F0dHJpYnV0ZSwgZmluZE9ubHkpOwogICAgIH0K IAogICAgIFY4UHJveHkqIHByb3h5ID0gVjhQcm94eTo6cmV0cmlldmUod29ya2VyLT5zY3JpcHRF eGVjdXRpb25Db250ZXh0KCkpOwogICAgIGlmIChwcm94eSkgewogICAgICAgICBWOEV2ZW50TGlz dGVuZXJMaXN0KiBsaXN0ID0gcHJveHktPm9iamVjdExpc3RlbmVycygpOwotICAgICAgICByZXR1 cm4gZmluZE9ubHkgPyBsaXN0LT5maW5kV3JhcHBlcih2YWx1ZSwgZmFsc2UpIDogbGlzdC0+Zmlu ZE9yQ3JlYXRlV3JhcHBlcjxWOE9iamVjdEV2ZW50TGlzdGVuZXI+KHByb3h5LT5mcmFtZSgpLCB2 YWx1ZSwgZmFsc2UpOworICAgICAgICByZXR1cm4gZmluZE9ubHkgPyBsaXN0LT5maW5kV3JhcHBl cih2YWx1ZSwgaXNBdHRyaWJ1dGUpIDogbGlzdC0+ZmluZE9yQ3JlYXRlV3JhcHBlcjxWOE9iamVj dEV2ZW50TGlzdGVuZXI+KHByb3h5LT5mcmFtZSgpLCB2YWx1ZSwgaXNBdHRyaWJ1dGUpOwogICAg IH0KIAogICAgIHJldHVybiAwOwpAQCAtMTM2LDcgKzEzNiw3IEBAIEFDQ0VTU09SX1NFVFRFUihX b3JrZXJPbm1lc3NhZ2UpCiAgICAgICAgIC8vIENsZWFyIHRoZSBsaXN0ZW5lci4KICAgICAgICAg d29ya2VyLT5zZXRPbm1lc3NhZ2UoMCk7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgUmVmUHRyPEV2 ZW50TGlzdGVuZXI+IGxpc3RlbmVyID0gZ2V0RXZlbnRMaXN0ZW5lcih3b3JrZXIsIHZhbHVlLCBm YWxzZSk7CisgICAgICAgIFJlZlB0cjxFdmVudExpc3RlbmVyPiBsaXN0ZW5lciA9IGdldEV2ZW50 TGlzdGVuZXIod29ya2VyLCB2YWx1ZSwgdHJ1ZSwgZmFsc2UpOwogICAgICAgICBpZiAobGlzdGVu ZXIpIHsKICAgICAgICAgICAgIGlmIChvbGRMaXN0ZW5lcikgewogICAgICAgICAgICAgICAgIHY4 OjpMb2NhbDx2ODo6T2JqZWN0PiBvbGRWOExpc3RlbmVyID0gb2xkTGlzdGVuZXItPmdldExpc3Rl bmVyT2JqZWN0KCk7Cg==