28082 2009-08-07 13:22:09 -0700 [V8] Do not register V8 error message listener in WorkerContextExecutionProxy 2009-08-07 15:36:58 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli abarth levin oldest_to_newest 138093 0 jianli 2009-08-07 13:22:09 -0700 Do not register V8 error message listener in WorkerContextExecutionProxy since now we handle and pass the error back to the worker if needed. 138096 1 34317 jianli 2009-08-07 13:26:00 -0700 Created attachment 34317 Proposed Patch 138098 2 34317 dglazkov 2009-08-07 13:27:20 -0700 Comment on attachment 34317 Proposed Patch r=me. 138191 3 34317 abarth 2009-08-07 15:36:55 -0700 Comment on attachment 34317 Proposed Patch Clearing review flag on attachment: 34317 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/WorkerContextExecutionProxy.cpp Committed r46919 M WebCore/ChangeLog M WebCore/bindings/v8/WorkerContextExecutionProxy.cpp r46919 = 37cf8fd35fbac16e349f8636622901dc7c668732 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46919 138192 4 abarth 2009-08-07 15:36:58 -0700 All reviewed patches have been landed. Closing bug. 34317 2009-08-07 13:26:00 -0700 2009-08-07 15:36:55 -0700 Proposed Patch 28082 text/plain 2336 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTdiZWU2Zi4uMDkyOWUyYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wOC0wNyAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1Y4XSBEbyBub3QgcmVnaXN0ZXIgVjggZXJyb3IgbWVzc2FnZSBsaXN0ZW5l ciBpbiBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODA4MgorCisgICAgICAgICogYmluZGluZ3Mvdjgv V29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oldvcmtl ckNvbnRleHRFeGVjdXRpb25Qcm94eTo6aW5pdFY4SWZOZWVkZWQpOgorCiAyMDA5LTA4LTA3ICBT dGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29u dGV4dEV4ZWN1dGlvblByb3h5LmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4 dEV4ZWN1dGlvblByb3h5LmNwcAppbmRleCA2MWY1ODJiLi5jOWZhOGJlIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eS5jcHAKKysrIGIv V2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuY3BwCkBAIC02 MywyNyArNjMsNiBAQCBzdGF0aWMgdm9pZCByZXBvcnRGYXRhbEVycm9ySW5WOChjb25zdCBjaGFy KiBsb2NhdGlvbiwgY29uc3QgY2hhciogbWVzc2FnZSkKICAgICBDUkFTSCgpOwogfQogCi1zdGF0 aWMgdm9pZCBoYW5kbGVDb25zb2xlTWVzc2FnZSh2ODo6SGFuZGxlPHY4OjpNZXNzYWdlPiBtZXNz YWdlLCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gZGF0YSkKLXsKLSAgICBXb3JrZXJDb250ZXh0RXhl Y3V0aW9uUHJveHkqIHByb3h5ID0gV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5OjpyZXRyaWV2 ZSgpOwotICAgIGlmICghcHJveHkpCi0gICAgICAgIHJldHVybjsKLQotICAgIFdvcmtlckNvbnRl eHQqIHdvcmtlckNvbnRleHQgPSBwcm94eS0+d29ya2VyQ29udGV4dCgpOwotICAgIGlmICghd29y a2VyQ29udGV4dCkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5n PiBlcnJvck1lc3NhZ2VTdHJpbmcgPSBtZXNzYWdlLT5HZXQoKTsKLSAgICBBU1NFUlQoIWVycm9y TWVzc2FnZVN0cmluZy5Jc0VtcHR5KCkpOwotICAgIFN0cmluZyBlcnJvck1lc3NhZ2UgPSB0b1dl YkNvcmVTdHJpbmcoZXJyb3JNZXNzYWdlU3RyaW5nKTsKLQotICAgIHY4OjpIYW5kbGU8djg6OlZh bHVlPiByZXNvdXJjZU5hbWUgPSBtZXNzYWdlLT5HZXRTY3JpcHRSZXNvdXJjZU5hbWUoKTsKLSAg ICBib29sIHVzZVVSTCA9IChyZXNvdXJjZU5hbWUuSXNFbXB0eSgpIHx8ICFyZXNvdXJjZU5hbWUt PklzU3RyaW5nKCkpOwotICAgIFN0cmluZyByZXNvdXJjZU5hbWVTdHJpbmcgPSB1c2VVUkwgPyB3 b3JrZXJDb250ZXh0LT51cmwoKSA6IHRvV2ViQ29yZVN0cmluZyhyZXNvdXJjZU5hbWUpOwotCi0g ICAgd29ya2VyQ29udGV4dC0+YWRkTWVzc2FnZShDb25zb2xlRGVzdGluYXRpb24sIEpTTWVzc2Fn ZVNvdXJjZSwgTG9nTWVzc2FnZVR5cGUsIEVycm9yTWVzc2FnZUxldmVsLCBlcnJvck1lc3NhZ2Us IG1lc3NhZ2UtPkdldExpbmVOdW1iZXIoKSwgcmVzb3VyY2VOYW1lU3RyaW5nKTsKLX0KLQogV29y a2VyQ29udGV4dEV4ZWN1dGlvblByb3h5OjpXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkoV29y a2VyQ29udGV4dCogd29ya2VyQ29udGV4dCkKICAgICA6IG1fd29ya2VyQ29udGV4dCh3b3JrZXJD b250ZXh0KQogICAgICwgbV9yZWN1cnNpb24oMCkKQEAgLTE0Nyw5ICsxMjYsNiBAQCB2b2lkIFdv cmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6aW5pdFY4SWZOZWVkZWQoKQogICAgIHY4OjpWODo6 SWdub3JlT3V0T2ZNZW1vcnlFeGNlcHRpb24oKTsKICAgICB2ODo6Vjg6OlNldEZhdGFsRXJyb3JI YW5kbGVyKHJlcG9ydEZhdGFsRXJyb3JJblY4KTsKIAotICAgIC8vIFNldCB1cCB0aGUgaGFuZGxl ciBmb3IgVjggZXJyb3IgbWVzc2FnZS4KLSAgICB2ODo6Vjg6OkFkZE1lc3NhZ2VMaXN0ZW5lciho YW5kbGVDb25zb2xlTWVzc2FnZSk7Ci0KICAgICB2OEluaXRpYWxpemVkID0gdHJ1ZTsKIH0KIAo=