28077 2009-08-07 11:40:47 -0700 [Qt] DumpRenderTree behaves incorrectly when generating test results 2009-08-07 17:53:28 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gwright webkit-unassigned abarth oldest_to_newest 138006 0 gwright 2009-08-07 11:40:47 -0700 DumpRenderTree for the Qt port currently only dumps the PNG image data if an expected hash is provided on the commandline. When generating test results, the expected hash is not provided. The Mac port's behaviour differs in that it always dumps the PNG image data unless the expected hash and actual hash match. 138010 1 34304 gwright 2009-08-07 11:44:13 -0700 Created attachment 34304 Fix for dumping PNGs in DRT Proposed fix. 138014 2 34304 eric 2009-08-07 11:47:25 -0700 Comment on attachment 34304 Fix for dumping PNGs in DRT Specifically, not to dump the images if the hashes match. Please update the ChangeLog to be more clear. Otherwise the change looks great! 138022 3 34308 gwright 2009-08-07 11:52:28 -0700 Created attachment 34308 Amended changelog ChangeLog made more verbose 138239 4 abarth 2009-08-07 17:53:28 -0700 This patch appears to have already been landed. 34304 2009-08-07 11:44:13 -0700 2009-08-07 11:47:25 -0700 Fix for dumping PNGs in DRT DumpRenderTreeQt-dumping-fix.patch text/plain 1409 gwright ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkYTZiM2IzLi41ZDc1NmM5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDgt MDcgIEdlb3JnZSBXcmlnaHQgIDxnZW9yZ2Uud3JpZ2h0QHRvcmNobW9iaWxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggRHVtcFJlbmRl clRyZWUgZm9yIHRoZSBRdCBwb3J0IHRvIGJlaGF2ZSB0aGUgc2FtZSBhcyB0aGUgTWFjIHBvcnQu CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4MDc3 CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEdW1wUmVuZGVyVHJlZTo6ZHVtcCk6CisKIDIwMDktMDgtMDYgIENocmlz IE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlk IEh5YXR0LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJl bmRlclRyZWUuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRy ZWUuY3BwCmluZGV4IDdiOWQwNzQuLjFhZmI3NjEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTM5NCwxMCArMzk0LDE3IEBAIHZv aWQgRHVtcFJlbmRlclRyZWU6OmR1bXAoKQogCiAgICAgICAgIGZwcmludGYoc3Rkb3V0LCAiXG5B Y3R1YWxIYXNoOiAlc1xuIiwgcVByaW50YWJsZShhY3R1YWxIYXNoKSk7CiAKKyAgICAgICAgYm9v bCBkdW1wSW1hZ2UgPSB0cnVlOworCiAgICAgICAgIGlmICghbV9leHBlY3RlZEhhc2guaXNFbXB0 eSgpKSB7CiAgICAgICAgICAgICBRX0FTU0VSVChtX2V4cGVjdGVkSGFzaC5sZW5ndGgoKSA9PSAz Mik7CiAgICAgICAgICAgICBmcHJpbnRmKHN0ZG91dCwgIlxuRXhwZWN0ZWRIYXNoOiAlc1xuIiwg cVByaW50YWJsZShtX2V4cGVjdGVkSGFzaCkpOwogCisgICAgICAgICAgICBpZiAobV9leHBlY3Rl ZEhhc2ggPT0gYWN0dWFsSGFzaCkKKyAgICAgICAgICAgICAgICBkdW1wSW1hZ2UgPSBmYWxzZTsK KyAgICAgICAgfQorCisgICAgICAgIGlmIChkdW1wSW1hZ2UpIHsKICAgICAgICAgICAgIFFCdWZm ZXIgYnVmZmVyOwogICAgICAgICAgICAgYnVmZmVyLm9wZW4oUUJ1ZmZlcjo6V3JpdGVPbmx5KTsK ICAgICAgICAgICAgIGltYWdlLnNhdmUoJmJ1ZmZlciwgIlBORyIpOwo= 34308 2009-08-07 11:52:28 -0700 2009-08-07 12:08:10 -0700 Amended changelog DumpRenderTreeQt-dumping-fix-amended.patch text/plain 1455 gwright ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkYTZiM2IzLi45Njk4ZGIzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDgt MDcgIEdlb3JnZSBXcmlnaHQgIDxnZW9yZ2Uud3JpZ2h0QHRvcmNobW9iaWxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggRHVtcFJlbmRl clRyZWUgZm9yIHRoZSBRdCBwb3J0IHRvIGFsd2F5cyBkdW1wIHRoZSBQTkcgZGF0YSB1bmxlc3MK KyAgICAgICAgdGhlIGV4cGVjdGVkIGFuZCBhY3R1YWwgaGFzaGVzIG1hdGNoLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODA3NworCisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RHVtcFJlbmRlclRyZWU6OmR1bXApOgorCiAyMDA5LTA4LTA2ICBDaHJpcyBNYXJyaW4gIDxj bWFycmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBIeWF0dC4KZGlm ZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmNw cCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmNwcAppbmRl eCA3YjlkMDc0Li4xYWZiNzYxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9xdC9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUv cXQvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC0zOTQsMTAgKzM5NCwxNyBAQCB2b2lkIER1bXBSZW5k ZXJUcmVlOjpkdW1wKCkKIAogICAgICAgICBmcHJpbnRmKHN0ZG91dCwgIlxuQWN0dWFsSGFzaDog JXNcbiIsIHFQcmludGFibGUoYWN0dWFsSGFzaCkpOwogCisgICAgICAgIGJvb2wgZHVtcEltYWdl ID0gdHJ1ZTsKKwogICAgICAgICBpZiAoIW1fZXhwZWN0ZWRIYXNoLmlzRW1wdHkoKSkgewogICAg ICAgICAgICAgUV9BU1NFUlQobV9leHBlY3RlZEhhc2gubGVuZ3RoKCkgPT0gMzIpOwogICAgICAg ICAgICAgZnByaW50ZihzdGRvdXQsICJcbkV4cGVjdGVkSGFzaDogJXNcbiIsIHFQcmludGFibGUo bV9leHBlY3RlZEhhc2gpKTsKIAorICAgICAgICAgICAgaWYgKG1fZXhwZWN0ZWRIYXNoID09IGFj dHVhbEhhc2gpCisgICAgICAgICAgICAgICAgZHVtcEltYWdlID0gZmFsc2U7CisgICAgICAgIH0K KworICAgICAgICBpZiAoZHVtcEltYWdlKSB7CiAgICAgICAgICAgICBRQnVmZmVyIGJ1ZmZlcjsK ICAgICAgICAgICAgIGJ1ZmZlci5vcGVuKFFCdWZmZXI6OldyaXRlT25seSk7CiAgICAgICAgICAg ICBpbWFnZS5zYXZlKCZidWZmZXIsICJQTkciKTsK