28071 2009-08-07 09:38:55 -0700 [V8] Speed up lookupDOMWrapper by using new V8 API function. 2009-08-07 16:11:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 vitalyr webkit-unassigned abarth dglazkov oldest_to_newest 137926 0 vitalyr 2009-08-07 09:38:55 -0700 V8 bindings: speed up lookupDOMWrapper by using new V8 API function. 137928 1 34283 vitalyr 2009-08-07 09:41:22 -0700 Created attachment 34283 patch 137931 2 34283 dglazkov 2009-08-07 09:51:00 -0700 Comment on attachment 34283 patch This looks great, except for style nits: > + > + V8 bindings: speed up lookupDOMWrapper by using new V8 API function. The convention we use is to use a bracketed V8 qualifier: [V8] Speed up lookupD.... > > - static v8::Handle<v8::Object> lookupDOMWrapper(V8ClassIndex::V8WrapperType, v8::Handle<v8::Value>); > + static v8::Handle<v8::Object> lookupDOMWrapper(V8ClassIndex::V8WrapperType type, v8::Handle<v8::Object> object) > + { > + if (object.IsEmpty()) > + return object; > + > + v8::Handle<v8::FunctionTemplate> descriptor = getTemplate(type); > + return object->FindInstanceInPrototypeChain(descriptor); Great! Can we go even more succinct here?: return object.IsEmpty() ? object : object->FindInstanceInPrototypeChain(getTemplate(type)); > + } > // A helper function extract native object pointer from a DOM wrapper > // and cast to the specified type. 137938 3 34286 vitalyr 2009-08-07 09:59:50 -0700 Created attachment 34286 more succinct patch 137945 4 34286 dglazkov 2009-08-07 10:08:01 -0700 Comment on attachment 34286 more succinct patch r=me. You forgot the ChageLog change, but it's no big deal -- doesn't affect the quality of the patch. 138202 5 34286 abarth 2009-08-07 16:07:49 -0700 Comment on attachment 34286 more succinct patch Boo. Tabs in changelog. I'll land manually. 138203 6 abarth 2009-08-07 16:11:45 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/V8DOMWrapper.cpp M WebCore/bindings/v8/V8DOMWrapper.h Committed r46921 34283 2009-08-07 09:41:22 -0700 2009-08-07 09:50:59 -0700 patch lookup_wrapper.patch text/plain 2705 vitalyr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWE5NDI0Yy4uNTgwYzVhOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0wNyAgVml0YWx5IFJlcGVz aGtvICA8dml0YWx5ckBxdWFkLnNwYi5jb3JwLmdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVjggYmluZGluZ3M6IHNwZWVkIHVwIGxv b2t1cERPTVdyYXBwZXIgYnkgdXNpbmcgbmV3IFY4IEFQSSBmdW5jdGlvbi4KKworCWh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODA3MQorCisgICAgICAgICogYmluZGlu Z3MvdjgvVjhET01XcmFwcGVyLmNwcDoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdyYXBw ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV3JhcHBlcjo6bG9va3VwRE9NV3JhcHBlcik6 CisKIDIwMDktMDgtMDUgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3Jh cHBlci5jcHAKaW5kZXggYjIyNmViZC4uMTIzMmUzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5k aW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01X cmFwcGVyLmNwcApAQCAtNjk4LDIyICs2OTgsNiBAQCB2b2lkKiBWOERPTVdyYXBwZXI6OmNvbnZl cnRUb1NWR1BPRFR5cGVJbXBsKFY4Q2xhc3NJbmRleDo6VjhXcmFwcGVyVHlwZSB0eXBlLCB2OAog ICAgIHJldHVybiBpc1dyYXBwZXJPZlR5cGUob2JqZWN0LCB0eXBlKSA/IGNvbnZlcnRET01XcmFw cGVyVG9OYXRpdmU8dm9pZD4odjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdChvYmplY3QpKSA6 IDA7CiB9CiAKLXY4OjpIYW5kbGU8djg6Ok9iamVjdD4gVjhET01XcmFwcGVyOjpsb29rdXBET01X cmFwcGVyKFY4Q2xhc3NJbmRleDo6VjhXcmFwcGVyVHlwZSB0eXBlLCB2ODo6SGFuZGxlPHY4OjpW YWx1ZT4gdmFsdWUpCi17Ci0gICAgaWYgKHZhbHVlLklzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJu IG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7Ci0KLSAgICB2ODo6SGFuZGxlPHY4OjpGdW5jdGlv blRlbXBsYXRlPiBkZXNjcmlwdG9yID0gZ2V0VGVtcGxhdGUodHlwZSk7Ci0gICAgd2hpbGUgKHZh bHVlLT5Jc09iamVjdCgpKSB7Ci0gICAgICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gb2JqZWN0 ID0gdjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdCh2YWx1ZSk7Ci0gICAgICAgIGlmIChkZXNj cmlwdG9yLT5IYXNJbnN0YW5jZShvYmplY3QpKQotICAgICAgICAgICAgcmV0dXJuIG9iamVjdDsK LQotICAgICAgICB2YWx1ZSA9IG9iamVjdC0+R2V0UHJvdG90eXBlKCk7Ci0gICAgfQotICAgIHJl dHVybiBub3RIYW5kbGVkQnlJbnRlcmNlcHRvcigpOwotfSAKLQogUGFzc1JlZlB0cjxOb2RlRmls dGVyPiBWOERPTVdyYXBwZXI6OndyYXBOYXRpdmVOb2RlRmlsdGVyKHY4OjpIYW5kbGU8djg6OlZh bHVlPiBmaWx0ZXIpCiB7CiAgICAgLy8gQSBOb2RlRmlsdGVyIGlzIHVzZWQgd2hlbiB3YWxraW5n IHRocm91Z2ggYSBET00gdHJlZSBvciBpdGVyYXRpbmcgdHJlZQpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01X cmFwcGVyLmgKaW5kZXggNjZiMDU2My4uNzFjZGY2OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5k aW5ncy92OC9WOERPTVdyYXBwZXIuaAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3Jh cHBlci5oCkBAIC05OCw3ICs5OCwxNCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIC8v IFNldHMgY29udGVudHMgb2YgYSBET00gd3JhcHBlci4KICAgICAgICAgc3RhdGljIHZvaWQgc2V0 RE9NV3JhcHBlcih2ODo6SGFuZGxlPHY4OjpPYmplY3Q+LCBpbnQgdHlwZSwgdm9pZCogcHRyKTsK IAotICAgICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBsb29rdXBET01XcmFwcGVy KFY4Q2xhc3NJbmRleDo6VjhXcmFwcGVyVHlwZSwgdjg6OkhhbmRsZTx2ODo6VmFsdWU+KTsKKyAg ICAgICAgc3RhdGljIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gbG9va3VwRE9NV3JhcHBlcihWOENs YXNzSW5kZXg6OlY4V3JhcHBlclR5cGUgdHlwZSwgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBvYmpl Y3QpCisgICAgICAgIHsKKyAgICAgICAgICAgIGlmIChvYmplY3QuSXNFbXB0eSgpKQorICAgICAg ICAgICAgICAgIHJldHVybiBvYmplY3Q7CisKKyAgICAgICAgICAgIHY4OjpIYW5kbGU8djg6OkZ1 bmN0aW9uVGVtcGxhdGU+IGRlc2NyaXB0b3IgPSBnZXRUZW1wbGF0ZSh0eXBlKTsKKyAgICAgICAg ICAgIHJldHVybiBvYmplY3QtPkZpbmRJbnN0YW5jZUluUHJvdG90eXBlQ2hhaW4oZGVzY3JpcHRv cik7CisgICAgICAgIH0KIAogICAgICAgICAvLyBBIGhlbHBlciBmdW5jdGlvbiBleHRyYWN0IG5h dGl2ZSBvYmplY3QgcG9pbnRlciBmcm9tIGEgRE9NIHdyYXBwZXIKICAgICAgICAgLy8gYW5kIGNh c3QgdG8gdGhlIHNwZWNpZmllZCB0eXBlLgo= 34286 2009-08-07 09:59:50 -0700 2009-08-07 16:07:49 -0700 more succinct patch lookup_wrapper.patch text/plain 2593 vitalyr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWE5NDI0Yy4uNTgwYzVhOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0wNyAgVml0YWx5IFJlcGVz aGtvICA8dml0YWx5ckBxdWFkLnNwYi5jb3JwLmdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVjggYmluZGluZ3M6IHNwZWVkIHVwIGxv b2t1cERPTVdyYXBwZXIgYnkgdXNpbmcgbmV3IFY4IEFQSSBmdW5jdGlvbi4KKworCWh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODA3MQorCisgICAgICAgICogYmluZGlu Z3MvdjgvVjhET01XcmFwcGVyLmNwcDoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdyYXBw ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV3JhcHBlcjo6bG9va3VwRE9NV3JhcHBlcik6 CisKIDIwMDktMDgtMDUgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3Jh cHBlci5jcHAKaW5kZXggYjIyNmViZC4uMTIzMmUzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5k aW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01X cmFwcGVyLmNwcApAQCAtNjk4LDIyICs2OTgsNiBAQCB2b2lkKiBWOERPTVdyYXBwZXI6OmNvbnZl cnRUb1NWR1BPRFR5cGVJbXBsKFY4Q2xhc3NJbmRleDo6VjhXcmFwcGVyVHlwZSB0eXBlLCB2OAog ICAgIHJldHVybiBpc1dyYXBwZXJPZlR5cGUob2JqZWN0LCB0eXBlKSA/IGNvbnZlcnRET01XcmFw cGVyVG9OYXRpdmU8dm9pZD4odjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdChvYmplY3QpKSA6 IDA7CiB9CiAKLXY4OjpIYW5kbGU8djg6Ok9iamVjdD4gVjhET01XcmFwcGVyOjpsb29rdXBET01X cmFwcGVyKFY4Q2xhc3NJbmRleDo6VjhXcmFwcGVyVHlwZSB0eXBlLCB2ODo6SGFuZGxlPHY4OjpW YWx1ZT4gdmFsdWUpCi17Ci0gICAgaWYgKHZhbHVlLklzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJu IG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7Ci0KLSAgICB2ODo6SGFuZGxlPHY4OjpGdW5jdGlv blRlbXBsYXRlPiBkZXNjcmlwdG9yID0gZ2V0VGVtcGxhdGUodHlwZSk7Ci0gICAgd2hpbGUgKHZh bHVlLT5Jc09iamVjdCgpKSB7Ci0gICAgICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gb2JqZWN0 ID0gdjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdCh2YWx1ZSk7Ci0gICAgICAgIGlmIChkZXNj cmlwdG9yLT5IYXNJbnN0YW5jZShvYmplY3QpKQotICAgICAgICAgICAgcmV0dXJuIG9iamVjdDsK LQotICAgICAgICB2YWx1ZSA9IG9iamVjdC0+R2V0UHJvdG90eXBlKCk7Ci0gICAgfQotICAgIHJl dHVybiBub3RIYW5kbGVkQnlJbnRlcmNlcHRvcigpOwotfSAKLQogUGFzc1JlZlB0cjxOb2RlRmls dGVyPiBWOERPTVdyYXBwZXI6OndyYXBOYXRpdmVOb2RlRmlsdGVyKHY4OjpIYW5kbGU8djg6OlZh bHVlPiBmaWx0ZXIpCiB7CiAgICAgLy8gQSBOb2RlRmlsdGVyIGlzIHVzZWQgd2hlbiB3YWxraW5n IHRocm91Z2ggYSBET00gdHJlZSBvciBpdGVyYXRpbmcgdHJlZQpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01X cmFwcGVyLmgKaW5kZXggNjZiMDU2My4uNTdiM2E2OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5k aW5ncy92OC9WOERPTVdyYXBwZXIuaAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3Jh cHBlci5oCkBAIC05OCw3ICs5OCwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIC8v IFNldHMgY29udGVudHMgb2YgYSBET00gd3JhcHBlci4KICAgICAgICAgc3RhdGljIHZvaWQgc2V0 RE9NV3JhcHBlcih2ODo6SGFuZGxlPHY4OjpPYmplY3Q+LCBpbnQgdHlwZSwgdm9pZCogcHRyKTsK IAotICAgICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBsb29rdXBET01XcmFwcGVy KFY4Q2xhc3NJbmRleDo6VjhXcmFwcGVyVHlwZSwgdjg6OkhhbmRsZTx2ODo6VmFsdWU+KTsKKyAg ICAgICAgc3RhdGljIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gbG9va3VwRE9NV3JhcHBlcihWOENs YXNzSW5kZXg6OlY4V3JhcHBlclR5cGUgdHlwZSwgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBvYmpl Y3QpCisgICAgICAgIHsKKyAgICAgICAgICAgIHJldHVybiBvYmplY3QuSXNFbXB0eSgpID8gb2Jq ZWN0IDogb2JqZWN0LT5GaW5kSW5zdGFuY2VJblByb3RvdHlwZUNoYWluKGdldFRlbXBsYXRlKHR5 cGUpKTsKKyAgICAgICAgfQogCiAgICAgICAgIC8vIEEgaGVscGVyIGZ1bmN0aW9uIGV4dHJhY3Qg bmF0aXZlIG9iamVjdCBwb2ludGVyIGZyb20gYSBET00gd3JhcHBlcgogICAgICAgICAvLyBhbmQg Y2FzdCB0byB0aGUgc3BlY2lmaWVkIHR5cGUuCg==