28066 2009-08-07 04:47:09 -0700 Avoid using TCmalloc in DumpRenderTree 2009-08-10 05:48:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED INVALID P2 Normal --- 27879 1 zoltan webkit-unassigned oldest_to_newest 137849 0 zoltan 2009-08-07 04:47:09 -0700 Since Noncopyable'll be inherited from FastAllocBase (and RefCounted has been inherited from Noncopyable), in case of DRT classes using of TCmalloc must be avoided. This change repairs the GTK+'s DRT build fail as well (in case of inheriting Noncopyable from FastAllocBase bug #27879). 137850 1 34266 zoltan 2009-08-07 04:51:31 -0700 Created attachment 34266 proposed patch 137865 2 34266 darin 2009-08-07 07:13:47 -0700 Comment on attachment 34266 proposed patch This makes the class name RefCountedCustomAllocated seem pretty bad. After all, there's no desire to "custom allocate" here. I think we should consider doing this with the preprocessor instead of different class names when we're talking about an entirely different binary like DumpRenderTree, since USE_SYSTEM_MALLOC is already set. Can we investigate that instead? 138218 3 mrowe 2009-08-07 16:55:54 -0700 Why are we trying to avoid using FastMalloc from DumpRenderTree? DRT's config.h explicitly includes FastMalloc.h so that uses of operator new will go via fastMalloc. 138630 4 zoltan 2009-08-10 05:46:17 -0700 GTK+ guys solved the build error in r46944 (http://trac.webkit.org/changeset/46944/trunk/WebKitTools/GNUmakefile.am) which caused by Noncopyable's change, so this patch is obsolete. 34266 2009-08-07 04:51:31 -0700 2009-08-07 07:13:47 -0700 proposed patch DRT.patch text/plain 2908 zoltan SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ2ODkwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMDcgIFpvbHRhbiBIb3J2YXRoICA8 aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQXZvaWQgdXNpbmcgVENtYWxsb2MgaW4gRHVtcFJlbmRlclRyZWUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4MDY2CisK KyAgICAgICAgU2luY2UgTm9uY29weWFibGUnbGwgYmUgaW5oZXJpdGVkIGZyb20gRmFzdEFsbG9j QmFzZSAoYW5kIFJlZkNvdW50ZWQgaGFzIGJlZW4KKyAgICAgICAgaW5oZXJpdGVkIGZyb20gTm9u Y29weWFibGUpLCBpbiBjYXNlIG9mIERSVCBjbGFzc2VzIHVzaW5nIG9mIFRDbWFsbG9jIG11c3Qg YmUgYXZvaWRlZC4KKworICAgICAgICBUaGlzIGNoYW5nZSByZXBhaXJzIHRoZSBHVEsrJ3MgRFJU IGJ1aWxkIGZhaWwgYXMgd2VsbCAod2hpY2ggY2F1c2VzIGJ5IGluaGVyaXRpbmcKKyAgICAgICAg Tm9uY29weWFibGUgZnJvbSBGYXN0QWxsb2NCYXNlLCBidWcgIzI3ODc5KS4KKworICAgICAgICAq IER1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RDb250cm9sbGVyLmg6CisgICAgICAgICogRHVtcFJl bmRlclRyZWUvY2Fpcm8vUGl4ZWxEdW1wU3VwcG9ydENhaXJvLmg6CisgICAgICAgICogRHVtcFJl bmRlclRyZWUvY2cvUGl4ZWxEdW1wU3VwcG9ydENHLmg6CisKIDIwMDktMDgtMDcgIFNoaW5pY2hp cm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBB ZGVsZSBQZXRlcnNvbi4KSW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0xheW91dFRl c3RDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUv TGF5b3V0VGVzdENvbnRyb2xsZXIuaAkocmV2aXNpb24gNDY4ODkpCisrKyBXZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9MYXlvdXRUZXN0Q29udHJvbGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0z Myw3ICszMyw3IEBACiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KICNpbmNsdWRlIDxzdHJp bmc+CiAKLWNsYXNzIExheW91dFRlc3RDb250cm9sbGVyIDogcHVibGljIFJlZkNvdW50ZWQ8TGF5 b3V0VGVzdENvbnRyb2xsZXI+IHsKK2NsYXNzIExheW91dFRlc3RDb250cm9sbGVyIDogcHVibGlj IFJlZkNvdW50ZWRDdXN0b21BbGxvY2F0ZWQ8TGF5b3V0VGVzdENvbnRyb2xsZXI+IHsKIHB1Ymxp YzoKICAgICBMYXlvdXRUZXN0Q29udHJvbGxlcihjb25zdCBzdGQ6OnN0cmluZyYgdGVzdFBhdGhP clVSTCwgY29uc3Qgc3RkOjpzdHJpbmcmIGV4cGVjdGVkUGl4ZWxIYXNoKTsKICAgICB+TGF5b3V0 VGVzdENvbnRyb2xsZXIoKTsKSW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2NhaXJv L1BpeGVsRHVtcFN1cHBvcnRDYWlyby5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0R1bXBS ZW5kZXJUcmVlL2NhaXJvL1BpeGVsRHVtcFN1cHBvcnRDYWlyby5oCShyZXZpc2lvbiA0Njg4OSkK KysrIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2NhaXJvL1BpeGVsRHVtcFN1cHBvcnRDYWly by5oCSh3b3JraW5nIGNvcHkpCkBAIC00NCw3ICs0NCw3IEBAIHR5cGVkZWYgSEJJVE1BUCBQbGF0 Zm9ybUJpdG1hcEJ1ZmZlcjsKIHR5cGVkZWYgdm9pZCogUGxhdGZvcm1CaXRtYXBCdWZmZXI7CiAj ZW5kaWYKIAotY2xhc3MgQml0bWFwQ29udGV4dCA6IHB1YmxpYyBSZWZDb3VudGVkPEJpdG1hcENv bnRleHQ+IHsKK2NsYXNzIEJpdG1hcENvbnRleHQgOiBwdWJsaWMgUmVmQ291bnRlZEN1c3RvbUFs bG9jYXRlZDxCaXRtYXBDb250ZXh0PiB7CiBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8 Qml0bWFwQ29udGV4dD4gY3JlYXRlQnlBZG9wdGluZ0JpdG1hcEFuZENvbnRleHQoUGxhdGZvcm1C aXRtYXBCdWZmZXIgYnVmZmVyLCBjYWlyb190KiBjb250ZXh0KQogICAgIHsKSW5kZXg6IFdlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL2NnL1BpeGVsRHVtcFN1cHBvcnRDRy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2NnL1BpeGVsRHVtcFN1cHBvcnRDRy5oCShy ZXZpc2lvbiA0Njg4OSkKKysrIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2NnL1BpeGVsRHVt cFN1cHBvcnRDRy5oCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw3ICs0Nyw3IEBAIHR5cGVkZWYgdm9p ZCogUGxhdGZvcm1CaXRtYXBCdWZmZXI7CiB0eXBlZGVmIEhCSVRNQVAgUGxhdGZvcm1CaXRtYXBC dWZmZXI7CiAjZW5kaWYKIAotY2xhc3MgQml0bWFwQ29udGV4dCA6IHB1YmxpYyBSZWZDb3VudGVk PEJpdG1hcENvbnRleHQ+IHsKK2NsYXNzIEJpdG1hcENvbnRleHQgOiBwdWJsaWMgUmVmQ291bnRl ZEN1c3RvbUFsbG9jYXRlZDxCaXRtYXBDb250ZXh0PiB7CiBwdWJsaWM6CiAgICAgc3RhdGljIFBh c3NSZWZQdHI8Qml0bWFwQ29udGV4dD4gY3JlYXRlQnlBZG9wdGluZ0JpdG1hcEFuZENvbnRleHQo UGxhdGZvcm1CaXRtYXBCdWZmZXIgYnVmZmVyLCBDR0NvbnRleHRSZWYgY29udGV4dCkKICAgICB7 Cg==