28065 2009-08-07 01:44:20 -0700 Inherit Noncopyable publicly 2009-09-01 23:51:30 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED INVALID P2 Normal --- 27879 1 zoltan webkit-unassigned oldest_to_newest 137826 0 zoltan 2009-08-07 01:44:20 -0700 Since Noncopyable'll be inherited from FastAllocBase, Noncopyable's inheriting has to be changed to public. 137827 1 34259 zoltan 2009-08-07 01:44:57 -0700 Created attachment 34259 proposed patch 137830 2 34260 zoltan 2009-08-07 01:52:39 -0700 Created attachment 34260 updated proposed patch 137895 3 34260 eric 2009-08-07 08:36:10 -0700 Comment on attachment 34260 updated proposed patch Why? So that new/delete work? Need a couple more words in your ChangeLog. :) Is this all the instances of non-public Noncopybable inheritance? 138633 4 zoltan 2009-08-10 05:58:55 -0700 These classes aren't instantiated by new, after all don't need to inherit from publicly from Noncopyable. I tried to follow changes that have been done in bug #27225 . 144119 5 zoltan 2009-09-01 23:51:30 -0700 So, this patch contains unnecessary changes. I mark it as invalid. 34259 2009-08-07 01:44:57 -0700 2009-08-07 01:52:39 -0700 proposed patch noncopyableinheritance.patch text/plain 2819 zoltan SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA0Njg4OSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDgtMDcgIFpvbHRhbiBIb3J2YXRoICA8aHpv bHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ2hhbmdlIE5vbmNvcHlhYmxlIGluaGVyaXRpbmcgdG8gcHVibGljCisg ICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3ODc5CisKKyAg ICAgICAgU2luY2UgTm9uY29weWFibGUnbGwgYmUgaW5oZXJpdGVkIGZyb20gRmFzdEFsbG9jQmFz ZSwKKyAgICAgICAgTm9uY29weWFibGUncyBpbmhlcml0aW5nIGhhcyBiZWVuIGNoYW5nZWQgdG8g cHVibGljLgorCisgICAgICAgICogQ09NUHJvcGVydHlCYWcuaDoKKwogMjAwOS0wOC0wNiAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgcmV2ZXJ0 LgpJbmRleDogV2ViS2l0L3dpbi9DT01Qcm9wZXJ0eUJhZy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC93aW4vQ09NUHJvcGVydHlCYWcuaAkocmV2aXNpb24gNDY4ODkpCisrKyBXZWJLaXQvd2luL0NP TVByb3BlcnR5QmFnLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1LDcgKzM1LDcgQEAKICNpbmNsdWRl ICJDT01WYXJpYW50U2V0dGVyLmgiDQogDQogdGVtcGxhdGU8dHlwZW5hbWUgVmFsdWVUeXBlLCB0 eXBlbmFtZSBLZXlUeXBlID0gdHlwZW5hbWUgV2ViQ29yZTo6U3RyaW5nLCB0eXBlbmFtZSBIYXNo VHlwZSA9IHR5cGVuYW1lIFdlYkNvcmU6OlN0cmluZ0hhc2g+DQotY2xhc3MgQ09NUHJvcGVydHlC YWcgOiBwdWJsaWMgSVByb3BlcnR5QmFnLCBwdWJsaWMgSVByb3BlcnR5QmFnMiwgTm9uY29weWFi bGUgew0KK2NsYXNzIENPTVByb3BlcnR5QmFnIDogcHVibGljIElQcm9wZXJ0eUJhZywgcHVibGlj IElQcm9wZXJ0eUJhZzIsIHB1YmxpYyBOb25jb3B5YWJsZSB7DQogcHVibGljOg0KICAgICB0eXBl ZGVmIEhhc2hNYXA8S2V5VHlwZSwgVmFsdWVUeXBlLCBIYXNoVHlwZT4gSGFzaE1hcFR5cGU7DQog DQpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ2ODg5KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0wNyAgWm9sdGFuIEhvcnZhdGggIDxoem9sdGFuQGlu Zi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDaGFuZ2UgTm9uY29weWFibGUgaW5oZXJpdGluZyB0byBwdWJsaWMKKyAgICAgICAg aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc4NzkKKworICAgICAgICBT aW5jZSBOb25jb3B5YWJsZSdsbCBiZSBpbmhlcml0ZWQgZnJvbSBGYXN0QWxsb2NCYXNlLCBOb25j b3B5YWJsZSdzCisgICAgICAgIGluaGVyaXRpbmcgaGFzIGJlZW4gY2hhbmdlZCB0byBwdWJsaWMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9HcmFwaGljc0NvbnRleHRXaW5j ZS5jcHA6CisKIDIwMDktMDgtMDcgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRlcnNvbi4KSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2UvR3JhcGhpY3NDb250ZXh0V2luY2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2UvR3JhcGhpY3NDb250ZXh0 V2luY2UuY3BwCShyZXZpc2lvbiA0Njg4OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv d2luY2UvR3JhcGhpY3NDb250ZXh0V2luY2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDMsNyAr NDQzLDcgQEAKICAgICAgICAgX3JvdGF0ZUJpdG1hcDx1bnNpZ25lZCwgZmFsc2U+KGRlc3RCbXAs IHNvdXJjZUJtcCwgdHJhbnNmb3JtKTsKIH0KIAotY2xhc3MgVHJhbnNwYXJlbnRMYXllckRDIDog Tm9uY29weWFibGUgeworY2xhc3MgVHJhbnNwYXJlbnRMYXllckRDIDogcHVibGljIE5vbmNvcHlh YmxlIHsKIHB1YmxpYzoKICAgICBUcmFuc3BhcmVudExheWVyREMoR3JhcGhpY3NDb250ZXh0UGxh dGZvcm1Qcml2YXRlKiBkYXRhLCBJbnRSZWN0JiBvcmlnUmVjdCwgY29uc3QgSW50UmVjdCogcmVj dEJlZm9yZVRyYW5zZm9ybSA9IDAsIGludCBhbHBoYSA9IDI1NSwgYm9vbCBwYWludEltYWdlID0g ZmFsc2UpOwogICAgIH5UcmFuc3BhcmVudExheWVyREMoKTsKQEAgLTU2NCw3ICs1NjQsNyBAQAog ICAgIH0KIH0KIAotY2xhc3MgU2NvcGVEQ1Byb3ZpZGVyIDogTm9uY29weWFibGUgeworY2xhc3Mg U2NvcGVEQ1Byb3ZpZGVyIDogcHVibGljIE5vbmNvcHlhYmxlIHsKIHB1YmxpYzoKICAgICBleHBs aWNpdCBTY29wZURDUHJvdmlkZXIoR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlKiBkYXRh KQogICAgICAgICA6IG1fZGF0YShkYXRhKQo= 34260 2009-08-07 01:52:39 -0700 2009-08-07 08:36:10 -0700 updated proposed patch noncopyableinheritance.patch text/plain 2819 zoltan SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA0Njg4OSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDgtMDcgIFpvbHRhbiBIb3J2YXRoICA8aHpv bHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ2hhbmdlIE5vbmNvcHlhYmxlIGluaGVyaXRpbmcgdG8gcHVibGljCisg ICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4MDY1CisKKyAg ICAgICAgU2luY2UgTm9uY29weWFibGUnbGwgYmUgaW5oZXJpdGVkIGZyb20gRmFzdEFsbG9jQmFz ZSwKKyAgICAgICAgTm9uY29weWFibGUncyBpbmhlcml0aW5nIGhhcyBiZWVuIGNoYW5nZWQgdG8g cHVibGljLgorCisgICAgICAgICogQ09NUHJvcGVydHlCYWcuaDoKKwogMjAwOS0wOC0wNiAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgcmV2ZXJ0 LgpJbmRleDogV2ViS2l0L3dpbi9DT01Qcm9wZXJ0eUJhZy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC93aW4vQ09NUHJvcGVydHlCYWcuaAkocmV2aXNpb24gNDY4ODkpCisrKyBXZWJLaXQvd2luL0NP TVByb3BlcnR5QmFnLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1LDcgKzM1LDcgQEAKICNpbmNsdWRl ICJDT01WYXJpYW50U2V0dGVyLmgiDQogDQogdGVtcGxhdGU8dHlwZW5hbWUgVmFsdWVUeXBlLCB0 eXBlbmFtZSBLZXlUeXBlID0gdHlwZW5hbWUgV2ViQ29yZTo6U3RyaW5nLCB0eXBlbmFtZSBIYXNo VHlwZSA9IHR5cGVuYW1lIFdlYkNvcmU6OlN0cmluZ0hhc2g+DQotY2xhc3MgQ09NUHJvcGVydHlC YWcgOiBwdWJsaWMgSVByb3BlcnR5QmFnLCBwdWJsaWMgSVByb3BlcnR5QmFnMiwgTm9uY29weWFi bGUgew0KK2NsYXNzIENPTVByb3BlcnR5QmFnIDogcHVibGljIElQcm9wZXJ0eUJhZywgcHVibGlj IElQcm9wZXJ0eUJhZzIsIHB1YmxpYyBOb25jb3B5YWJsZSB7DQogcHVibGljOg0KICAgICB0eXBl ZGVmIEhhc2hNYXA8S2V5VHlwZSwgVmFsdWVUeXBlLCBIYXNoVHlwZT4gSGFzaE1hcFR5cGU7DQog DQpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ2ODg5KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0wNyAgWm9sdGFuIEhvcnZhdGggIDxoem9sdGFuQGlu Zi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDaGFuZ2UgTm9uY29weWFibGUgaW5oZXJpdGluZyB0byBwdWJsaWMKKyAgICAgICAg aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgwNjUKKworICAgICAgICBT aW5jZSBOb25jb3B5YWJsZSdsbCBiZSBpbmhlcml0ZWQgZnJvbSBGYXN0QWxsb2NCYXNlLCBOb25j b3B5YWJsZSdzCisgICAgICAgIGluaGVyaXRpbmcgaGFzIGJlZW4gY2hhbmdlZCB0byBwdWJsaWMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9HcmFwaGljc0NvbnRleHRXaW5j ZS5jcHA6CisKIDIwMDktMDgtMDcgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRlcnNvbi4KSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2UvR3JhcGhpY3NDb250ZXh0V2luY2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2UvR3JhcGhpY3NDb250ZXh0 V2luY2UuY3BwCShyZXZpc2lvbiA0Njg4OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv d2luY2UvR3JhcGhpY3NDb250ZXh0V2luY2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDMsNyAr NDQzLDcgQEAKICAgICAgICAgX3JvdGF0ZUJpdG1hcDx1bnNpZ25lZCwgZmFsc2U+KGRlc3RCbXAs IHNvdXJjZUJtcCwgdHJhbnNmb3JtKTsKIH0KIAotY2xhc3MgVHJhbnNwYXJlbnRMYXllckRDIDog Tm9uY29weWFibGUgeworY2xhc3MgVHJhbnNwYXJlbnRMYXllckRDIDogcHVibGljIE5vbmNvcHlh YmxlIHsKIHB1YmxpYzoKICAgICBUcmFuc3BhcmVudExheWVyREMoR3JhcGhpY3NDb250ZXh0UGxh dGZvcm1Qcml2YXRlKiBkYXRhLCBJbnRSZWN0JiBvcmlnUmVjdCwgY29uc3QgSW50UmVjdCogcmVj dEJlZm9yZVRyYW5zZm9ybSA9IDAsIGludCBhbHBoYSA9IDI1NSwgYm9vbCBwYWludEltYWdlID0g ZmFsc2UpOwogICAgIH5UcmFuc3BhcmVudExheWVyREMoKTsKQEAgLTU2NCw3ICs1NjQsNyBAQAog ICAgIH0KIH0KIAotY2xhc3MgU2NvcGVEQ1Byb3ZpZGVyIDogTm9uY29weWFibGUgeworY2xhc3Mg U2NvcGVEQ1Byb3ZpZGVyIDogcHVibGljIE5vbmNvcHlhYmxlIHsKIHB1YmxpYzoKICAgICBleHBs aWNpdCBTY29wZURDUHJvdmlkZXIoR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlKiBkYXRh KQogICAgICAgICA6IG1fZGF0YShkYXRhKQo=