280642 2024-09-30 14:55:52 -0700 Build broken with LLVM 19: Ref.h:62:16: error: member access into incomplete type 'WebCore::HTMLImageElement' 2024-10-14 14:53:22 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro ap bugs-noreply emw mcatanzaro webkit-bug-importer oldest_to_newest 2064350 0 mcatanzaro 2024-09-30 14:55:52 -0700 LLVM 19 does not like the forward declarations in WebCodecsVideoFrame.h: /builddir/build/BUILD/webkitgtk-2.46.1-build/webkitgtk-2.46.1/redhat-linux-build/webkitgtk-6.0/WTF/Headers/wtf/Ref.h:62:16: error: member access into incomplete type 'WebCore::HTMLImageElement' 62 | ptr->deref(); | ^ /builddir/build/BUILD/webkitgtk-2.46.1-build/webkitgtk-2.46.1/redhat-linux-build/webkitgtk-6.0/WTF/Headers/wtf/RefPtr.h:60:47: note: in instantiation of member function 'WTF::DefaultRefDerefTraits<WebCore::HTMLImageElement>::derefIfNotNull' requested here 60 | ALWAYS_INLINE ~RefPtr() { RefDerefTraits::derefIfNotNull(PtrTraits::exchange(m_ptr, nullptr)); } | ^ /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/variant:787:33: note: in instantiation of member function 'WTF::RefPtr<WebCore::HTMLImageElement>::~RefPtr' requested here 787 | template<typename _Ti> struct _Arr { _Ti _M_x[1]; }; | ^ /builddir/build/BUILD/webkitgtk-2.46.1-build/webkitgtk-2.46.1/Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.h:44:7: note: forward declaration of 'WebCore::HTMLImageElement' 44 | class HTMLImageElement; | ^ This is messy to clean up because we need to include a lot of headers that are currently missing from forwarding headers for unknown reasons, so need to add a bunch of files to Headers.cmake. It seems there are a *lot* of headers missing from Headers.cmake. I will only add those required to make the build succeed for me. I'm not finished yet. 2064535 1 mcatanzaro 2024-10-01 09:43:46 -0700 Pull request: https://github.com/WebKit/WebKit/pull/34508 2064546 2 mcatanzaro 2024-10-01 10:44:01 -0700 Unfortunately all the headers need to be added to XCode as well. 2064548 3 mcatanzaro 2024-10-01 10:45:12 -0700 Somebody who uses XCode will need to fix this. My pull request should be a good start, though. 2067840 4 mcatanzaro 2024-10-14 14:03:31 -0700 Pull request: https://github.com/WebKit/WebKit/pull/35168 2067849 5 ews-feeder 2024-10-14 14:53:18 -0700 Committed 285146@main (bc1be22110c3): <https://commits.webkit.org/285146@main> Reviewed commits have been landed. Closing PR #35168 and removing active labels.