280512 2024-09-27 07:31:38 -0700 REGRESSION(284269@main?) [WPE] generate-bundle is failing with assert error 2024-10-17 19:43:26 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186594 https://bugs.webkit.org/show_bug.cgi?id=280561 https://bugs.webkit.org/show_bug.cgi?id=281717 InRadar P2 Normal --- 1 dpino dpino aperez clopez lisiwei pgriffis webkit-bug-importer oldest_to_newest 2063735 0 dpino 2024-09-27 07:31:38 -0700 The script `Tools/Scripts/generate-bundle` is failing after. Taking a look at the error message and latest commit, I believe the regression was introduced by 284269@main, but I haven't confirmed it. To reproduce the error is necessary to do a build clean of WPE. In my case, I built WPE with JHBuild minimal dependencies moduleset. $ Tools/Scripts/generate-bundle --bundle=MiniBrowser --release --platform=wpe --destination=/home/pwuser/webkit/WebKitBuild/webkit-deploy-VNBqNIAhZZ Traceback (most recent call last): File "Tools/Scripts/generate-bundle", line 920, in <module> sys.exit(main()) File "Tools/Scripts/generate-bundle", line 915, in main bundle_file_path = bundle_creator.create() File "Tools/Scripts/generate-bundle", line 337, in create self._create_bundle(bundle_binary) File "Tools/Scripts/generate-bundle", line 681, in _create_bundle objects_to_copy.append(self._get_webkit_lib('InspectorResources')) File "Tools/Scripts/generate-bundle", line 377, in _get_webkit_lib assert(bundle_lib) AssertionError 2063742 1 aperez 2024-09-27 07:56:13 -0700 Ah, we need to update the script, it currently has: if bundle_binary == 'MiniBrowser': # bunddle WebKit libraries objects_to_copy.extend(self._get_webkit_binaries()) objects_to_copy.append(self._get_webkit_lib('InjectedBundle')) if self._platform == 'wpe': objects_to_copy.append(self._get_webkit_lib('InspectorResources')) Instead of that, we need to pick the inspector.gresource file. Maybe also check if other scripts need to set WEBKIT_INSPECTOR_RESOURCES_PATH in the environment to run things from the bundle or uninstalled. 2064179 2 dpino 2024-09-30 02:55:14 -0700 I cannot find `inspector.gresource` file in `WebKitBuild/WPE/Release`. OTOH, file `InspectorGResourceBundle.c` exists in `WebKitBuild/GTK/Release`. ``` $ find WebKitBuild/GTK/Release/ -name "InspectorGResourceBundle.c" WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/InspectorGResourceBundle.c ``` 2064180 3 aperez 2024-09-30 03:02:14 -0700 (In reply to Diego Pino from comment #2) > I cannot find `inspector.gresource` file in `WebKitBuild/WPE/Release`. OTOH, > file `InspectorGResourceBundle.c` exists in `WebKitBuild/GTK/Release`. > > ``` > $ find WebKitBuild/GTK/Release/ -name "InspectorGResourceBundle.c" > WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/InspectorGResourceBundle.c > ``` That's expected: the GTK port compiles the .c file into libwebkitgtk-6.0.so and only the WPE port has been changed to produce inspector.gresource 2064191 4 dpino 2024-09-30 03:55:16 -0700 > That's expected: the GTK port compiles the .c file into libwebkitgtk-6.0.so > and only the WPE port has been changed to produce inspector.gresource Ok, so now WPE should produce a file called 'inspector.gresource'. Agree. However, what I mentioned is that after building WPE I cannot find any file called 'inspector.gresource' in 'WebKitBuild/WPE/Release'. Maybe I'm looking in the wrong place. Where should be this file? 2064192 5 dpino 2024-09-30 03:59:27 -0700 The generation of 'inspector.gresource' file was fixed by Lauro in https://github.com/WebKit/WebKit/pull/34409 2064194 6 dpino 2024-09-30 04:08:46 -0700 After apply the patch by Lauro, the command: ``` Tools/Scripts/generate-bundle --bundle=MiniBrowser --release --platform=wpe --destination=/home/pwuser/webkit/WebKitBuild/webkit-deploy-VNBqNIAhZZ ``` finished successfully. I'm not sure if Lauro's patch is enough or more changes are needed, like the ones mentioned by Adrian in https://bugs.webkit.org/show_bug.cgi?id=280512#c1 2064468 7 dpino 2024-10-01 02:08:32 -0700 Pull request: https://github.com/webkit/webkit/pull/34495 2064808 8 ews-feeder 2024-10-02 01:58:09 -0700 Committed 284551@main (26028203feef): <https://commits.webkit.org/284551@main> Reviewed commits have been landed. Closing PR #34495 and removing active labels. 2064809 9 webkit-bug-importer 2024-10-02 01:59:18 -0700 <rdar://problem/137111294>