<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>28051</bug_id>
          
          <creation_ts>2009-08-06 11:14:31 -0700</creation_ts>
          <short_desc>[WINCE] make JPEGImageDecoder.cpp build for WINCE</short_desc>
          <delta_ts>2009-08-06 22:10:04 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Images</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>23154</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Joe Mason">joenotcharles</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>manyoso</cc>
    
    <cc>yong.li.webkit</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>137602</commentid>
    <comment_count>0</comment_count>
    <who name="Joe Mason">joenotcharles</who>
    <bug_when>2009-08-06 11:14:31 -0700</bug_when>
    <thetext>JPEGImageDecoder.cpp gives a compile error on WinCE: &quot;redefining INT32&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137604</commentid>
    <comment_count>1</comment_count>
      <attachid>34213</attachid>
    <who name="Joe Mason">joenotcharles</who>
    <bug_when>2009-08-06 11:17:34 -0700</bug_when>
    <thetext>Created attachment 34213
patch to JPEGImageDecoder.cpp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137665</commentid>
    <comment_count>2</comment_count>
      <attachid>34213</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-06 14:49:20 -0700</bug_when>
    <thetext>Comment on attachment 34213
patch to JPEGImageDecoder.cpp

Seems OK.  the copyright line seems like a strange place.  Also, you&apos;re releasing this in 2009, so I don&apos;t see how you can claim copyright 2007. :)  Not that it matters...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137673</commentid>
    <comment_count>3</comment_count>
    <who name="Joe Mason">joenotcharles</who>
    <bug_when>2009-08-06 15:32:51 -0700</bug_when>
    <thetext>Well, because we wrote it in 2007...  (Also, this isn&apos;t the first release - the source has been available from our web site ever since we released the first binaries.  We just missed this in the first batch of patches we submitted.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137790</commentid>
    <comment_count>4</comment_count>
      <attachid>34213</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-06 22:09:59 -0700</bug_when>
    <thetext>Comment on attachment 34213
patch to JPEGImageDecoder.cpp

Clearing review flag on attachment: 34213

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
Committed r46884
	M	WebKit/wx/ChangeLog
	A	WebKit/wx/bindings/python/wscript
r46883 = 3a864c52b9da120e2992fe77e4e2b92b32accdd7 (trunk)
	M	WebCore/ChangeLog
	M	WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
r46884 = 8fe9f42b854e18a739f8c4fa63afa00e9b18aa0c (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/46884</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137791</commentid>
    <comment_count>5</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-06 22:10:04 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34213</attachid>
            <date>2009-08-06 11:17:34 -0700</date>
            <delta_ts>2009-08-06 22:09:59 -0700</delta_ts>
            <desc>patch to JPEGImageDecoder.cpp</desc>
            <filename>bug28051.patch</filename>
            <type>text/plain</type>
            <size>1534</size>
            <attacher name="Joe Mason">joenotcharles</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NmUxZjBjYS4uYTBkOTBkOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0wOC0wNiAgWW9uZyBMaSAgPHlv
bmcubGlAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIEZpeCBKUEVHSW1hZ2VEZWNvZGVyLmNwcCBjb21waWxlIGVycm9yIG9u
IFdpbkNFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y
ODA1MQorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VE
ZWNvZGVyLmNwcDoKKwogMjAwOS0wOC0wNiAgQW5kcmFzIEJlY3NpICA8YmVjc2kuYW5kcmFzQHN0
dWQudS1zemVnZWQuaHU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRp
ZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0ltYWdl
RGVjb2Rlci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0lt
YWdlRGVjb2Rlci5jcHAKaW5kZXggOTM2N2I4ZS4uNmM0ZDNlZiAxMDA2NDQKLS0tIGEvV2ViQ29y
ZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwCisrKyBi
L1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNw
cApAQCAtNiw2ICs2LDggQEAKICAqIE90aGVyIGNvbnRyaWJ1dG9yczoKICAqICAgU3R1YXJ0IFBh
cm1lbnRlciA8c3R1YXJ0QG1vemlsbGEuY29tPgogICoKKyAqIENvcHlyaWdodCAoQykgMjAwNy0y
MDA5IFRvcmNoIE1vYmlsZSwgSW5jLgorICoKICAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3
YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqIG1vZGlmeSBpdCB1bmRlciB0
aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKICAqIExpY2Vuc2UgYXMg
cHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgpAQCAtNDAs
NiArNDIsMTUgQEAKICNpbmNsdWRlIDxhc3NlcnQuaD4KICNpbmNsdWRlIDxzdGRpby5oPiAgLy8g
TmVlZGVkIGJ5IGpwZWdsaWIuaCBmb3IgRklMRS4KIAorI2lmIFBMQVRGT1JNKFdJTkNFKQorLy8g
UmVtb3ZlIHdhcm5pbmc6ICdGQVInIG1hY3JvIHJlZGVmaW5pdGlvbgorI3VuZGVmIEZBUgorCisv
LyBqbW9yZWNmZy5oIGluIGxpYmpwZWcgY2hlY2tzIGZvciBYTURfSCB3aXRoIHRoZSBjb21tZW50
OiAiWDExL3htZC5oIGNvcnJlY3RseSBkZWZpbmVzIElOVDMyIgorLy8gZml4IElOVDMyIHJlZGVm
aW5pdGlvbiBlcnJvciBieSBwcmV0ZW5kaW5nIHdlIGFyZSBYMTEveG1kLmgKKyNkZWZpbmUgWE1E
X0gKKyNlbmRpZgorCiBleHRlcm4gIkMiIHsKICNpbmNsdWRlICJqcGVnbGliLmgiCiB9Cg==
</data>
<flag name="commit-queue"
          id="18410"
          type_id="3"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>