280424 2024-09-26 12:29:04 -0700 [ Sequoia ] fast/table/col-and-colgroup-offsets.html is a constant failure. 2025-01-13 13:02:09 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=285775 https://bugs.webkit.org/show_bug.cgi?id=285778 InRadar P2 Normal --- 1 aviduya jbedard jbedard webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 2063451 0 aviduya 2024-09-26 12:29:04 -0700 fast/table/col-and-colgroup-offsets.html is a constant failure. HISTORY: https://results.webkit.org/?suite=layout-tests&test=fast%2Ftable%2Fcol-and-colgroup-offsets.html&platform=mac DIFF: PASS document.getElementById("columnThatShouldNotBeRendered").offsetWidth is 0 Tests for offsetHeight: -FAIL document.getElementById("productNo").parentNode.offsetHeight should be 111. Was 119. -FAIL document.getElementById("productNo").offsetHeight should be 111. Was 119. -FAIL document.getElementById("productName").offsetHeight should be 111. Was 119. -FAIL document.getElementById("hasMAndHasNAndHasO").offsetHeight should be 111. Was 119. -FAIL document.getElementById("hasMAndHasN").offsetHeight should be 111. Was 119. -FAIL document.getElementById("hasO").offsetHeight should be 111. Was 119. -FAIL document.getElementById("hasP").offsetHeight should be 111. Was 119. +FAIL document.getElementById("productNo").parentNode.offsetHeight should be 108. Was 116. +FAIL document.getElementById("productNo").offsetHeight should be 108. Was 116. +FAIL document.getElementById("productName").offsetHeight should be 108. Was 116. +FAIL document.getElementById("hasMAndHasNAndHasO").offsetHeight should be 108. Was 116. +FAIL document.getElementById("hasMAndHasN").offsetHeight should be 108. Was 116. +FAIL document.getElementById("hasO").offsetHeight should be 108. Was 116. +FAIL document.getElementById("hasP").offsetHeight should be 108. Was 116. PASS document.getElementById("columnThatShouldNotBeRendered").offsetHeight is 0 When borderCollapse == "collapse" @@ -79,13 +79,13 @@ PASS document.getElementById("columnThatShouldNotBeRendered").offsetWidth is 0 Tests for offsetHeight: -PASS document.getElementById("productNo").parentNode.offsetHeight is 91 -PASS document.getElementById("productNo").offsetHeight is 91 -PASS document.getElementById("productName").offsetHeight is 91 -PASS document.getElementById("hasMAndHasNAndHasO").offsetHeight is 91 -PASS document.getElementById("hasMAndHasN").offsetHeight is 91 -PASS document.getElementById("hasO").offsetHeight is 91 -PASS document.getElementById("hasP").offsetHeight is 91 +PASS document.getElementById("productNo").parentNode.offsetHeight is 88 +PASS document.getElementById("productNo").offsetHeight is 88 +PASS document.getElementById("productName").offsetHeight is 88 +PASS document.getElementById("hasMAndHasNAndHasO").offsetHeight is 88 +PASS document.getElementById("hasMAndHasN").offsetHeight is 88 +PASS document.getElementById("hasO").offsetHeight is 88 +PASS document.getElementById("hasP").offsetHeight is 88 PASS document.getElementById("columnThatShouldNotBeRendered").offsetHeight is 0 PASS successfullyParsed is true DIFF LINK: https://build.webkit.org/results/Apple-Sequoia-Release-AppleSilicon-WK2-Tests/284293%40main%20(79)/fast/table/col-and-colgroup-offsets-diff.txt REPRODUCIBILITY: I was able to reproduce the issue on ToT using command: run-webkit-tests fast/table/col-and-colgroup-offsets.html --iterations=10 DESCRIPTION: This looks like it needs a re-baseline since most of the diff is offset by a couple pts. 2063452 1 webkit-bug-importer 2024-09-26 12:29:16 -0700 <rdar://problem/136772789> 2063458 2 aviduya 2024-09-26 12:34:05 -0700 On a second look, a rebase does not seem to be solution. Investigating further. 2063460 3 ews-feeder 2024-09-26 12:47:00 -0700 Test gardening commit 284306@main (321082fa27eb): <https://commits.webkit.org/284306@main> Reviewed commits have been landed. Closing PR #34315 and removing active labels. 2086438 4 jbedard 2025-01-10 13:11:53 -0800 Looking closely at the history of this test, there are a couple things going on. First, this test absolutely needs a rebase, I’ll work on that (and it will be covered in this bug) Second, these tests are confusing. The “Fail” in the HTML is deliberately checking that two values ARE NOT equal, so we need to make the test itself better. Third, the method checking that values are equal dumps the values it’s comparing to test output. That’s really horrible, given how LayoutTests work. Even passing tests which do this will need to be constantly rebased. I would like to change the method we're using for comparison too. 2086447 5 jbedard 2025-01-10 13:40:45 -0800 Pull request: https://github.com/WebKit/WebKit/pull/38868 2086849 6 ews-feeder 2025-01-13 13:02:07 -0800 Committed 288816@main (f97e84989be4): <https://commits.webkit.org/288816@main> Reviewed commits have been landed. Closing PR #38868 and removing active labels.