28029 2009-08-05 15:16:00 -0700 Fix DOM Storage memory leak 2009-08-05 15:48:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow webkit-unassigned fishd oldest_to_newest 137458 0 34185 jorlow 2009-08-05 15:16:00 -0700 Created attachment 34185 Patch v1 Forgot to use adoptRef in one place. This caused the = operator to increment the ref count when it should have just left it as is. The result of this was that StorageAreaImpl's were never being freed. 137461 1 34187 jorlow 2009-08-05 15:18:11 -0700 Created attachment 34187 Patch v1 137465 2 jorlow 2009-08-05 15:48:52 -0700 Sending WebCore/ChangeLog Sending WebCore/storage/StorageNamespaceImpl.cpp Transmitting file data .. Committed revision 46818. http://trac.webkit.org/changeset/46818 34185 2009-08-05 15:16:00 -0700 2009-08-05 15:17:59 -0700 Patch v1 20090805151559.patch text/plain 1199 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjgxNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDgtMDUgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BTISkKKworICAgICAgICBO byBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHN0b3JhZ2UvU3RvcmFnZU5hbWVzcGFj ZUltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3RvcmFnZU5hbWVzcGFjZUltcGw6OnN0b3Jh Z2VBcmVhKToKKwogMjAwOS0wOC0wNSAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGJ1aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUv c3RvcmFnZS9TdG9yYWdlTmFtZXNwYWNlSW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9z dG9yYWdlL1N0b3JhZ2VOYW1lc3BhY2VJbXBsLmNwcAkocmV2aXNpb24gNDY3OTUpCisrKyBXZWJD b3JlL3N0b3JhZ2UvU3RvcmFnZU5hbWVzcGFjZUltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MTAsNyArMTEwLDcgQEAgUGFzc1JlZlB0cjxTdG9yYWdlQXJlYT4gU3RvcmFnZU5hbWVzcGFjZQog ICAgIGlmIChzdG9yYWdlQXJlYSA9IG1fc3RvcmFnZUFyZWFNYXAuZ2V0KG9yaWdpbikpCiAgICAg ICAgIHJldHVybiBzdG9yYWdlQXJlYS5yZWxlYXNlKCk7CiAKLSAgICBzdG9yYWdlQXJlYSA9IG5l dyBTdG9yYWdlQXJlYUltcGwobV9zdG9yYWdlVHlwZSwgb3JpZ2luLCBtX3N5bmNNYW5hZ2VyKTsK KyAgICBzdG9yYWdlQXJlYSA9IGFkb3B0UmVmKG5ldyBTdG9yYWdlQXJlYUltcGwobV9zdG9yYWdl VHlwZSwgb3JpZ2luLCBtX3N5bmNNYW5hZ2VyKSk7CiAgICAgbV9zdG9yYWdlQXJlYU1hcC5zZXQo b3JpZ2luLCBzdG9yYWdlQXJlYSk7CiAgICAgcmV0dXJuIHN0b3JhZ2VBcmVhLnJlbGVhc2UoKTsK IH0= 34187 2009-08-05 15:18:11 -0700 2009-08-05 15:22:59 -0700 Patch v1 bug-28029-20090805151810.patch text/plain 1392 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjgxNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDgtMDUgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICBGaXggRE9NIFN0b3JhZ2UgbWVtb3J5IGxlYWsKKyAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgwMjkKKworICAgICAgIEZvcmdv dCB0byB1c2UgYWRvcHRSZWYgaW4gb25lIHBsYWNlLiAgVGhpcyBjYXVzZWQgdGhlID0gb3BlcmF0 b3IgdG8gaW5jcmVtZW50CisgICAgICAgdGhlIHJlZiBjb3VudCB3aGVuIGl0IHNob3VsZCBoYXZl IGp1c3QgbGVmdCBpdCBhcyBpcy4gIFRoZSByZXN1bHQgb2YgdGhpcyB3YXMKKyAgICAgICB0aGF0 IFN0b3JhZ2VBcmVhSW1wbCdzIHdlcmUgbmV2ZXIgYmVpbmcgZnJlZWQuCisKKyAgICAgICAgKiBz dG9yYWdlL1N0b3JhZ2VOYW1lc3BhY2VJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0b3Jh Z2VOYW1lc3BhY2VJbXBsOjpzdG9yYWdlQXJlYSk6CisKIDIwMDktMDgtMDUgIERpbWl0cmkgR2xh emtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBidWls ZCBmaXguCkluZGV4OiBXZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZU5hbWVzcGFjZUltcGwuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvc3RvcmFnZS9TdG9yYWdlTmFtZXNwYWNlSW1wbC5jcHAJKHJl dmlzaW9uIDQ2Nzk1KQorKysgV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VOYW1lc3BhY2VJbXBsLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTEwLDcgKzExMCw3IEBAIFBhc3NSZWZQdHI8U3RvcmFnZUFy ZWE+IFN0b3JhZ2VOYW1lc3BhY2UKICAgICBpZiAoc3RvcmFnZUFyZWEgPSBtX3N0b3JhZ2VBcmVh TWFwLmdldChvcmlnaW4pKQogICAgICAgICByZXR1cm4gc3RvcmFnZUFyZWEucmVsZWFzZSgpOwog Ci0gICAgc3RvcmFnZUFyZWEgPSBuZXcgU3RvcmFnZUFyZWFJbXBsKG1fc3RvcmFnZVR5cGUsIG9y aWdpbiwgbV9zeW5jTWFuYWdlcik7CisgICAgc3RvcmFnZUFyZWEgPSBhZG9wdFJlZihuZXcgU3Rv cmFnZUFyZWFJbXBsKG1fc3RvcmFnZVR5cGUsIG9yaWdpbiwgbV9zeW5jTWFuYWdlcikpOwogICAg IG1fc3RvcmFnZUFyZWFNYXAuc2V0KG9yaWdpbiwgc3RvcmFnZUFyZWEpOwogICAgIHJldHVybiBz dG9yYWdlQXJlYS5yZWxlYXNlKCk7CiB9