28022 2009-08-05 11:02:26 -0700 [Chromium] Some minor fixes needed to turn on asserts in Skia 2009-08-05 19:39:32 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco abarth oldest_to_newest 137346 0 senorblanco 2009-08-05 11:02:26 -0700 Skia doesn't like 0-width rounded rects (it will assert). 137348 1 34152 senorblanco 2009-08-05 11:08:21 -0700 Created attachment 34152 Check args before calling skia's drawRoundRect to prevent assert 137468 2 34152 dglazkov 2009-08-05 16:02:51 -0700 Comment on attachment 34152 Check args before calling skia's drawRoundRect to prevent assert Great! 137502 3 34152 abarth 2009-08-05 19:39:28 -0700 Comment on attachment 34152 Check args before calling skia's drawRoundRect to prevent assert Clearing review flag on attachment: 34152 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderThemeChromiumSkia.cpp Committed r46826 M WebCore/ChangeLog M WebCore/rendering/RenderThemeChromiumSkia.cpp r46826 = 21857865ac6b339cec28d9ff0cceae543db906b3 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46826 137503 4 abarth 2009-08-05 19:39:32 -0700 All reviewed patches have been landed. Closing bug. 34152 2009-08-05 11:08:21 -0700 2009-08-05 19:39:28 -0700 Check args before calling skia's drawRoundRect to prevent assert webkit_skia_assert_fixes_webkit.patch text/plain 1427 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjgwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDgtMDUgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgwMjIKKworICAg ICAgICBNaW5vciBmaXggZm9yIG1lZGlhIGNvZGUgb24gY2hyb21pdW0vc2tpYS4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6cGFpbnRNZWRpYVNsaWRlclRyYWNrKToKKwog MjAwOS0wOC0wNSAgQW5kcmFzIEJlY3NpICA8YmVjc2kuYW5kcmFzQHN0dWQudS1zemVnZWQuaHU+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCShyZXZpc2lvbiA0NjgwNCkK KysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNTU3LDcgKzU1Nyw5IEBAIGJvb2wgUmVuZGVyVGhlbWVDaHJvbWl1bVNraWE6 OnBhaW50TWVkaWEKICAgICAgICAgcGFpbnQucmVzZXQoKTsKICAgICAgICAgcGFpbnQuc2V0U2hh ZGVyKGdyYWRpZW50KTsKICAgICAgICAgcGFpbnQuc2V0QW50aUFsaWFzKHRydWUpOwotICAgICAg ICBjYW52YXMtPmRyYXdSb3VuZFJlY3QoYnVmZmVyZWRSZWN0LCBib3JkZXJSYWRpdXMud2lkdGgo KSwgYm9yZGVyUmFkaXVzLmhlaWdodCgpLCBwYWludCk7CisgICAgICAgIC8vIENoZWNrIGZvciBy b3VuZCByZWN0IHdpdGggemVybyB3aWR0aCBvciBoZWlnaHQsIG90aGVyd2lzZSBTa2lhIHdpbGwg YXNzZXJ0CisgICAgICAgIGlmIChidWZmZXJlZFJlY3Qud2lkdGgoKSA+IDAgJiYgYnVmZmVyZWRS ZWN0LmhlaWdodCgpID4gMCkKKyAgICAgICAgICAgIGNhbnZhcy0+ZHJhd1JvdW5kUmVjdChidWZm ZXJlZFJlY3QsIGJvcmRlclJhZGl1cy53aWR0aCgpLCBib3JkZXJSYWRpdXMuaGVpZ2h0KCksIHBh aW50KTsKICAgICAgICAgZ3JhZGllbnQtPnVucmVmKCk7CiAgICAgfQogICAgIHJldHVybiB0cnVl Owo=