280073 2024-09-20 10:41:24 -0700 REGRESSION(283414@main): [WPE][GTK] File descriptor leak if process launch is canceled immediately 2024-09-24 08:18:06 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=280061 https://bugs.webkit.org/show_bug.cgi?id=280237 P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply mcatanzaro oldest_to_newest 2061880 0 mcatanzaro 2024-09-20 10:41:24 -0700 Since 283414@main, if the ProcessLauncher is destroyed before received a reply from its pid socket, the server end of the socket is leaked. The bug is here in ProcessLauncherGLib.cpp's ProcessLauncher::launchProcess: m_socketMonitor.start(pidSocket.get(), G_IO_IN, RunLoop::main(), [protectedThis = Ref { *this }, this, pidSocket, serverSocket = WTFMove(webkitSocketPair.server)](GIOCondition condition) -> gboolean { That code moves ownership of the socket to the lambda function, without resource-acquisition-is-initialization semantics. If the socket monitor is destroyed before executing the callback, the socket is leaked. Using UnixFileDescriptor like we're supposed to would have prevented this, but I was overconfident because the code seemed simple. See also: bug #280061 2062341 1 mcatanzaro 2024-09-23 08:30:10 -0700 Pull request: https://github.com/WebKit/WebKit/pull/34089 2062550 2 mcatanzaro 2024-09-23 17:05:06 -0700 Follow up: bug #280237 2062740 3 ews-feeder 2024-09-24 08:18:03 -0700 Committed 284159@main (7dd6aeafdd8e): <https://commits.webkit.org/284159@main> Reviewed commits have been landed. Closing PR #34089 and removing active labels.